Skip to content

Commit 94c9164

Browse files
Update desciptions or errors in existing unit tests.
1 parent 06553e7 commit 94c9164

File tree

1 file changed

+19
-15
lines changed

1 file changed

+19
-15
lines changed

jbmc/unit/java_bytecode/java_bytecode_parser/parse_java_attributes.cpp

Lines changed: 19 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ SCENARIO(
2222
load_java_class("InnerClasses", "./java_bytecode/java_bytecode_parser");
2323
WHEN("Parsing the InnerClasses attribute for a public inner class")
2424
{
25-
THEN("The class should be marked as public")
25+
THEN("The inner class should be marked as public")
2626
{
2727
const symbolt &class_symbol =
2828
new_symbol_table.lookup_ref("java::InnerClasses$PublicInnerClass");
@@ -35,7 +35,7 @@ SCENARIO(
3535
}
3636
WHEN("Parsing the InnerClasses attribute for a package private inner class")
3737
{
38-
THEN("The class should be marked as default")
38+
THEN("The inner class should be marked as default")
3939
{
4040
const symbolt &class_symbol =
4141
new_symbol_table.lookup_ref("java::InnerClasses$DefaultInnerClass");
@@ -48,7 +48,7 @@ SCENARIO(
4848
}
4949
WHEN("Parsing the InnerClasses attribute for a protected inner class")
5050
{
51-
THEN("The class should be marked as protected")
51+
THEN("The inner class should be marked as protected")
5252
{
5353
const symbolt &class_symbol =
5454
new_symbol_table.lookup_ref("java::InnerClasses$ProtectedInnerClass");
@@ -61,7 +61,7 @@ SCENARIO(
6161
}
6262
WHEN("Parsing the InnerClasses attribute for a private inner class")
6363
{
64-
THEN("The class should be marked as private")
64+
THEN("The inner class should be marked as private")
6565
{
6666
const symbolt &class_symbol =
6767
new_symbol_table.lookup_ref("java::InnerClasses$PrivateInnerClass");
@@ -73,7 +73,9 @@ SCENARIO(
7373
}
7474
}
7575
}
76-
GIVEN("Some package-private class files in the class path with inner classes")
76+
GIVEN(
77+
"Some package-private (default) class files in the class path with inner "
78+
"classes")
7779
{
7880
const symbol_tablet &new_symbol_table = load_java_class(
7981
"InnerClassesDefault", "./java_bytecode/java_bytecode_parser");
@@ -90,9 +92,11 @@ SCENARIO(
9092
REQUIRE(java_class.get_access() == ID_public);
9193
}
9294
}
93-
WHEN("Parsing the InnerClasses attribute for a package private inner class")
95+
WHEN(
96+
"Parsing the InnerClasses attribute for a package private (default) "
97+
"inner class")
9498
{
95-
THEN("The class should be marked as default")
99+
THEN("The inner class should be marked as package-private (default)")
96100
{
97101
const symbolt &class_symbol = new_symbol_table.lookup_ref(
98102
"java::InnerClassesDefault$DefaultInnerClass");
@@ -118,7 +122,7 @@ SCENARIO(
118122
}
119123
WHEN("Parsing the InnerClasses attribute for a private inner class")
120124
{
121-
THEN("The class should be marked as private")
125+
THEN("The inner class should be marked as private")
122126
{
123127
const symbolt &class_symbol = new_symbol_table.lookup_ref(
124128
"java::InnerClassesDefault$PrivateInnerClass");
@@ -154,10 +158,10 @@ SCENARIO(
154158
}
155159
}
156160
WHEN(
157-
"Parsing the InnerClasses attribute for a package private doubly-nested "
158-
"inner class")
161+
"Parsing the InnerClasses attribute for a package private (default) "
162+
"doubly-nested inner class")
159163
{
160-
THEN("The class should be marked as default")
164+
THEN("The inner class should be marked as package-private (default)")
161165
{
162166
const symbolt &class_symbol = new_symbol_table.lookup_ref(
163167
"java::InnerClassesDeeplyNested$SinglyNestedClass$"
@@ -170,10 +174,10 @@ SCENARIO(
170174
}
171175
}
172176
WHEN(
173-
"Parsing the InnerClasses attribute for a protected doubly-nested inner "
174-
"class")
177+
"Parsing the InnerClasses attribute for a package private (default) "
178+
"doubly-nested inner class ")
175179
{
176-
THEN("The class should be marked as protected")
180+
THEN("The inner class should be marked as protected")
177181
{
178182
const symbolt &class_symbol = new_symbol_table.lookup_ref(
179183
"java::InnerClassesDeeplyNested$SinglyNestedClass$"
@@ -189,7 +193,7 @@ SCENARIO(
189193
"Parsing the InnerClasses attribute for a private doubly-nested inner "
190194
"class")
191195
{
192-
THEN("The class should be marked as private")
196+
THEN("The inner class should be marked as private ")
193197
{
194198
const symbolt &class_symbol = new_symbol_table.lookup_ref(
195199
"java::InnerClassesDeeplyNested$SinglyNestedClass$"

0 commit comments

Comments
 (0)