From d9026ae79e5f96fd20aa4feecebf47638ac6f0e7 Mon Sep 17 00:00:00 2001
From: Chris Smowton <chris@smowton.net>
Date: Fri, 16 Sep 2016 15:15:38 +0100
Subject: [PATCH] Keep SSA L1 IDs as an attribute

Previously these were derived from the full SSA ID by searching for the last character that can't feature in a C identifier. Unfortunately a period /can/ feature in a Java identifier (e.g. mypackage.myclass.myfunction). Alternatively we could just flip the #if test at ssa_expr.h:67, but there was apparently a performance motive to avoid this in the first place.
---
 src/util/irep_ids.txt |  1 +
 src/util/ssa_expr.cpp | 24 +++++++++++++++++-------
 src/util/ssa_expr.h   | 18 +++++++-----------
 3 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/src/util/irep_ids.txt b/src/util/irep_ids.txt
index 82ff934bd2f..60a8266bbf0 100644
--- a/src/util/irep_ids.txt
+++ b/src/util/irep_ids.txt
@@ -693,6 +693,7 @@ C_full_identifier #full_identifier
 L0
 L1
 L2
+L1_object_identifier
 already_typechecked
 C_va_arg_type #va_arg_type
 smt2_symbol
diff --git a/src/util/ssa_expr.cpp b/src/util/ssa_expr.cpp
index 5b54e2d649c..c75d7d2ed92 100644
--- a/src/util/ssa_expr.cpp
+++ b/src/util/ssa_expr.cpp
@@ -30,13 +30,14 @@ static void build_ssa_identifier_rec(
   const irep_idt &l0,
   const irep_idt &l1,
   const irep_idt &l2,
-  std::ostream &os)
+  std::ostream &os,
+  std::ostream &l1_object_os)
 {
   if(expr.id()==ID_member)
   {
     const member_exprt &member=to_member_expr(expr);
 
-    build_ssa_identifier_rec(member.struct_op(), l0, l1, l2, os);
+    build_ssa_identifier_rec(member.struct_op(), l0, l1, l2, os, l1_object_os);
 
     os << '.' << member.get_component_name();
   }
@@ -44,7 +45,7 @@ static void build_ssa_identifier_rec(
   {
     const index_exprt &index=to_index_expr(expr);
 
-    build_ssa_identifier_rec(index.array(), l0, l1, l2, os);
+    build_ssa_identifier_rec(index.array(), l0, l1, l2, os, l1_object_os);
 
     mp_integer idx;
     if(to_integer(to_constant_expr(index.index()), idx))
@@ -54,13 +55,21 @@ static void build_ssa_identifier_rec(
   }
   else if(expr.id()==ID_symbol)
   {
-    os << to_symbol_expr(expr).get_identifier();
+    auto symid=to_symbol_expr(expr).get_identifier();
+    os << symid;
+    l1_object_os << symid;
 
     if(!l0.empty())
+    {
       os << '!' << l0;
+      l1_object_os << '!' << l0;
+    }
 
     if(!l1.empty())
+    {
       os << '@' << l1;
+      l1_object_os << '@' << l1;
+    }
 
     if(!l2.empty())
       os << '#' << l2;
@@ -81,15 +90,16 @@ Function: ssa_exprt::build_identifier
 
 \*******************************************************************/
 
-irep_idt ssa_exprt::build_identifier(
+std::pair<irep_idt, irep_idt> ssa_exprt::build_identifier(
   const exprt &expr,
   const irep_idt &l0,
   const irep_idt &l1,
   const irep_idt &l2)
 {
   std::ostringstream oss;
+  std::ostringstream l1_object_oss;
 
-  build_ssa_identifier_rec(expr, l0, l1, l2, oss);
+  build_ssa_identifier_rec(expr, l0, l1, l2, oss, l1_object_oss);
 
-  return oss.str();
+  return std::make_pair(irep_idt(oss.str()), irep_idt(l1_object_oss.str()));
 }
diff --git a/src/util/ssa_expr.h b/src/util/ssa_expr.h
index 36ab025b821..31064c1ec60 100644
--- a/src/util/ssa_expr.h
+++ b/src/util/ssa_expr.h
@@ -67,15 +67,9 @@ class ssa_exprt:public symbol_exprt
     #if 0
     return get_l1_object().get_identifier();
     #else
-    // the above is the clean version, this is the fast one, making
-    // use of internal knowledge about identifier names
-    std::string l1_o_id=id2string(get_identifier());
-    std::string::size_type fs_suffix=l1_o_id.find_first_of(".[#");
-
-    if(fs_suffix!=std::string::npos)
-      l1_o_id.resize(fs_suffix);
-
-    return l1_o_id;
+    // the above is the clean version, this is the fast one, using
+    // an identifier cached during build_identifier
+    return get(ID_L1_object_identifier);
     #endif
   }
 
@@ -130,10 +124,12 @@ class ssa_exprt:public symbol_exprt
     const irep_idt &l1=get_level_1();
     const irep_idt &l2=get_level_2();
 
-    set_identifier(build_identifier(get_original_expr(), l0, l1, l2));
+    auto idpair=build_identifier(get_original_expr(), l0, l1, l2);
+    set_identifier(idpair.first);
+    set(ID_L1_object_identifier, idpair.second);
   }
 
-  static irep_idt build_identifier(
+  static std::pair<irep_idt, irep_idt> build_identifier(
     const exprt &src,
     const irep_idt &l0,
     const irep_idt &l1,