Add support for "Number Of Imports Needed Imports for .*"

[im-bob-loucans]

More of a feature request if it does not already exist in the tool.

Is it possible to apply the "Number Of Imports Needed Imports for .*" preference when organizing imports?

[nedtwigg]

It's definitely possible! It's not a priority for me, but I'd be happy to merge a PR, and to help along the way.

For code formatting, we use the actual jars from Eclipse. For import sorting, we have a knockoff that can read Eclipse's import files, but it doesn't support all of their functionality.

ImportSorterStep is what reads the user's input, and ImportSorterImpl is what does the actual import sorting. The impl part is copied from https://github.com/krasa/EclipseCodeFormatter. It looks like they've made a lot of progress since we last incorporated their work.

If you (or anyone else) is interested in digging into this, I'd be happy to offer help here or in the gitter channel.

[nedtwigg]

I just dug into this a little, and krasa/EclipseCodeFormatter hasn't implemented this. If we wanted to use the Eclipse implementation, the key code is this: org.eclipse.jdt.core.dom.rewrite.ImportRewrite.java, and here's an example of it in use: ImportRewriteTest.

[im-bob-loucans]

Well I finally got to fork the project. See what I can do over the next couple of weeks

[nedtwigg]

Great, thanks! Just as a heads-up, I'll be updating Spotless to Eclipse Neon and Gradle 2.14 around late June, as well as adding support for .gitattributes. This won't affect any Spotless API's, and I highly doubt that the Eclipse Neon API will be much different than the Mars API, so we shouldn't have any conflicts.

[sbrannen]

It's not super high on our priority list, but.... the JUnit 5 team would certainly appreciate seeing this support implemented in Spotless. 😉

[nedtwigg]

One year without progress. Also, googleJavaFormat() is gaining popularity, and it bans wildcard imports. Future contributors are free to reopen if any progress is made.

[sbrannen]

😞

[DJViking]

Has there been any improvements to enforce the googleJavaFormat of banning wildcard imports?
The Eclipse formater I am using with Spotless (which is derived from the Google standard) does remove the wildcard imports in the IDE, but spotless does nothing about it.

java {
    importOrderFile 'config/spotless/my-eclipse.importorder'
    eclipse().configFile 'config/spotless/my-eclipse-format.xml'

    trimTrailingWhitespace()
    removeUnusedImports()
}

[nedtwigg]

There isn't and there probably won't be. For example:

import pkgA.*;
import pkgB.*;

public class Test {
  AmIFromAorB field;
}

When you organize imports in eclipse, the IDE knows whether AmIFromAorB came from A or B, so it can dereference it properly. But spotless's model is just Function<String, String>, so it doesn't know the whole build path, and it would be very difficult to change this.

[DJViking]

I don't mean spotless should change it, but allow to fail if wildcard imports are used.

failIfWildcardImports()

[nedtwigg]

Ahh. I am not aware of anyone currently working on the issue, but the issue you want to watch is probably #167

[rnett]

Google Java Format doesn't handle this apparently (google/google-java-format#113), so it would be nice to have here. Doesn't seem easy though.