Reinstall node if necessary #867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't think of a good way to test this, unfortunately. If you have an idea, please share :) |
nedtwigg
requested changes
May 13, 2021
There was a problem hiding this comment.
- Run
spotlessApply - Did you integration test on your machine to confirm that it fixed your problem?
lib/src/main/java/com/diffplug/spotless/npm/NodeServerLayout.java
Outdated
Show resolved
Hide resolved
If node has been deleted between Spotless installing it and using it (for example because React's `build` removes everything from the `build` dir), it is not re-installed. Fixes #863
Oh, I'm so sorry. Fixed now.
Yes, and it works :) |
|
Shipped in |
|
That was very quick and nice. Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If node has been deleted between Spotless installing it and using it
(for example because React's
buildremoves everything from thebuilddir), it is not re-installed.
Fixes #863