Tierprice can't save float percentage value magento#18651. Fixed invalid zeros trimming.

novikor · novikor · commit 53aff6039e5c · 2019-05-18T13:10:18.000Z
diff --git a/app/code/Magento/Catalog/Pricing/Render/PriceBox.php b/app/code/Magento/Catalog/Pricing/Render/PriceBox.php
@@ -102,10 +102,16 @@ public function getCanDisplayQty(Product $product)
      * Format percent
      *
      * @param float $percent
+     *
      * @return string
      */
     public function formatPercent(float $percent): string
     {
-        return rtrim(number_format($percent, 2), '.0');
+        /*First rtrim - trim zeros. So, 10.00 -> 10.*/
+        /*Second rtrim - trim dot. So, 10. -> 10*/
+        return rtrim(
+            rtrim(number_format($percent, 2), '0'),
+            '.'
+        );
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -102,10 +102,16 @@ public function getCanDisplayQty(Product $product)`
`102`	`102`	`* Format percent`
`103`	`103`	`*`
`104`	`104`	`* @param float $percent`
	`105`	`+ *`
`105`	`106`	`* @return string`
`106`	`107`	`*/`
`107`	`108`	`public function formatPercent(float $percent): string`
`108`	`109`	`{`
`109`		`- return rtrim(number_format($percent, 2), '.0');`
	`110`	`+ /First rtrim - trim zeros. So, 10.00 -> 10./`
	`111`	`+ /Second rtrim - trim dot. So, 10. -> 10/`
	`112`	`+ return rtrim(`
	`113`	`+ rtrim(number_format($percent, 2), '0'),`
	`114`	`+ '.'`
	`115`	`+ );`
`110`	`116`	`}`
`111`	`117`	`}`