Add Postgis to tests, attemt to add regression test

Author: jieter

tests/models.py

@@ -1,3 +1,4 @@
+from django.conf import settings
 from django.db import models
 
 
@@ -23,3 +24,10 @@ class Binary(models.Model):
 
     class PostgresJSON(models.Model):
         field = JSONField()
+
+
+if settings.USE_GIS:
+    from django.contrib.gis.db import models as gismodels
+
+    class Location(gismodels.Model):
+        point = gismodels.PointField()

tests/panels/test_staticfiles.py

@@ -28,9 +28,10 @@ def test_default_case(self):
         )
         self.assertEqual(self.panel.num_used, 0)
         self.assertNotEqual(self.panel.num_found, 0)
-        self.assertEqual(
-            self.panel.get_staticfiles_apps(), ["django.contrib.admin", "debug_toolbar"]
-        )
+        expected_apps = ["django.contrib.admin", "debug_toolbar"]
+        if settings.USE_GIS:
+            expected_apps = ["django.contrib.gis"] + expected_apps
+        self.assertEqual(self.panel.get_staticfiles_apps(), expected_apps)
         self.assertEqual(
             self.panel.get_staticfiles_dirs(), finders.FileSystemFinder().locations
         )
@@ -75,9 +76,10 @@ def test_finder_directory_does_not_exist(self):
         )
         self.assertEqual(self.panel.num_used, 0)
         self.assertNotEqual(self.panel.num_found, 0)
-        self.assertEqual(
-            self.panel.get_staticfiles_apps(), ["django.contrib.admin", "debug_toolbar"]
-        )
+        expected_apps = ["django.contrib.admin", "debug_toolbar"]
+        if settings.USE_GIS:
+            expected_apps = ["django.contrib.gis"] + expected_apps
+        self.assertEqual(self.panel.get_staticfiles_apps(), expected_apps)
         self.assertEqual(
             self.panel.get_staticfiles_dirs(), finders.FileSystemFinder().locations
         )

tests/settings.py

@@ -27,6 +27,11 @@
     "tests",
 ]
 
+USE_GIS = os.getenv("DB_BACKEND") in ("postgis",)
+
+if USE_GIS:
+    INSTALLED_APPS = ["django.contrib.gis"] + INSTALLED_APPS
+
 MEDIA_URL = "/media/"  # Avoids https://code.djangoproject.com/ticket/21451
 
 MIDDLEWARE = [
@@ -81,7 +86,9 @@
 
 DATABASES = {
     "default": {
-        "ENGINE": "django.db.backends.%s" % os.getenv("DB_BACKEND"),
+        "ENGINE": "django.{}db.backends.{}".format(
+            "contrib.gis." if USE_GIS else "", os.getenv("DB_BACKEND")
+        ),
         "NAME": os.getenv("DB_NAME"),
         "USER": os.getenv("DB_USER"),
         "PASSWORD": os.getenv("DB_PASSWORD"),

tests/test_integration.py

@@ -1,9 +1,12 @@
+import json
 import os
 import re
 import unittest
 
 import django
 import html5lib
+from django.conf import settings
+from django.contrib.gis.geos import GEOSGeometry
 from django.contrib.staticfiles.testing import StaticLiveServerTestCase
 from django.core import signing
 from django.db import connection
@@ -14,6 +17,7 @@
 
 from debug_toolbar.middleware import DebugToolbarMiddleware, show_toolbar
 from debug_toolbar.panels import Panel
+from debug_toolbar.panels.sql.forms import SQLSelectForm
 from debug_toolbar.toolbar import DebugToolbar
 
 from .base import BaseTestCase, IntegrationTestCase
@@ -236,6 +240,26 @@ def test_sql_explain_checks_show_toolbar(self):
             )
             self.assertEqual(response.status_code, 404)
 
+    @unittest.skipUnless(settings.USE_GIS, "Test only valid with gis support")
+    def test_sql_explain_gis(self):
+        from .models import Location
+
+        db_table = Location._meta.db_table
+
+        url = "/__debug__/sql_explain/"
+        geom = GEOSGeometry("POLYGON((0 0, 0 1, 1 1, 0 0))")
+        data = {
+            "sql": f'SELECT "{db_table}"."point" FROM "{db_table}" WHERE "{db_table}"."point" @ {geom.hex} LIMIT 1',
+            "raw_sql": f'SELECT "{db_table}"."point" FROM "{db_table}" WHERE "{db_table}"."point" @ %s LIMIT 1',
+            "params": json.dumps([geom.hex]),
+            "alias": "default",
+            "duration": "0",
+        }
+        data["hash"] = SQLSelectForm().make_hash(data)
+
+        response = self.client.post(url, data=data)
+        self.assertEqual(response.status_code, 200)
+
     @unittest.skipUnless(
         connection.vendor == "postgresql", "Test valid only on PostgreSQL"
     )

tox.ini

@@ -6,7 +6,7 @@ envlist =
     py{36,37,38,39}-dj22-sqlite
     py{36,37,38,39}-dj{30,31}-sqlite
     py{36,37,38,39}-djmaster-sqlite
-    py{37,38,39}-dj{22,30,31}-{postgresql,mysql}
+    py{37,38,39}-dj{22,30,31}-{postgresql,mysql,postgis}
 
 [testenv]
 deps =
@@ -15,6 +15,7 @@ deps =
     dj31: Django==3.1.*
     sqlite: mock
     postgresql: psycopg2-binary
+    postgis: psycopg2-binary
     mysql: mysqlclient
     djmaster: https://github.com/django/django/archive/master.tar.gz
     coverage
@@ -69,4 +70,5 @@ python =
 DB_BACKEND =
     mysql: mysql
     postgresql: postgresql
+    postgis: postgresql
     sqlite3: sqlite