Add test for relationship pointer in errors

Signed-off-by: Mehdy Khoshnoody <[email protected]>

Author: mehdy

example/tests/snapshots/snap_test_errors.py

@@ -44,6 +44,17 @@
     ]
 }
 
+snapshots["test_relationship_errors_has_correct_pointers 1"] = {
+    "errors": [
+        {
+            "code": "incorrect_type",
+            "detail": "Incorrect type. Expected resource identifier object, received str.",
+            "source": {"pointer": "/data/relationships/author"},
+            "status": "400",
+        }
+    ]
+}
+
 snapshots["test_second_level_array_error 1"] = {
     "errors": [
         {

example/tests/test_errors.py

@@ -1,13 +1,33 @@
 import pytest
 from django.test import override_settings
 from django.urls import path, reverse
-from rest_framework import views
+from rest_framework import generics
 
 from rest_framework_json_api import serializers
 
 from example.models import Blog
 
 
+class AuthorModelMock:
+    __name__ = "author"
+
+    @property
+    def model(self):
+        return self
+
+    @property
+    def queryset(self):
+        return self
+
+    def create(self, *args, **kwargs):
+        pass
+
+    def get(self, pk):
+        if isinstance(pk, int):
+            return self
+        raise TypeError("pk must be integer")
+
+
 # serializers
 class CommentAttachmentSerializer(serializers.Serializer):
     data = serializers.CharField(allow_null=False, required=True)
@@ -30,6 +50,9 @@ class EntrySerializer(serializers.Serializer):
     comment = CommentSerializer(required=False)
     headline = serializers.CharField(allow_null=True, required=True)
     body_text = serializers.CharField()
+    author = serializers.ResourceRelatedField(
+        queryset=AuthorModelMock().queryset, required=False
+    )
 
     def validate(self, attrs):
         body_text = attrs["body_text"]
@@ -40,13 +63,12 @@ def validate(self, attrs):
 
 
 # view
-class DummyTestView(views.APIView):
+class DummyTestView(generics.CreateAPIView):
     serializer_class = EntrySerializer
     resource_name = "entries"
 
-    def post(self, request, *args, **kwargs):
-        serializer = self.serializer_class(data=request.data)
-        serializer.is_valid(raise_exception=True)
+    def get_serializer_context(self):
+        return {}
 
 
 urlpatterns = [
@@ -191,3 +213,21 @@ def test_many_third_level_dict_errors(client, some_blog, snapshot):
     }
 
     snapshot.assert_match(perform_error_test(client, data))
+
+
+def test_relationship_errors_has_correct_pointers(client, some_blog, snapshot):
+    data = {
+        "data": {
+            "type": "entries",
+            "attributes": {
+                "blog": some_blog.pk,
+                "bodyText": "body_text",
+                "headline": "headline",
+            },
+            "relationships": {
+                "author": {"data": {"id": "INVALID_ID", "type": "authors"}}
+            },
+        }
+    }
+
+    snapshot.assert_match(perform_error_test(client, data))