Skip to content

Bugs in special character handling #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
CHU295 opened this issue Apr 3, 2020 · 9 comments
Closed
1 task

Bugs in special character handling #1103

CHU295 opened this issue Apr 3, 2020 · 9 comments

Comments

@CHU295
Copy link
Contributor

CHU295 commented Apr 3, 2020

Bug Report

Steps to reproduce

When there is a special character in a title, the a tag will escape this character, but the key searched by the serach component will directly ignore it。

For example, now there is a title called 'developer's Guide', which will be converted to 'developer 39s guide', but in 'docsify. Search. Index', it will be converted to 'developers guide', The character ' is ignored

This causes the click search result to be unable to locate

What is current behaviour

What is the expected behaviour

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version:

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@CHU295
Copy link
Contributor Author

CHU295 commented Apr 3, 2020

This is the last bug I mentioned
Now I find this reason

#1098

@CHU295
Copy link
Contributor Author

CHU295 commented Apr 3, 2020

And Chinese characters have the same problem

@anikethsaha anikethsaha added bug confirmed as a bug pr welcome labels Apr 3, 2020
@anikethsaha
Copy link
Member

Feel free to submit a fix

@Koooooo-7
Copy link
Member

Feel free to submit a fix

I remember it was working correctly about the escape sequences issues.
it seems refactoring problems.

@anikethsaha
Copy link
Member

I think it was because I had to remove css.escape package in order to patch an immediate fix as css.escape was not bundling along with the other module during build using rollup.
not sure ! forgot the context of this.

@Koooooo-7 can you point me the issue/PR were it was fixed?

@Koooooo-7
Copy link
Member

@anikethsaha
I pulled the v4.11.3 , it works correctly, I cant reproduce it right now. 😅

@anikethsaha
Copy link
Member

@Koooooo-7 thanks for the input.

@CHU295 can you mention which version you are on ? also try using 4.11.3

@anikethsaha anikethsaha added not-reproducible and removed pr welcome bug confirmed as a bug labels Apr 3, 2020
@CHU295
Copy link
Contributor Author

CHU295 commented Apr 10, 2020

It's marked.js`s parsing rules that cause~@anikethsaha

@Koooooo-7
Copy link
Member

Koooooo-7 commented Apr 10, 2020

so , what's ur version and trying to use v4.11.3 to make sure whether it is reproducible.
if u have more useful information, u could show more details and reopen it for more discussion.

thx for ur report. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants