Skip to content

Sidebar logo not working #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
blaasvaer opened this issue Oct 6, 2021 · 8 comments
Closed
1 task

Sidebar logo not working #1646

blaasvaer opened this issue Oct 6, 2021 · 8 comments

Comments

@blaasvaer
Copy link

Bug Report

This does nothing:

window.$docsify = {
  logo: '/_media/icon.svg',
};

I've tried all variations of:
'/_media/icon.svg',
'_media/icon.svg',
'/media/icon.svg',
'media/icon.svg',

None make any difference. I can easily place the logo on the coverpage ... but using that same url with 'logo:' doesn't work either.

Steps to reproduce

Erhm, well change the path ...

What is current behaviour

Noting happens.

What is the expected behaviour

I should see a logo in the sidebar (I guess), as the docs describe.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version:

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@sy-records
Copy link
Member

You can create a reproducible sandbox, or provide a repo

@blaasvaer
Copy link
Author

I've created a clean sandbox: https://codesandbox.io/s/ecstatic-sun-cpuj6?file=/index.html

I've copy/pasted the complete config from my project ... and, as you can see, the logo does not appear.

@blaasvaer
Copy link
Author

And there seems to be something screwed up ... after posting ... in the sandbox.

@blaasvaer
Copy link
Author

@blaasvaer
Copy link
Author

It seems that everytime I click the refresh button over in the viewer (https://bvvj5.csb.app/#/) it screws up the result!?

@blaasvaer
Copy link
Author

Well, anyway – the logo does not appear either way. So something must be wrong ... if not, then you should seriously update the docs, as that was what I followed exactly.

@blaasvaer
Copy link
Author

OK, seems to have found the culprit. You – NOT obviously – CANNOT HAVE AN EMPTY 'name' ... !

Please, add a note of this 'dependency' in the docs.

@blaasvaer
Copy link
Author

blaasvaer commented Oct 7, 2021

Simply make a check for an empty "name" somewhere in the build process … and handle accordingly.

This was referenced Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants