-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Sidebar logo not working #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You can create a reproducible sandbox, or provide a repo |
I've created a clean sandbox: https://codesandbox.io/s/ecstatic-sun-cpuj6?file=/index.html I've copy/pasted the complete config from my project ... and, as you can see, the logo does not appear. |
And there seems to be something screwed up ... after posting ... in the sandbox. |
Tried a fresh sandbox: https://codesandbox.io/s/flamboyant-surf-bvvj5?file=/index.html |
It seems that everytime I click the refresh button over in the viewer (https://bvvj5.csb.app/#/) it screws up the result!? |
Well, anyway – the logo does not appear either way. So something must be wrong ... if not, then you should seriously update the docs, as that was what I followed exactly. |
OK, seems to have found the culprit. You – NOT obviously – CANNOT HAVE AN EMPTY 'name' ... ! Please, add a note of this 'dependency' in the docs. |
Simply make a check for an empty "name" somewhere in the build process … and handle accordingly. |
Bug Report
This does nothing:
I've tried all variations of:
'/_media/icon.svg',
'_media/icon.svg',
'/media/icon.svg',
'media/icon.svg',
None make any difference. I can easily place the logo on the coverpage ... but using that same url with 'logo:' doesn't work either.
Steps to reproduce
Erhm, well change the path ...
What is current behaviour
Noting happens.
What is the expected behaviour
I should see a logo in the sidebar (I guess), as the docs describe.
Other relevant information
Bug does still occur when all/other plugins are disabled?
Your OS:
Node.js version:
npm/yarn version:
Browser version:
Docsify version:
Docsify plugins:
Please create a reproducible sandbox
Mention the docsify version in which this bug was not present (if any)
The text was updated successfully, but these errors were encountered: