Merge pull request #410 from dojoengine/fix/state-recs-convertValues

fix: state recs convertValues do not add undefined when value is not …

Author: MartianGreed

.changeset/rude-doors-beg.md

@@ -0,0 +1,16 @@
+---
+"@dojoengine/state": patch
+"template-vite-ts": patch
+"@dojoengine/core": patch
+"@dojoengine/create-burner": patch
+"@dojoengine/create-dojo": patch
+"@dojoengine/predeployed-connector": patch
+"@dojoengine/react": patch
+"@dojoengine/sdk": patch
+"@dojoengine/torii-client": patch
+"@dojoengine/torii-wasm": patch
+"@dojoengine/utils": patch
+"@dojoengine/utils-wasm": patch
+---
+
+fix: recs convertValues do not set to null

examples/example-vite-react-phaser-recs/src/dojo/generated/contractComponents.ts

@@ -54,7 +54,8 @@ export function defineContractComponents(world: World) {
                 },
                 {
                     metadata: {
-                        name: "dojo_starter-Position",
+                        namespace: "dojo_starter",
+                        name: "Position",
                         types: ["contractaddress", "u32", "u32"],
                         customTypes: ["Vec2"],
                     },

packages/state/src/__tests__/utils.test.ts

@@ -348,4 +348,17 @@ describe("convertValues", () => {
         const expected = {};
         expect(convertValues(schema, values)).toEqual(expected);
     });
+    it("should not set value to undefined", () => {
+        const schema: Schema = {
+            name: RecsType.String,
+            age: RecsType.Number,
+        };
+        const values = {
+            name: { value: "Alice", type: "string" },
+        };
+        const expected = {
+            name: "Alice",
+        };
+        expect(convertValues(schema, values)).toStrictEqual(expected);
+    });
 });

packages/state/src/utils/index.ts

@@ -5,6 +5,12 @@ export function convertValues(schema: Schema, values: any) {
         let schemaType = schema[key];
         let value = values[key];
 
+        // If key in values is not present, no need to set it to null
+        // so we return the accumulator as is
+        if (undefined === value) {
+            return acc;
+        }
+
         if (value == null) {
             acc[key] = value;
             return acc;