fix(sdk): ensure entityIds are properly padded

Author: MartianGreed

.changeset/tiny-suns-read.md

@@ -0,0 +1,16 @@
+---
+"@dojoengine/predeployed-connector": minor
+"@dojoengine/create-burner": minor
+"@dojoengine/torii-client": minor
+"@dojoengine/create-dojo": minor
+"@dojoengine/torii-wasm": minor
+"@dojoengine/utils-wasm": minor
+"@dojoengine/react": minor
+"@dojoengine/state": minor
+"@dojoengine/utils": minor
+"@dojoengine/core": minor
+"@dojoengine/grpc": minor
+"@dojoengine/sdk": minor
+---
+
+fix(sdk): ensure entityIds are properly padded

packages/sdk/src/__tests__/parseEntities.test.ts

@@ -148,7 +148,7 @@ describe("parseEntities", () => {
         expect(result).toEqual([
             {
                 entityId:
-                    "0x14c362c17947ef1d40152d6e3bedd859c98bebfad41f75ef3f26798556a4c85",
+                    "0x014c362c17947ef1d40152d6e3bedd859c98bebfad41f75ef3f26798556a4c85",
                 models: {
                     dojo_starter: {
                         Position: {
@@ -169,7 +169,7 @@ describe("parseEntities", () => {
             },
             {
                 entityId:
-                    "0x144c128b8ead7d0da39c6a150abbfdd38f572ba9418d3e36929eb6107b4ce4d",
+                    "0x0144c128b8ead7d0da39c6a150abbfdd38f572ba9418d3e36929eb6107b4ce4d",
                 models: {
                     dojo_starter: {
                         Moves: {
@@ -409,6 +409,72 @@ describe("parseEntities", () => {
         ).toBe("number");
     });
 
+    it("should properly pad entity IDs to consistent length", () => {
+        const toriiResult: torii.Entity[] = [
+            {
+                // Unpadded entity ID (shorter)
+                hashed_keys: "0x1",
+                models: {
+                    "test-Model": {
+                        id: {
+                            type: "primitive",
+                            type_name: "u32",
+                            value: 1,
+                            key: true,
+                        },
+                    },
+                },
+            },
+            {
+                // Already padded entity ID
+                hashed_keys:
+                    "0x0000000000000000000000000000000000000000000000000000000000000002",
+                models: {
+                    "test-Model": {
+                        id: {
+                            type: "primitive",
+                            type_name: "u32",
+                            value: 2,
+                            key: true,
+                        },
+                    },
+                },
+            },
+            {
+                // Partially padded entity ID
+                hashed_keys: "0x00000003",
+                models: {
+                    "test-Model": {
+                        id: {
+                            type: "primitive",
+                            type_name: "u32",
+                            value: 3,
+                            key: true,
+                        },
+                    },
+                },
+            },
+        ];
+
+        const res = parseEntities(toriiResult);
+
+        // All entity IDs should be padded to 66 characters (0x + 64 hex chars)
+        expect(res[0]?.entityId).toBe(
+            "0x0000000000000000000000000000000000000000000000000000000000000001"
+        );
+        expect(res[1]?.entityId).toBe(
+            "0x0000000000000000000000000000000000000000000000000000000000000002"
+        );
+        expect(res[2]?.entityId).toBe(
+            "0x0000000000000000000000000000000000000000000000000000000000000003"
+        );
+
+        // Verify all have the same length
+        expect(res[0]?.entityId?.length).toBe(66);
+        expect(res[1]?.entityId?.length).toBe(66);
+        expect(res[2]?.entityId?.length).toBe(66);
+    });
+
     it("should parse all primitive types correctly according to Rust serialization", () => {
         const toriiResult: torii.Entity[] = [
             {

packages/sdk/src/internal/parseEntities.ts

@@ -1,5 +1,10 @@
 import type * as torii from "@dojoengine/torii-wasm/types";
-import { CairoCustomEnum, CairoOption, CairoOptionVariant } from "starknet";
+import {
+    CairoCustomEnum,
+    CairoOption,
+    CairoOptionVariant,
+    addAddressPadding,
+} from "starknet";
 import type {
     ParsedEntity,
     SchemaType,
@@ -14,7 +19,7 @@ export function parseEntities<T extends SchemaType>(
     const result: ParsedEntity<T>[] = [];
 
     for (const entity of entities) {
-        const entityId = entity.hashed_keys;
+        const entityId = addAddressPadding(entity.hashed_keys);
         const entityData = entity.models;
         const parsedEntity: ParsedEntity<T> = {
             entityId,