From c9d3736ce66b9dd228554a03e372ebe928abc583 Mon Sep 17 00:00:00 2001 From: Tony Stark Date: Sun, 3 Nov 2024 01:37:55 -0600 Subject: [PATCH 1/3] feat: fix for cli --- packages/create-dojo/tsconfig.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/create-dojo/tsconfig.json b/packages/create-dojo/tsconfig.json index d1582fd5..623a2744 100644 --- a/packages/create-dojo/tsconfig.json +++ b/packages/create-dojo/tsconfig.json @@ -5,8 +5,8 @@ "target": "esnext", "moduleResolution": "node", "moduleDetection": "force", - "allowImportingTsExtensions": true, - "noEmit": true, + "outDir": "./dist", + "noEmit": false, "strict": true, "downlevelIteration": true, From a3f45f9d83a54dfe11d3b8799edd8d85160c805a Mon Sep 17 00:00:00 2001 From: Tony Stark Date: Sun, 3 Nov 2024 23:08:17 -0600 Subject: [PATCH 2/3] feat: cli fix --- packages/create-dojo/src/index.ts | 2 +- packages/create-dojo/src/utils/get-package-info.ts | 9 +++++++-- packages/create-dojo/tsconfig.json | 4 ++-- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/create-dojo/src/index.ts b/packages/create-dojo/src/index.ts index 1efd74fc..b38c6527 100644 --- a/packages/create-dojo/src/index.ts +++ b/packages/create-dojo/src/index.ts @@ -9,7 +9,7 @@ process.on("SIGINT", () => process.exit(0)); process.on("SIGTERM", () => process.exit(0)); async function main() { - const packageInfo = await getPackageInfo(); + const packageInfo = getPackageInfo(); const program = new Command() .name("@dojoengine") diff --git a/packages/create-dojo/src/utils/get-package-info.ts b/packages/create-dojo/src/utils/get-package-info.ts index 63bbb75a..fb1889e6 100644 --- a/packages/create-dojo/src/utils/get-package-info.ts +++ b/packages/create-dojo/src/utils/get-package-info.ts @@ -4,6 +4,11 @@ import { type PackageJson } from "type-fest"; export function getPackageInfo() { const packageJsonPath = path.join("package.json"); - - return fs.readJSONSync(packageJsonPath) as PackageJson; + try { + return fs.readJSONSync(packageJsonPath) as PackageJson; + } catch (error) { + return { + version: "1.0.0", + } as PackageJson; + } } diff --git a/packages/create-dojo/tsconfig.json b/packages/create-dojo/tsconfig.json index 623a2744..d1582fd5 100644 --- a/packages/create-dojo/tsconfig.json +++ b/packages/create-dojo/tsconfig.json @@ -5,8 +5,8 @@ "target": "esnext", "moduleResolution": "node", "moduleDetection": "force", - "outDir": "./dist", - "noEmit": false, + "allowImportingTsExtensions": true, + "noEmit": true, "strict": true, "downlevelIteration": true, From d66dce485a3962710995d2dd35876d1ab07c9327 Mon Sep 17 00:00:00 2001 From: Tony Stark Date: Sun, 3 Nov 2024 23:19:29 -0600 Subject: [PATCH 3/3] fix: coderabbitai suggestion --- packages/create-dojo/src/utils/get-package-info.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/create-dojo/src/utils/get-package-info.ts b/packages/create-dojo/src/utils/get-package-info.ts index fb1889e6..59c1b938 100644 --- a/packages/create-dojo/src/utils/get-package-info.ts +++ b/packages/create-dojo/src/utils/get-package-info.ts @@ -3,10 +3,14 @@ import fs from "fs-extra"; import { type PackageJson } from "type-fest"; export function getPackageInfo() { - const packageJsonPath = path.join("package.json"); + const packageJsonPath = path.join(process.cwd(), "package.json"); try { return fs.readJSONSync(packageJsonPath) as PackageJson; } catch (error) { + const errorMessage = + error instanceof Error ? error.message : "Unknown error"; + console.warn(`Failed to read package.json: ${errorMessage}`); + console.warn('Falling back to default version "1.0.0"'); return { version: "1.0.0", } as PackageJson;