-
Notifications
You must be signed in to change notification settings - Fork 25.2k
AllowSynchronousIO set to false causes compression exception in ASP.NET Core 2.2. #10983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @kieronlanning ... This is going to be fixed with the release of 3.0 (see this remark). The error message is clear, so I'm not too worried about noting it in the 2.2 version of the topic. |
Thanks @guardrex - is this not being backported to 2.x? I would have thought a note in the docs would be a good value add, setting |
I was told that the decision on that is made a little later in the release cycle. The announcement for the Ping them on the discussion issue for the announcement to ask about that: dotnet/aspnetcore#7644 ... and then come back and mention the answer over here.
We actively don't document every error condition. Management would like us to let the error message cover the scenario. Also note that this is the first time this has come up for this topic (AFAIK) since the topic was written. |
No it won't be backported. We needed new APIs like DisposeAsync to make it work right. |
@Rick-Anderson It could be seen to fall into the bucket of not documenting every error condition that an error message explains. This is the first time this has ever come up. Not sure it's worth the space/trouble, especially given that this goes away with 3.0. I suggest closing, but let me know otherwise if you would like something done. |
It's unexpected behavior I think is worth pointing out. @tdykstra and @scottaddie may differ. @danroth27 do we have a policy on this? |
@Rick-Anderson I'm not aware of any policy on this. The error message seems pretty clear and this is getting fixed in 3.0, so I don't see a lot of value in documenting this for 2.x. |
When
AllowSynchronousIO
is configured to false, essentially barring any blocking calls from the request pipeline, compression failed with the following exception:Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: