-
Notifications
You must be signed in to change notification settings - Fork 25.2k
AddMicrosoftAccount is deprecated. #20222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@geno-github see this GitHub comment
Sor for now, keep using |
Reviving this. While we don't intend to deprecate AddMicrosoftAccount or add AddMicrosoftAccountOidc in 6.0, we still want to transition the docs to show using AddOpenIdConnect (or Identity.Web) instead. @blowdart The same goes for AddGoogle. |
@jennyf19 for guidance on moving to Identity.Web. |
@jennyf19 if you can outline the steps we'll get this published. |
yes @Rick-Anderson will do. thanks. |
@Rick-Anderson @Tratcher Here is an md file above with suggestions. Just a note, that most customers use the 3rd or 4th option in the screen shot below from the portal. The difference in code (which i mention in a comment in the md file) is in appsettings.json, either using Login w/ This is the error, if I try to use an MSA only app with a non-MSA account because I don't have Login w/ |
Thanks @jennyf19. There are a few details to work out:
services.AddAuthentication()
.AddMicrosoftIdentityWebApp(microsoftOptions =>
{
microsoftOptions.Instance = "https://login.microsoftonline.com";
microsoftOptions.TenantId = "consumers";
microsoftOptions.ClientId = Configuration["Authentication:Microsoft:ClientId"];
}, cookieScheme = null); Is this using the id_token flow so the client secret isn't required anymore? |
@Tratcher will need to talk to @henrik-me and @jmprieur about prioritization w/our other items.
For the migration story, I would need time to look at the current one and ours to compare, and that will need to be prioritized, as mentioned above. |
@blowdart for the prioritization discussion. Since this is doc focused it's not on a strict release deadline, but we'd like to get it done in the .NET 6 time frame (Nov). |
AddMicrosoftAccountIsDeprecated.md @Tratcher @blowdart @Rick-Anderson I believe all the questions are answered above. LMK if there is more to do. thanks. |
Ok, I think this is the disconnect, most people using AddMicrosoftAccount aren't using the
I meant the display name field of the authentication scheme, not the user. See |
I hope the doc will show how to use .AddOpenIdConnect("Microsoft", "Microsoft", options => {
options.Authority = "https://login.microsoftonline.com/common/v2.0/";
options.ClientId = Configuration["Authentication:Microsoft:ClientId"];
options.ClientSecret = Configuration["Authentication:Microsoft:ClientSecret"];
options.ResponseType = OpenIdConnectResponseType.Code;
options.CallbackPath = "/signin-microsoft";
options.TokenValidationParameters.IssuerValidator = AadIssuerValidator.GetAadIssuerValidator("https://login.microsoftonline.com/").Validate;
}) |
Email sent to @jennyf19 |
@Tratcher any update on this topic? should we use AddMicrosoftIdentityWebApp instead of AddMicrosoftAccount also filed an discussion here dotnet/aspnetcore#49484 |
Please replace this method with supported method like AddOpenIdConnect. Thanks.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
The text was updated successfully, but these errors were encountered: