Fix | Fix TCP Keep Alive missing call (#854)

cheenamalhotra · web-flow · commit 83e2c645f079 · 2020-12-18T13:36:25.000-08:00
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs
@@ -364,6 +364,10 @@ void Cancel()
                         if (ipAddresses[i] != null)
                         {
                             sockets[i] = new Socket(ipAddresses[i].AddressFamily, SocketType.Stream, ProtocolType.Tcp);
+
+                            // enable keep-alive on socket
+                            SetKeepAliveValues(ref sockets[i]);
+
                             sockets[i].Connect(ipAddresses[i], port);
                             if (sockets[i] != null) // sockets[i] can be null if cancel callback is executed during connect()
                             {

Original file line number	Diff line number	Diff line change
`@@ -364,6 +364,10 @@ void Cancel()`
`364`	`364`	`if (ipAddresses[i] != null)`
`365`	`365`	`{`
`366`	`366`	`sockets[i] = new Socket(ipAddresses[i].AddressFamily, SocketType.Stream, ProtocolType.Tcp);`
	`367`	`+`
	`368`	`+ // enable keep-alive on socket`
	`369`	`+ SetKeepAliveValues(ref sockets[i]);`
	`370`	`+`
`367`	`371`	`sockets[i].Connect(ipAddresses[i], port);`
`368`	`372`	`if (sockets[i] != null) // sockets[i] can be null if cancel callback is executed during connect()`
`369`	`373`	`{`