Move to shared - SmiMetaDataProperty (#1320)

Author: Kaur-Parminder

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj

@@ -163,6 +163,9 @@
     <Compile Include="..\..\src\Microsoft\Data\SqlClient\Server\SqlDataRecord.netcore.cs">
       <Link>Microsoft\Data\SqlClient\Server\SqlDataRecord.netcore.cs</Link>
     </Compile>
+    <Compile Include="..\..\src\Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs">
+      <Link>Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs</Link>
+    </Compile>
     <Compile Include="..\..\src\Microsoft\Data\SqlClient\ColumnEncryptionKeyInfo.cs">
       <Link>Microsoft\Data\SqlClient\ColumnEncryptionKeyInfo.cs</Link>
     </Compile>
@@ -503,7 +506,6 @@
     </EmbeddedResource>
     <Compile Include="Microsoft\Data\SqlClient\AAsyncCallContext.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\MetadataUtilsSmi.cs" />
-    <Compile Include="Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiXetterAccessMap.cs" />
     <Compile Include="Microsoft\Data\SqlClient\SqlDbColumn.cs" />
     <Compile Include="Microsoft\Data\Common\DbConnectionOptions.cs" />

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlParameter.cs

@@ -1246,7 +1246,7 @@ private void GetActualFieldsAndProperties(out List<SmiExtendedMetaData> fields,
                                     hasDefault = true;
                                 }
 
-                                sort[i].Order = colMeta.SortOrder;
+                                sort[i]._order = colMeta.SortOrder;
                                 if (SortOrder.Unspecified != colMeta.SortOrder)
                                 {
                                     // SqlMetaData takes care of checking for negative sort ordinals with specified sort order
@@ -1263,7 +1263,7 @@ private void GetActualFieldsAndProperties(out List<SmiExtendedMetaData> fields,
                                         throw SQL.DuplicateSortOrdinal(colMeta.SortOrdinal);
                                     }
 
-                                    sort[i].SortOrdinal = colMeta.SortOrdinal;
+                                    sort[i]._sortOrdinal = colMeta.SortOrdinal;
                                     sortOrdinalSpecified[colMeta.SortOrdinal] = true;
                                     if (colMeta.SortOrdinal > maxSortOrdinal)
                                     {

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -10124,11 +10124,11 @@ private void WriteTvpOrderUnique(SmiExtendedMetaData metaData, TdsParserStateObj
                 // Add appropriate SortOrder flag
                 byte flags = 0;
                 SmiOrderProperty.SmiColumnOrder columnOrder = orderProperty[i];
-                if (SortOrder.Ascending == columnOrder.Order)
+                if (SortOrder.Ascending == columnOrder._order)
                 {
                     flags = TdsEnums.TVP_ORDERASC_FLAG;
                 }
-                else if (SortOrder.Descending == columnOrder.Order)
+                else if (SortOrder.Descending == columnOrder._order)
                 {
                     flags = TdsEnums.TVP_ORDERDESC_FLAG;
                 }

src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj

@@ -240,6 +240,9 @@
     <Compile Include="..\..\src\Microsoft\Data\SqlClient\Server\ValueUtilsSmi.netfx.cs">
       <Link>Microsoft\Data\SqlClient\Server\ValueUtilsSmi.netfx.cs</Link>
     </Compile>
+    <Compile Include="..\..\src\Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs">
+      <Link>Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs</Link>
+    </Compile>
     <Compile Include="..\..\src\Microsoft\Data\SqlClient\ColumnEncryptionKeyInfo.cs">
       <Link>Microsoft\Data\SqlClient\ColumnEncryptionKeyInfo.cs</Link>
     </Compile>
@@ -604,7 +607,6 @@
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiEventStream.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiExecuteType.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiLink.cs" />
-    <Compile Include="Microsoft\Data\SqlClient\Server\SmiMetaDataProperty.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiRequestExecutor.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiStream.cs" />
     <Compile Include="Microsoft\Data\SqlClient\Server\SmiXetterAccessMap.cs" />

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/Server/SmiMetaDataProperty.cs

@@ -1238,7 +1238,7 @@ private void GetActualFieldsAndProperties(out List<SmiExtendedMetaData> fields,
                                 MethodInfo getter = serverTypeNameProperty.GetGetMethod(nonPublic: true);
                                 SortOrder sortOrder = (SortOrder)getter.Invoke(colMeta, null);
 
-                                sort[i].Order = sortOrder;
+                                sort[i]._order = sortOrder;
                                 if (SortOrder.Unspecified != sortOrder)
                                 {
                                     // SqlMetaData takes care of checking for negative sort ordinals with specified sort order
@@ -1255,7 +1255,7 @@ private void GetActualFieldsAndProperties(out List<SmiExtendedMetaData> fields,
                                         throw SQL.DuplicateSortOrdinal(colMeta.SortOrdinal);
                                     }
 
-                                    sort[i].SortOrdinal = colMeta.SortOrdinal;
+                                    sort[i]._sortOrdinal = colMeta.SortOrdinal;
                                     sortOrdinalSpecified[colMeta.SortOrdinal] = true;
                                     if (colMeta.SortOrdinal > maxSortOrdinal)
                                     {