From 608b8c42bd5db1950780f8e11888995325e6423e Mon Sep 17 00:00:00 2001 From: "Javad Rahnama (SIMBA TECHNOLOGIES INC)" Date: Sun, 17 Mar 2024 23:42:00 -0700 Subject: [PATCH 1/6] Change | Converting netfx project to SDK style --- .../netfx/src/Microsoft.Data.SqlClient.csproj | 19 ++---------- tools/specs/Microsoft.Data.SqlClient.nuspec | 30 +++++++++---------- 2 files changed, 18 insertions(+), 31 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj index 0a0757731b..b5bec780ac 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj @@ -1,10 +1,8 @@ - - - + {407890AC-9876-4FEF-A6F1-F36A876BAADE} Microsoft.Data.SqlClient - v4.6.2 + net462 true Microsoft.Data.SqlClient AnyCPU @@ -17,6 +15,7 @@ True + false $(DefineConstants);NETFRAMEWORK; @@ -710,17 +709,6 @@ PreserveNewest - - - {5477469E-83B1-11D2-8B49-00A0C9B7C9C4} - 2 - 4 - 0 - tlbimp - False - True - - $(SystemTextEncodingsWebVersion) @@ -746,7 +734,6 @@ $(SystemBuffersVersion) - diff --git a/tools/specs/Microsoft.Data.SqlClient.nuspec b/tools/specs/Microsoft.Data.SqlClient.nuspec index 57fff91307..f44a2a462d 100644 --- a/tools/specs/Microsoft.Data.SqlClient.nuspec +++ b/tools/specs/Microsoft.Data.SqlClient.nuspec @@ -143,21 +143,21 @@ When using NuGet 3.x this package requires at least version 3.4. - - - - - - - - - - + + + + + + + + + + - - - + + + @@ -230,8 +230,8 @@ When using NuGet 3.x this package requires at least version 3.4. - - + + From 6e31c7e6c8085d58a962fdfd5a54149cce7729a7 Mon Sep 17 00:00:00 2001 From: "Javad Rahnama (SIMBA TECHNOLOGIES INC)" Date: Sun, 17 Mar 2024 23:52:58 -0700 Subject: [PATCH 2/6] revert changes related to COMReference --- .../netfx/src/Microsoft.Data.SqlClient.csproj | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj index b5bec780ac..1d5a85e655 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj @@ -709,6 +709,17 @@ PreserveNewest + + + {5477469E-83B1-11D2-8B49-00A0C9B7C9C4} + 2 + 4 + 0 + tlbimp + False + True + + $(SystemTextEncodingsWebVersion) From 9d8b6ac869e410a3c1c0e409752990d1104a4747 Mon Sep 17 00:00:00 2001 From: "Javad Rahnama (SIMBA TECHNOLOGIES INC)" Date: Mon, 18 Mar 2024 10:56:43 -0700 Subject: [PATCH 3/6] Adding TFM to NetFX csproj for TargetFrameworkMonikerAssemblyAttributesPath --- .../netfx/src/Microsoft.Data.SqlClient.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj index 1d5a85e655..2bcc979352 100644 --- a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj +++ b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj @@ -23,7 +23,7 @@ full - $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(GeneratedSourceFileName)')) + $([System.IO.Path]::Combine('$(IntermediateOutputPath)\$(TargetFramework)','$(GeneratedSourceFileName)')) From ce1f397a58e38ead11353a376017cd787bd3cab4 Mon Sep 17 00:00:00 2001 From: "Javad Rahnama (SIMBA TECHNOLOGIES INC)" Date: Mon, 18 Mar 2024 12:23:09 -0700 Subject: [PATCH 4/6] Addressing dll not found exception in ManualTests csproj --- .../Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj index b2c942dd95..19c8ffe807 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj @@ -347,7 +347,10 @@ - + + PreserveNewest + %(Filename)%(Extension) + From 061829b5068d24dc381ffc4f5d8bbca911fd8fb7 Mon Sep 17 00:00:00 2001 From: "Javad Rahnama (SIMBA TECHNOLOGIES INC)" Date: Mon, 18 Mar 2024 14:30:27 -0700 Subject: [PATCH 5/6] Addressing DllNotFoundException in functional tests --- .../FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj index 7724f4c58e..d0c55058e7 100644 --- a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj @@ -122,7 +122,12 @@ - + + PreserveNewest + %(Filename)%(Extension) + + + From e08c2db7979b53382ebd5161c8072f051f74fb87 Mon Sep 17 00:00:00 2001 From: "Javad Rahnama (SIMBA TECHNOLOGIES INC)" Date: Wed, 20 Mar 2024 14:13:26 -0700 Subject: [PATCH 6/6] Updating csproj files for Functional and Manual tests --- .../tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj | 2 +- .../Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj index d0c55058e7..4c011a2d55 100644 --- a/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/FunctionalTests/Microsoft.Data.SqlClient.Tests.csproj @@ -122,7 +122,7 @@ - + PreserveNewest %(Filename)%(Extension) diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj index 19c8ffe807..676f8126c6 100644 --- a/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj +++ b/src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTesting.Tests.csproj @@ -347,7 +347,7 @@ - + PreserveNewest %(Filename)%(Extension)