Skip to content

Commit b23c794

Browse files
committed
Respect ICciFilter when generating fields in value types
- #2031 aka #2033 aka #4488 problem (6) - remove `IsVisibleOutsideAssembly()` use; was at best redundant
1 parent 3d3bf89 commit b23c794

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Microsoft.Cci.Extensions/Writers/CSharp/CSharpWriter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,11 @@ public override void Visit(ITypeDefinition parentType, IEnumerable<IFieldDefinit
181181

182182
// Note: By "private", we mean not visible outside the assembly.
183183

184-
// For more details see issue https://github.com/dotnet/corefx/issues/6185
184+
// For more details see issue https://github.com/dotnet/corefx/issues/6185
185185
// this blog is helpful as well http://blog.paranoidcoding.com/2016/02/15/are-private-members-api-surface.html
186186

187187
List<IFieldDefinition> newFields = new List<IFieldDefinition>();
188-
var includedVisibleFields = fields.Where(f => f.IsVisibleOutsideAssembly()).Where(_cciFilter.Include);
188+
var includedVisibleFields = fields.Where(f => _cciFilter.Include(f));
189189
includedVisibleFields = includedVisibleFields.OrderBy(GetMemberKey, StringComparer.OrdinalIgnoreCase);
190190

191191
var excludedFields = fields.Except(includedVisibleFields).Where(f => !f.IsStatic);

0 commit comments

Comments
 (0)