Enable warnings for IDE0062 (#39463)

Contributes to #24055

Author: pranavkm

.editorconfig

@@ -233,6 +233,9 @@ dotnet_diagnostic.IDE0055.severity = warning
 # IDE0059: Unnecessary assignment to a value
 dotnet_diagnostic.IDE0059.severity = warning
 
+# IDE0062: Make local function static
+dotnet_diagnostic.IDE0062.severity = warning
+
 # IDE0073: File header
 dotnet_diagnostic.IDE0073.severity = warning
 file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license.
@@ -285,6 +288,8 @@ dotnet_diagnostic.IDE0044.severity = suggestion
 dotnet_diagnostic.IDE0051.severity = suggestion
 # IDE0059: Unnecessary assignment to a value
 dotnet_diagnostic.IDE0059.severity = suggestion
+# IDE0062: Make local function static
+dotnet_diagnostic.IDE0062.severity = suggestion
 
 # CA2016: Forward the 'CancellationToken' parameter to methods that take one
 dotnet_diagnostic.CA2016.severity = suggestion
@@ -298,6 +303,8 @@ dotnet_diagnostic.CA1822.severity = silent
 dotnet_diagnostic.IDE0011.severity = silent
 # IDE0055: Fix formatting
 dotnet_diagnostic.IDE0055.severity = silent
+# IDE0062: Make local function static
+dotnet_diagnostic.IDE0062.severity = silent
 # IDE0161: Convert to file-scoped namespace
 dotnet_diagnostic.IDE0161.severity = silent
 

src/Azure/AzureAD/Authentication.AzureADB2C.UI/src/AzureAdB2CAuthenticationBuilderExtensions.cs

@@ -207,7 +207,7 @@ private static void AddAdditionalMvcApplicationParts(IServiceCollection services
                 apm.FeatureProviders.Add(new AzureADB2CAccountControllerFeatureProvider());
             });
 
-        bool HasSameName(string left, string right) => string.Equals(left, right, StringComparison.Ordinal);
+        static bool HasSameName(string left, string right) => string.Equals(left, right, StringComparison.Ordinal);
     }
 
     private static IEnumerable<ApplicationPart> GetAdditionalParts()

src/Hosting/Hosting/src/WebHostBuilder.cs

@@ -198,12 +198,12 @@ public IWebHost Build()
             throw;
         }
 
-        IServiceProvider GetProviderFromFactory(IServiceCollection collection)
+        static IServiceProvider GetProviderFromFactory(IServiceCollection collection)
         {
             var provider = collection.BuildServiceProvider();
             var factory = provider.GetService<IServiceProviderFactory<IServiceCollection>>();
 
-            if (factory != null && !(factory is DefaultServiceProviderFactory))
+            if (factory != null && factory is not DefaultServiceProviderFactory)
             {
                 using (provider)
                 {

src/Http/Routing/src/CompositeEndpointDataSource.cs

@@ -205,7 +205,7 @@ private string DebuggerDisplayString
             }
             return sb.ToString();
 
-            IEnumerable<string> FormatValues(IEnumerable<KeyValuePair<string, object?>> values)
+            static IEnumerable<string> FormatValues(IEnumerable<KeyValuePair<string, object?>> values)
             {
                 return values.Select(
                     kvp =>

src/Http/Routing/src/EndpointNameAddressScheme.cs

@@ -89,7 +89,7 @@ private static Dictionary<string, Endpoint[]> Initialize(IReadOnlyList<Endpoint>
 
         throw new InvalidOperationException(builder.ToString());
 
-        string? GetEndpointName(Endpoint endpoint)
+        static string? GetEndpointName(Endpoint endpoint)
         {
             if (endpoint.Metadata.GetMetadata<ISuppressLinkGenerationMetadata>()?.SuppressLinkGeneration == true)
             {

src/Http/Routing/src/Matching/HttpMethodMatcherPolicy.cs

@@ -308,7 +308,7 @@ public IReadOnlyList<PolicyNodeEdge> GetEdges(IReadOnlyList<Endpoint> endpoints)
 
         return policyNodeEdges;
 
-        (IReadOnlyList<string> httpMethods, bool acceptCorsPreflight) GetHttpMethods(Endpoint e)
+        static (IReadOnlyList<string> httpMethods, bool acceptCorsPreflight) GetHttpMethods(Endpoint e)
         {
             var metadata = e.Metadata.GetMetadata<IHttpMethodMetadata>();
             return metadata == null ? (Array.Empty<string>(), false) : (metadata.HttpMethods, metadata.AcceptCorsPreflight);

src/Identity/ApiAuthorization.IdentityServer/src/Authentication/AuthenticationBuilderExtensions.cs

@@ -47,7 +47,7 @@ public static AuthenticationBuilder AddIdentityServerJwt(this AuthenticationBuil
 
         return builder;
 
-        IdentityServerJwtBearerOptionsConfiguration JwtBearerOptionsFactory(IServiceProvider sp)
+        static IdentityServerJwtBearerOptionsConfiguration JwtBearerOptionsFactory(IServiceProvider sp)
         {
             var schemeName = IdentityServerJwtConstants.IdentityServerJwtBearerScheme;
 
@@ -58,5 +58,4 @@ IdentityServerJwtBearerOptionsConfiguration JwtBearerOptionsFactory(IServiceProv
             return new IdentityServerJwtBearerOptionsConfiguration(schemeName, apiName, localApiDescriptor);
         }
     }
-
 }

src/Middleware/Rewrite/src/ApacheModRewrite/FileParser.cs

@@ -13,11 +13,7 @@ public static IList<IRule> Parse(TextReader input)
         var lineNum = 0;
 
         // parsers
-        var testStringParser = new TestStringParser();
-        var conditionParser = new ConditionPatternParser();
-        var regexParser = new RuleRegexParser();
         var flagsParser = new FlagParser();
-        var tokenizer = new Tokenizer();
 
         while ((line = input.ReadLine()) != null)
         {

src/Middleware/Spa/SpaProxy/src/SpaProxyMiddleware.cs

@@ -68,7 +68,7 @@ private async Task InvokeCore(HttpContext context)
             context.Response.Redirect(_options.Value.ServerUrl);
         }
 
-        string GenerateSpaLaunchPage(SpaDevelopmentServerOptions options)
+        static string GenerateSpaLaunchPage(SpaDevelopmentServerOptions options)
         {
             return $@"
 <!DOCTYPE html>

src/Mvc/Mvc.Core/src/ApplicationModels/ApiBehaviorApplicationModelProvider.cs

@@ -97,7 +97,7 @@ private static void EnsureActionIsAttributeRouted(ActionModel actionModel)
             throw new InvalidOperationException(message);
         }
 
-        bool IsAttributeRouted(IList<SelectorModel> selectorModel)
+        static bool IsAttributeRouted(IList<SelectorModel> selectorModel)
         {
             for (var i = 0; i < selectorModel.Count; i++)
             {