Skip to content

Commit 189054f

Browse files
pranavkmTratcher
andcommitted
Apply suggestions from code review
Co-authored-by: Chris Ross <[email protected]>
1 parent 7d9d324 commit 189054f

File tree

6 files changed

+8
-12
lines changed

6 files changed

+8
-12
lines changed

src/Http/Authentication.Core/src/Microsoft.AspNetCore.Authentication.Core.csproj

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,11 @@
44
<Description>ASP.NET Core common types used by the various authentication middleware components.</Description>
55
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
66
<IsAspNetCoreApp>true</IsAspNetCoreApp>
7-
<NoWarn>$(NoWarn);CS1591</NoWarn>
7+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
88
<GenerateDocumentationFile>true</GenerateDocumentationFile>
99
<PackageTags>aspnetcore;authentication;security</PackageTags>
1010
<IsPackable>false</IsPackable>
1111
<Nullable>enable</Nullable>
12-
13-
<NoWarn />
1412
</PropertyGroup>
1513

1614
<ItemGroup>

src/Http/Http.Abstractions/src/ConnectionInfo.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ public abstract class ConnectionInfo
3939
public abstract int LocalPort { get; set; }
4040

4141
/// <summary>
42-
/// Gets or sets client certificates associated with the connection.
42+
/// Gets or sets the client certificate associated with the connection.
4343
/// </summary>
4444
public abstract X509Certificate2? ClientCertificate { get; set; }
4545

4646
/// <summary>
47-
/// Asynchronously retries the client certificate.
47+
/// Asynchronously retrieves the client certificate.
4848
/// </summary>
4949
/// <param name="cancellationToken">The cancellation token to cancel operation.</param>
50-
/// <returns>The task object representing the asynchronous operation.</returns>
50+
/// <returns>The client certificate if available.</returns>
5151
public abstract Task<X509Certificate2?> GetClientCertificateAsync(CancellationToken cancellationToken = new CancellationToken());
5252
}
5353
}

src/Http/Http.Abstractions/src/Extensions/ResponseTrailerExtensions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
namespace Microsoft.AspNetCore.Http
1010
{
1111
/// <summary>
12-
/// Extension methods for <see cref="HttpResponse"/> to work with the 'Trailer' response header.
12+
/// Extension methods for <see cref="HttpResponse"/> to work with response trailer headers.
1313
/// </summary>
1414
public static class ResponseTrailerExtensions
1515
{

src/Http/Http.Abstractions/src/Microsoft.AspNetCore.Http.Abstractions.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ Microsoft.AspNetCore.Http.HttpResponse</Description>
1414
<PackageTags>aspnetcore</PackageTags>
1515
<IsPackable>false</IsPackable>
1616
<Nullable>enable</Nullable>
17-
18-
<NoWarn />
17+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
1918
</PropertyGroup>
2019

2120
<ItemGroup>

src/Http/Http.Abstractions/src/PathString.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,7 @@ public static implicit operator PathString(string? s)
461461
=> ConvertFromString(s);
462462

463463
/// <summary>
464-
/// Implicitly creates a string frm the given <see cref="PathString"/>.
464+
/// Implicitly creates an escaped string from the given <see cref="PathString"/>.
465465
/// </summary>
466466
/// <param name="path">A path to implicitly convert.</param>
467467
public static implicit operator string(PathString path)

src/Http/Metadata/src/Microsoft.AspNetCore.Metadata.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@
44
<Description>ASP.NET Core metadata.</Description>
55
<TargetFrameworks>$(DefaultNetFxTargetFramework);netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks>
66
<IsAspNetCoreApp>true</IsAspNetCoreApp>
7-
<NoWarn>$(NoWarn);CS1591</NoWarn>
7+
<NoWarn>$(NoWarn.Replace('1591', ''))</NoWarn>
88
<GenerateDocumentationFile>true</GenerateDocumentationFile>
99
<PackageTags>aspnetcore</PackageTags>
1010
<Nullable>enable</Nullable>
11-
<NoWarn />
1211
</PropertyGroup>
1312

1413
</Project>

0 commit comments

Comments
 (0)