Removing noReload argument from WebDriverExtensions.Nagivate (#55143)

Author: MattyLeslie

src/Components/test/E2ETest/Infrastructure/ServerTestBase.cs

@@ -26,9 +26,9 @@ public ServerTestBase(
         _serverFixture = serverFixture;
     }
 
-    public void Navigate(string relativeUrl, bool noReload = false)
+    public void Navigate(string relativeUrl)
     {
-        Browser.Navigate(_serverFixture.RootUri, relativeUrl, noReload);
+        Browser.Navigate(_serverFixture.RootUri, relativeUrl);
     }
 
     protected override void InitializeAsyncCore()

src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/BasicTestAppAuthenticationWebDriverExtensions.cs

@@ -22,14 +22,14 @@ public static void SignInAs(this IWebDriver browser, Uri baseUri, string usernam
             // original page, but this adds several seconds of delay
             var originalWindow = browser.CurrentWindowHandle;
             browser.SwitchTo().NewWindow(WindowType.Tab);
-            browser.Navigate(baseUri, baseRelativeUri, noReload: false);
+            browser.Navigate(baseUri, baseRelativeUri);
             browser.Exists(By.CssSelector("h1#authentication"));
             browser.Close();
             browser.SwitchTo().Window(originalWindow);
         }
         else
         {
-            browser.Navigate(baseUri, baseRelativeUri, noReload: false);
+            browser.Navigate(baseUri, baseRelativeUri);
             browser.Exists(By.CssSelector("h1#authentication"));
         }
     }

src/Components/test/E2ETest/Infrastructure/WebDriverExtensions/WebDriverExtensions.cs

@@ -7,7 +7,7 @@ namespace Microsoft.AspNetCore.Components.E2ETest;
 
 internal static class WebDriverExtensions
 {
-    public static void Navigate(this IWebDriver browser, Uri baseUri, string relativeUrl, bool noReload)
+    public static void Navigate(this IWebDriver browser, Uri baseUri, string relativeUrl)
     {
         var absoluteUrl = new Uri(baseUri, relativeUrl);
 

src/Components/test/E2ETest/ServerExecutionTests/CircuitContextTest.cs

@@ -24,7 +24,7 @@ public CircuitContextTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<CircuitContextComponent>();
         Browser.Equal("Circuit Context", () => Browser.Exists(By.TagName("h1")).Text);
     }

src/Components/test/E2ETest/ServerExecutionTests/CircuitGracefulTerminationTests.cs

@@ -38,7 +38,7 @@ public override async Task InitializeAsync()
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<GracefulTermination>();
         Browser.Equal("Graceful Termination", () => Browser.Exists(By.TagName("h1")).Text);
 

src/Components/test/E2ETest/ServerExecutionTests/HotReloadTest.cs

@@ -29,7 +29,7 @@ public override async Task InitializeAsync()
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<RenderOnHotReload>();
     }
 

src/Components/test/E2ETest/ServerExecutionTests/ServerInteropTestDefaultExceptionsBehavior.cs

@@ -24,7 +24,7 @@ public ServerInteropTestDefaultExceptionsBehavior(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: true);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<InteropComponent>();
     }
 

src/Components/test/E2ETest/ServerExecutionTests/ServerInteropTestJsInvocationsTimeoutsBehavior.cs

@@ -23,7 +23,7 @@ public ServerInteropTestJsInvocationsTimeoutsBehavior(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: true);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<LongRunningInterop>();
     }
 

src/Components/test/E2ETest/ServerExecutionTests/ServerReconnectionTest.cs

@@ -23,7 +23,7 @@ public ServerReconnectionTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<ReconnectionComponent>();
         Browser.Exists(By.Id("count"));
     }

src/Components/test/E2ETest/Tests/BinaryHttpClientTest.cs

@@ -35,7 +35,7 @@ public BinaryHttpClientTest(
 
     protected override void InitializeAsyncCore()
     {
-        Browser.Navigate(_devHostServerFixture.RootUri, "/subdir", noReload: true);
+        Browser.Navigate(_devHostServerFixture.RootUri, "/subdir");
         _appElement = Browser.MountTestComponent<BinaryHttpRequestsComponent>();
     }
 

src/Components/test/E2ETest/Tests/BindTest.cs

@@ -26,7 +26,7 @@ public BindTest(
     protected override void InitializeAsyncCore()
     {
         // On WebAssembly, page reloads are expensive so skip if possible
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<BindCasesComponent>();
         Browser.Exists(By.Id("bind-cases"));
     }

src/Components/test/E2ETest/Tests/CascadingValueTest.cs

@@ -22,7 +22,7 @@ public CascadingValueTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<BasicTestApp.CascadingValueTest.CascadingValueSupplier>();
     }
 

src/Components/test/E2ETest/Tests/CircuitTests.cs

@@ -24,7 +24,7 @@ public CircuitTests(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
     }
 
     [Theory]

src/Components/test/E2ETest/Tests/ComponentRenderingTestBase.cs

@@ -27,7 +27,7 @@ public ComponentRenderingTestBase(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
     }
 
     [Fact]

src/Components/test/E2ETest/Tests/CustomElementsTest.cs

@@ -32,7 +32,7 @@ public CustomElementsTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         app = Browser.MountTestComponent<CustomElementsComponent>();
     }
 

src/Components/test/E2ETest/Tests/DynamicComponentRenderingTest.cs

@@ -27,7 +27,7 @@ public DynamicComponentRenderingTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         app = Browser.MountTestComponent<DynamicComponentRendering>();
         testCasePicker = new SelectElement(app.FindElement(By.Id("dynamic-component-case-picker")));
     }

src/Components/test/E2ETest/Tests/ErrorBoundaryTest.cs

@@ -21,7 +21,7 @@ public ErrorBoundaryTest(BrowserFixture browserFixture, ToggleExecutionModeServe
     protected override void InitializeAsyncCore()
     {
         // Many of these tests trigger fatal exceptions, so we always have to reload
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<ErrorBoundaryContainer>();
     }
 

src/Components/test/E2ETest/Tests/ErrorNotificationTest.cs

@@ -25,7 +25,7 @@ public ErrorNotificationTest(
     protected override void InitializeAsyncCore()
     {
         // On WebAssembly, page reloads are expensive so skip if possible
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<ErrorComponent>();
         Browser.Exists(By.Id("blazor-error-ui"));
         Browser.Exists(By.Id("throw-simple-exception"));

src/Components/test/E2ETest/Tests/EventBubblingTest.cs

@@ -28,7 +28,7 @@ public EventBubblingTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<EventBubblingComponent>();
         Browser.Exists(By.Id("event-bubbling"));
     }

src/Components/test/E2ETest/Tests/EventCallbackTest.cs

@@ -23,7 +23,7 @@ public EventCallbackTest(
     protected override void InitializeAsyncCore()
     {
         // On WebAssembly, page reloads are expensive so skip if possible
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<BasicTestApp.EventCallbackTest.EventCallbackCases>();
     }
 

src/Components/test/E2ETest/Tests/EventCustomArgsTest.cs

@@ -24,7 +24,7 @@ public EventCustomArgsTest(
     protected override void InitializeAsyncCore()
     {
         // Always do a full page reload because these tests need to start with no custom event registrations
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<EventCustomArgsComponent>();
     }
 

src/Components/test/E2ETest/Tests/EventTest.cs

@@ -26,7 +26,7 @@ public EventTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: true);
+        Navigate(ServerPathBase);
     }
 
     [Fact]

src/Components/test/E2ETest/Tests/FormsInputDateTest.cs

@@ -30,7 +30,7 @@ public FormsInputDateTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
     }
 
     [Fact]

src/Components/test/E2ETest/Tests/FormsTest.cs

@@ -25,7 +25,7 @@ public FormsTest(
     protected override void InitializeAsyncCore()
     {
         // On WebAssembly, page reloads are expensive so skip if possible
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
     }
 
     protected virtual IWebElement MountSimpleValidationComponent()

src/Components/test/E2ETest/Tests/HeadModificationTest.cs

@@ -22,7 +22,7 @@ public HeadModificationTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
     }
 
     [Fact]

src/Components/test/E2ETest/Tests/HostedInAlternativeBasePathTest.cs

@@ -24,7 +24,7 @@ public HostedInAlternativeBasePathTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate("/app/", noReload: true);
+        Navigate("/app/");
         WaitUntilLoaded();
     }
 

src/Components/test/E2ETest/Tests/HostedInAspNetTest.cs

@@ -23,7 +23,7 @@ public HostedInAspNetTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate("/", noReload: true);
+        Navigate("/");
         WaitUntilLoaded();
     }
 

src/Components/test/E2ETest/Tests/HttpClientTest.cs

@@ -37,7 +37,7 @@ protected override void InitializeAsyncCore()
     {
         base.InitializeAsyncCore();
 
-        Browser.Navigate(_serverFixture.RootUri, "/subdir", noReload: true);
+        Browser.Navigate(_serverFixture.RootUri, "/subdir");
         _appElement = Browser.MountTestComponent<HttpRequestsComponent>();
     }
 

src/Components/test/E2ETest/Tests/InputActionsTest.cs

@@ -24,7 +24,7 @@ public InputFocusTest(
     protected override void InitializeAsyncCore()
     {
         // On WebAssembly, page reloads are expensive so skip if possible
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
     }
 
     protected virtual IWebElement MountInputActionsComponent()

src/Components/test/E2ETest/Tests/InputFileTest.cs

@@ -31,7 +31,7 @@ protected override void InitializeAsyncCore()
         _tempDirectory = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString("N"));
         Directory.CreateDirectory(_tempDirectory);
 
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<InputFileComponent>();
     }
 

src/Components/test/E2ETest/Tests/InteropTest.cs

@@ -23,7 +23,7 @@ public InteropTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: true);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<InteropComponent>();
     }
 

src/Components/test/E2ETest/Tests/JSRootComponentsTest.cs

@@ -25,7 +25,7 @@ public JSRootComponentsTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         app = Browser.MountTestComponent<JavaScriptRootComponents>();
     }
 

src/Components/test/E2ETest/Tests/JsonSerializationTest.cs

@@ -22,7 +22,7 @@ public JsonSerializationTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<JsonSerializationCases>();
         Browser.Exists(By.Id("json-serialization-cases"));
     }

src/Components/test/E2ETest/Tests/KeyTest.cs

@@ -25,7 +25,7 @@ public KeyTest(
     protected override void InitializeAsyncCore()
     {
         // On WebAssembly, page reloads are expensive so skip if possible
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
     }
 
     [Fact]

src/Components/test/E2ETest/Tests/MultipleHostedAppTest.cs

@@ -24,7 +24,7 @@ public MultipleHostedAppTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate("/", noReload: true);
+        Navigate("/");
         WaitUntilLoaded();
     }
 

src/Components/test/E2ETest/Tests/PerformanceTest.cs

@@ -22,7 +22,7 @@ public PerformanceTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate("/", noReload: true);
+        Navigate("/");
     }
 
     public override Task InitializeAsync() => base.InitializeAsync(Guid.NewGuid().ToString());

src/Components/test/E2ETest/Tests/PropertyInjectionTest.cs

@@ -24,7 +24,7 @@ public PropertyInjectionTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: false);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<PropertyInjectionComponent>();
     }
 

src/Components/test/E2ETest/Tests/ProtectedBrowserStorageInjectionTest.cs

@@ -23,7 +23,7 @@ public ProtectedBrowserStorageInjectionTest(
 
     protected override void InitializeAsyncCore()
     {
-        Navigate(ServerPathBase, noReload: _serverFixture.ExecutionMode == ExecutionMode.Client);
+        Navigate(ServerPathBase);
         Browser.MountTestComponent<ProtectedBrowserStorageInjectionComponent>();
     }