Fix Mvc Functional test with runtime compilation

Author: John Luo

src/Mvc/test/Mvc.FunctionalTests/ErrorPageTests.cs

@@ -2,13 +2,16 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
+using System.IO;
 using System.Linq;
 using System.Net;
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Text.Encodings.Web;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
+using Microsoft.AspNetCore.TestHost;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Testing;
@@ -27,6 +30,8 @@ public class ErrorPageTests : IClassFixture<MvcTestFixture<ErrorPageMiddlewareWe
             "If you're seeing this in a published application, set 'CopyRefAssembliesToPublishDirectory' to true in your project file to ensure files in the refs directory are published.");
         private readonly AssemblyTestLog _assemblyTestLog;
 
+        private readonly MvcTestFixture<ErrorPageMiddlewareWebSite.Startup> _fixture;
+
         public ErrorPageTests(
             MvcTestFixture<ErrorPageMiddlewareWebSite.Startup> fixture,
             ITestOutputHelper testOutputHelper)
@@ -41,6 +46,8 @@ public ErrorPageTests(
                 .CreateDefaultClient();
             // These tests want to verify runtime compilation and formatting in the HTML of the error page
             Client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("text/html"));
+
+            _fixture = fixture;
         }
 
         public HttpClient Client { get; }
@@ -49,12 +56,18 @@ public ErrorPageTests(
         public async Task CompilationFailuresAreListedByErrorPageMiddleware()
         {
             // Arrange
+            var factory = _fixture.Factories.FirstOrDefault() ?? _fixture.WithWebHostBuilder(b => b.UseStartup<ErrorPageMiddlewareWebSite.Startup>());
+            factory = factory.WithWebHostBuilder(b => b.ConfigureTestServices(serviceCollection => serviceCollection.Configure<MvcRazorRuntimeCompilationOptions>(ConfigureRuntimeCompilationOptions)));
+
+            var client = factory.CreateDefaultClient();
+            client.DefaultRequestHeaders.Accept.Add(new MediaTypeWithQualityHeaderValue("text/html"));
+
             var action = "CompilationFailure";
             var expected = "Cannot implicitly convert type &#x27;int&#x27; to &#x27;string&#x27;";
             var expectedMediaType = MediaTypeHeaderValue.Parse("text/html; charset=utf-8");
 
             // Act
-            var response = await Client.GetAsync("http://localhost/" + action);
+            var response = await client.GetAsync("http://localhost/" + action);
 
             // Assert
             Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
@@ -63,6 +76,16 @@ public async Task CompilationFailuresAreListedByErrorPageMiddleware()
             Assert.Contains($"{action}.cshtml", content);
             Assert.Contains(expected, content);
             Assert.DoesNotContain(PreserveCompilationContextMessage, content);
+
+            static void ConfigureRuntimeCompilationOptions(MvcRazorRuntimeCompilationOptions options)
+            {
+                // Workaround for incorrectly generated deps file. The build output has all of the binaries required to compile. We'll grab these and
+                // add it to the list of assemblies runtime compilation uses.
+                foreach (var path in Directory.EnumerateFiles(AppContext.BaseDirectory, "*.dll"))
+                {
+                    options.AdditionalReferencePaths.Add(path);
+                }
+            }
         }
 
         [Fact]

src/Mvc/test/Mvc.FunctionalTests/RazorBuildTest.cs

@@ -3,9 +3,15 @@
 
 using System;
 using System.Collections.Generic;
+using System.IO;
+using System.Linq;
 using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Hosting;
+using Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation;
+using Microsoft.AspNetCore.TestHost;
+using Microsoft.Extensions.DependencyInjection;
 using Xunit;
 
 namespace Microsoft.AspNetCore.Mvc.FunctionalTests
@@ -14,7 +20,20 @@ public class RazorBuildTest : IClassFixture<MvcTestFixture<RazorBuildWebSite.Sta
     {
         public RazorBuildTest(MvcTestFixture<RazorBuildWebSite.Startup> fixture)
         {
-            Client = fixture.CreateDefaultClient();
+            var factory = fixture.Factories.FirstOrDefault() ?? fixture.WithWebHostBuilder(b => b.UseStartup<RazorBuildWebSite.Startup>());
+            factory = factory.WithWebHostBuilder(b => b.ConfigureTestServices(serviceCollection => serviceCollection.Configure<MvcRazorRuntimeCompilationOptions>(ConfigureRuntimeCompilationOptions)));
+
+            Client = factory.CreateDefaultClient();
+
+            static void ConfigureRuntimeCompilationOptions(MvcRazorRuntimeCompilationOptions options)
+            {
+                // Workaround for incorrectly generated deps file. The build output has all of the binaries required to compile. We'll grab these and
+                // add it to the list of assemblies runtime compilation uses.
+                foreach (var path in Directory.EnumerateFiles(AppContext.BaseDirectory, "*.dll"))
+                {
+                    options.AdditionalReferencePaths.Add(path);
+                }
+            }
         }
 
         public HttpClient Client { get; }
@@ -77,7 +96,7 @@ public async Task RazorViews_AreUpdatedOnChange()
             var actual2 = body.Trim();
             Assert.NotEqual(expected1, actual2);
 
-            // Act - 3 
+            // Act - 3
             // With all things being the same, expect a cached compilation
             body = await Client.GetStringAsync("/UpdateableViews");