Skip to content

Commit 3afbcde

Browse files
authored
Address initial feedback from API review
1 parent 83d405d commit 3afbcde

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

src/Http/Http.Extensions/src/HttpJsonServiceExtensions.cs

+7-5
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,29 @@
22
// The .NET Foundation licenses this file to you under the MIT license.
33

44
using Microsoft.AspNetCore.Http.Json;
5-
using Microsoft.Extensions.DependencyInjection;
65

7-
namespace Microsoft.AspNetCore.Http;
6+
namespace Microsoft.Extensions.DependencyInjection;
87

98
/// <summary>
109
/// Extension methods to configure JSON serialization behavior.
1110
/// </summary>
12-
public static class HttpJsonServiceExtensions
11+
public static class RouteHandlerJsonServiceExtensions
1312
{
13+
#pragma warning disable CS0419 // Ambiguous reference in cref attribute
1414
/// <summary>
1515
/// Configures options used for reading and writing JSON by route handlers.
1616
/// </summary>
1717
/// <remarks>
1818
/// The options configured here will only affect JSON returned and processed
19-
/// from route handlers, not controllers.
19+
/// from route handlers, not controllers, when using <see cref="System.Net.Http.Json.HttpContentJsonExtensions.ReadFromJsonAsync" />
20+
/// and <see cref="Microsoft.AspNetCore.Http.HttpResponseJsonExtensions.WriteAsJsonAsync" />.
2021
/// </remarks>
2122
/// <param name="services">The <see cref="IServiceCollection" /> to configure options on.</param>
2223
/// <param name="configureOptions">The <see cref="Action{JsonOptions}"/> to configure the
2324
/// <see cref="JsonOptions"/>.</param>
2425
/// <returns>The modified <see cref="IServiceCollection"/>.</returns>
25-
public static IServiceCollection ConfigureHttpJsonOptions(this IServiceCollection services, Action<JsonOptions> configureOptions)
26+
#pragma warning restore CS0419 // Ambiguous reference in cref attribute
27+
public static IServiceCollection ConfigureRouteHandlerJsonOptions(this IServiceCollection services, Action<JsonOptions> configureOptions)
2628
{
2729
services.Configure<JsonOptions>(configureOptions);
2830
return services;
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#nullable enable
2-
Microsoft.AspNetCore.Http.HttpJsonServiceExtensions
3-
static Microsoft.AspNetCore.Http.HttpJsonServiceExtensions.ConfigureHttpJsonOptions(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<Microsoft.AspNetCore.Http.Json.JsonOptions!>! configureOptions) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
2+
Microsoft.Extensions.DependencyInjection.RouteHandlerJsonServiceExtensions
3+
static Microsoft.Extensions.DependencyInjection.RouteHandlerJsonServiceExtensions.ConfigureRouteHandlerJsonOptions(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<Microsoft.AspNetCore.Http.Json.JsonOptions!>! configureOptions) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!

0 commit comments

Comments
 (0)