Skip to content

Commit 67bea7d

Browse files
committed
Revert "Use checked-in platform manifest in 3.1.2 (#18250)"
This reverts commit ee57a0c.
1 parent 1f8d02e commit 67bea7d

File tree

5 files changed

+17
-137
lines changed

5 files changed

+17
-137
lines changed

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
<!-- We can remove the 3.1.2 line from any branch other than release/3.1 and from here after 3.1.2 is released. -->
8989
<IsTargetingPackBuilding Condition=" '$(DotNetBuildFromSource)' == 'true' ">false</IsTargetingPackBuilding>
9090
<IsTargetingPackBuilding
91-
Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(VersionPrefix)' == '3.1.2' ">true</IsTargetingPackBuilding>
91+
Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(VersionPrefix)' == '3.0.1' ">true</IsTargetingPackBuilding>
9292
<IsTargetingPackBuilding
9393
Condition=" '$(IsTargetingPackBuilding)' == '' AND '$(AspNetCorePatchVersion)' != '0' ">false</IsTargetingPackBuilding>
9494
<IsTargetingPackBuilding Condition=" '$(IsTargetingPackBuilding)' == '' ">true</IsTargetingPackBuilding>

eng/PlatformManifest.txt

Lines changed: 0 additions & 131 deletions
This file was deleted.

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<!-- TargetingPackVersionPrefix is used by projects, like .deb and .rpm, which use slightly different version formats. -->
3434
<TargetingPackVersionPrefix>$(VersionPrefix)</TargetingPackVersionPrefix>
3535
<!-- Targeting packs do not produce patch versions in servicing builds. No API changes are allowed in patches. -->
36-
<TargetingPackVersionPrefix Condition="'$(IsTargetingPackBuilding)' != 'true'">$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion).2</TargetingPackVersionPrefix>
36+
<TargetingPackVersionPrefix Condition="'$(IsServicingBuild)' == 'true'">$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion).0</TargetingPackVersionPrefix>
3737
<ExperimentalVersionPrefix>0.3.$(AspNetCorePatchVersion)</ExperimentalVersionPrefix>
3838
<!-- ANCM versioning is intentionally 10 + AspNetCoreMajorVersion because earlier versions of ANCM shipped as 8.x. -->
3939
<AspNetCoreModuleVersionMajor>$([MSBuild]::Add(10, $(AspNetCoreMajorVersion)))</AspNetCoreModuleVersionMajor>

src/Framework/ref/Microsoft.AspNetCore.App.Ref.csproj

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@ This package is an internal implementation of the .NET Core SDK and is not meant
5353
<!-- Platform manifest and package override metatdata -->
5454
<ReferencePackSharedFxVersion>$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion).0</ReferencePackSharedFxVersion>
5555
<ReferencePackSharedFxVersion Condition="'$(VersionSuffix)' != ''">$(ReferencePackSharedFxVersion)-$(VersionSuffix)</ReferencePackSharedFxVersion>
56-
<ReferencePlatformManifestPath Condition="'$(IsServicingBuild)' != 'true'">$(PlatformManifestOutputPath)</ReferencePlatformManifestPath>
57-
<ReferencePlatformManifestPath Condition="'$(IsServicingBuild)' == 'true'">$(RepoRoot)eng\PlatformManifest.txt</ReferencePlatformManifestPath>
56+
<ReferencePlatformManifestOutputPath>$(ArtifactsObjDir)ref\PlatformManifest.txt</ReferencePlatformManifestOutputPath>
5857
</PropertyGroup>
5958

6059
<ItemGroup>
@@ -144,11 +143,23 @@ This package is an internal implementation of the .NET Core SDK and is not meant
144143

145144
<AspNetCoreReferenceDocXml Include="@(_ResolvedProjectReferencePaths->WithMetadataValue('IsReferenceAssembly', 'false')->'%(RootDir)%(Directory)%(FileName).xml')" />
146145
<AspNetCoreReferenceDocXml Include="@(_SelectedExtensionsRefAssemblies->'$(MicrosoftInternalExtensionsRefsPath)%(FileName).xml')" />
146+
</ItemGroup>
147+
148+
<RepoTasks.GenerateSharedFrameworkDepsFile
149+
DepsFilePath="$(ProjectDepsFilePath)"
150+
TargetFramework="$(TargetFramework)"
151+
FrameworkName="$(TargetingPackName)"
152+
FrameworkVersion="$(ReferencePackSharedFxVersion)"
153+
References="@(AspNetCoreReferenceAssemblyPath)"
154+
RuntimeIdentifier="$(TargetRuntimeIdentifier)"
155+
RuntimePackageName="$(PackageId)"
156+
PlatformManifestOutputPath="$(ReferencePlatformManifestOutputPath)" />
147157

158+
<ItemGroup>
148159
<RefPackContent Include="@(AspNetCoreReferenceAssemblyPath)" PackagePath="$(RefAssemblyPackagePath)" />
149160
<RefPackContent Include="@(AspNetCoreReferenceDocXml)" PackagePath="$(RefAssemblyPackagePath)" />
150161
<RefPackContent Include="$(TargetDir)$(PackageConflictManifestFileName)" PackagePath="$(ManifestsPackagePath)" />
151-
<RefPackContent Include="$(ReferencePlatformManifestPath)" PackagePath="$(ManifestsPackagePath)" />
162+
<RefPackContent Include="$(ReferencePlatformManifestOutputPath)" PackagePath="$(ManifestsPackagePath)" />
152163
</ItemGroup>
153164
</Target>
154165

src/Framework/test/TargetingPackTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void AssembliesAreReferenceAssemblies()
5959
public void PlatformManifestListsAllFiles()
6060
{
6161
var platformManifestPath = Path.Combine(_targetingPackRoot, "data", "PlatformManifest.txt");
62-
var expectedAssemblies = TestData.GetSharedFxDependencies()
62+
var expectedAssemblies = TestData.GetTargetingPackDependencies()
6363
.Split(';', StringSplitOptions.RemoveEmptyEntries)
6464
.Select(i =>
6565
{

0 commit comments

Comments
 (0)