Fix up tests and targetFactory invocation

Author: captainsafia

src/Http/Http.Extensions/src/RequestDelegateFactory.cs

@@ -164,7 +164,7 @@ public static RequestDelegateResult Create(MethodInfo methodInfo, Func<HttpConte
         }
 
         var targetExpression = Expression.Convert(TargetExpr, methodInfo.DeclaringType);
-        var targetableRequestDelegate = CreateTargetableRequestDelegate(methodInfo, targetExpression, factoryContext, context => targetFactory);
+        var targetableRequestDelegate = CreateTargetableRequestDelegate(methodInfo, targetExpression, factoryContext, context => targetFactory(context));
 
         return new RequestDelegateResult(httpContext => targetableRequestDelegate(targetFactory(httpContext), httpContext), factoryContext.Metadata);
     }
@@ -259,7 +259,7 @@ private static RouteHandlerFilterDelegate CreateFilterPipeline(MethodInfo method
         // ? Task.CompletedTask
         // : {
         //  target = targetFactory(httpContext);
-        //  // handler is ((Type)target).MethodName(parameters);
+        //  handler is ((Type)target).MethodName(parameters);
         //  handler((string)context.Parameters[0], (int)context.Parameters[1]);
         // }
         var filteredInvocation = Expression.Lambda<RouteHandlerFilterDelegate>(

src/Http/Http.Extensions/test/RequestDelegateFactoryTests.cs

@@ -4268,7 +4268,6 @@ public async Task RequestDelegateFactory_InvokesFilters_OnDelegateWithTarget()
             {
                 (routeHandlerContext, next) => async (context) =>
                 {
-                    Console.WriteLine(context.Parameters[0]);
                     return await next(context);
                 }
             }
@@ -4286,7 +4285,7 @@ string GetString(string name)
     }
 
     [Fact]
-    public async Task RequestDelegateFactory_InvokesFilters_OnMethodInfoWithTargetFactory()
+    public async Task RequestDelegateFactory_InvokesFilters_OnMethodInfoWithNullTargetFactory()
     {
         // Arrange
         var methodInfo = typeof(RequestDelegateFactoryTests).GetMethod(
@@ -4304,17 +4303,17 @@ public async Task RequestDelegateFactory_InvokesFilters_OnMethodInfoWithTargetFa
         {
             RouteHandlerFilterFactories = new List<Func<RouteHandlerContext, RouteHandlerFilterDelegate, RouteHandlerFilterDelegate>>()
             {
-                (routeHandlerContext, next) => (context) =>
+                (routeHandlerContext, next) => async (context) =>
                 {
-                    return ValueTask.FromResult<object?>(Results.Created("/foo", "Great!"));
+                    return await next(context);
                 }
             }
         });
         var requestDelegate = factoryResult.RequestDelegate;
         await requestDelegate(httpContext);
 
         // Assert
-        Assert.Equal(201, httpContext.Response.StatusCode);
+        Assert.Equal(200, httpContext.Response.StatusCode);
     }
 
     [Fact]
@@ -4337,23 +4336,23 @@ public async Task RequestDelegateFactory_InvokesFilters_OnMethodInfoWithProvided
         {
             invoked = true;
             context.Items["invoked"] = true;
-            return methodInfo!.DeclaringType!;
+            return Activator.CreateInstance(methodInfo!.DeclaringType!);
         };
         var factoryResult = RequestDelegateFactory.Create(methodInfo!, targetFactory, new RequestDelegateFactoryOptions()
         {
             RouteHandlerFilterFactories = new List<Func<RouteHandlerContext, RouteHandlerFilterDelegate, RouteHandlerFilterDelegate>>()
             {
-                (routeHandlerContext, next) => (context) =>
+                (routeHandlerContext, next) => async (context) =>
                 {
-                    return ValueTask.FromResult<object?>(Results.Created("/foo", "Great!"));
+                    return await next(context);
                 }
             }
         });
         var requestDelegate = factoryResult.RequestDelegate;
         await requestDelegate(httpContext);
 
         // Assert
-        Assert.Equal(201, httpContext.Response.StatusCode);
+        Assert.Equal(200, httpContext.Response.StatusCode);
         Assert.True(invoked);
         var invokedInContext = Assert.IsType<bool>(httpContext.Items["invoked"]);
         Assert.True(invokedInContext);