Soft enable CA1810 (#33659)

A lot of the warnings for this rule appear from logging. Given this is going
to be replaced by a source generator, this change soft enables the rule while
fixing warnings that appear in non-logging code

Contributes to #24055

Author: pranavkm

.editorconfig

@@ -91,13 +91,19 @@ dotnet_diagnostic.CA1802.severity = warning
 # CA1805: Do not initialize unnecessarily
 dotnet_diagnostic.CA1805.severity = warning
 
-# CA1823: Remove empty Finalizers
+# CA1810: Do not initialize unnecessarily
+dotnet_diagnostic.CA1810.severity = suggestion
+
+# CA1821: Remove empty Finalizers
 dotnet_diagnostic.CA1821.severity = warning
 
+# CA1822: Make member static
+dotnet_diagnostic.CA1822.severity = suggestion
+
 # CA1823: Avoid unused private fields
 dotnet_diagnostic.CA1823.severity = warning
 
-# CA1823: Avoid zero-length array allocations
+# CA1825: Avoid zero-length array allocations
 dotnet_diagnostic.CA1825.severity = warning
 
 # CA1826: Do not use Enumerable methods on indexable collections. Instead use the collection directly
@@ -185,9 +191,21 @@ dotnet_diagnostic.CA2200.severity = warning
 # CA2208: Instantiate argument exceptions correctly
 dotnet_diagnostic.CA2208.severity = warning
 
-[**/HostFactoryResolver.cs]
-# CA1823: Use literals where appropriate
-dotnet_diagnostic.CA1802.severity = suggestion
+# IDE0035: Remove unreachable code
+dotnet_diagnostic.IDE0035.severity = warning
+
+# IDE0036: Order modifiers
+dotnet_diagnostic.IDE0036.severity = warning
+
+# IDE0043: Format string contains invalid placeholder
+dotnet_diagnostic.IDE0043.severity = warning
+
+# IDE0044: Make field readonly
+dotnet_diagnostic.IDE0044.severity = warning
+
+# IDE0073: File header
+dotnet_diagnostic.IDE0073.severity = warning
+file_header_template = Copyright (c) .NET Foundation. All rights reserved.\nLicensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 [**/{test,samples,perf}/**.{cs,vb}]
 # CA1018: Mark attributes with AttributeUsageAttribute

src/Components/Web/src/Forms/InputNumber.cs

@@ -14,9 +14,9 @@ namespace Microsoft.AspNetCore.Components.Forms
     /// </summary>
     public class InputNumber<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All)] TValue> : InputBase<TValue>
     {
-        private readonly static string _stepAttributeValue; // Null by default, so only allows whole numbers as per HTML spec
+        private static readonly string _stepAttributeValue = GetStepAttributeValue();
 
-        static InputNumber()
+        private static string GetStepAttributeValue()
         {
             // Unwrap Nullable<T>, because InputBase already deals with the Nullable aspect
             // of it for us. We will only get asked to parse the T for nonempty inputs.
@@ -28,7 +28,7 @@ static InputNumber()
                 targetType == typeof(double) ||
                 targetType == typeof(decimal))
             {
-                _stepAttributeValue = "any";
+                return "any";
             }
             else
             {

src/Components/WebAssembly/WebAssembly/src/Rendering/RendererRegistry.cs

@@ -13,16 +13,8 @@ internal static class RendererRegistry
         // as well as rooting them for GC purposes, since nothing would otherwise be referencing
         // them even though we might still receive incoming events from JS.
 
+        private static readonly Dictionary<int, WebAssemblyRenderer>? _renderers = OperatingSystem.IsBrowser() ? new() : null;
         private static int _nextId;
-        private static Dictionary<int, WebAssemblyRenderer>? _renderers;
-
-        static RendererRegistry()
-        {
-            if (OperatingSystem.IsBrowser())
-            {
-                _renderers = new Dictionary<int, WebAssemblyRenderer>();
-            }
-        }
 
         internal static WebAssemblyRenderer Find(int rendererId)
         {

src/Components/WebAssembly/WebAssembly/src/Rendering/WebAssemblyRenderer.cs

@@ -163,21 +163,16 @@ protected override void HandleException(Exception exception)
 
         private static class Log
         {
-            private static readonly Action<ILogger, string, Exception> _unhandledExceptionRenderingComponent;
+            private static readonly Action<ILogger, string, Exception> _unhandledExceptionRenderingComponent = LoggerMessage.Define<string>(
+                LogLevel.Critical,
+                EventIds.UnhandledExceptionRenderingComponent,
+                "Unhandled exception rendering component: {Message}");
 
             private static class EventIds
             {
                 public static readonly EventId UnhandledExceptionRenderingComponent = new EventId(100, "ExceptionRenderingComponent");
             }
 
-            static Log()
-            {
-                _unhandledExceptionRenderingComponent = LoggerMessage.Define<string>(
-                    LogLevel.Critical,
-                    EventIds.UnhandledExceptionRenderingComponent,
-                    "Unhandled exception rendering component: {Message}");
-            }
-
             public static void UnhandledExceptionRenderingComponent(ILogger logger, Exception exception)
             {
                 _unhandledExceptionRenderingComponent(

src/Components/WebAssembly/WebAssembly/src/Services/WebAssemblyConsoleLogger.cs

@@ -13,20 +13,13 @@ namespace Microsoft.AspNetCore.Components.WebAssembly.Services
     internal class WebAssemblyConsoleLogger<T> : ILogger<T>, ILogger
     {
         private const string _loglevelPadding = ": ";
-        private static readonly string _messagePadding;
-        private static readonly string _newLineWithMessagePadding;
+        private static readonly string _messagePadding = new(' ', GetLogLevelString(LogLevel.Information).Length + _loglevelPadding.Length);
+        private static readonly string _newLineWithMessagePadding = Environment.NewLine + _messagePadding;
         private static readonly StringBuilder _logBuilder = new StringBuilder();
 
         private readonly string _name;
         private readonly WebAssemblyJSRuntime _jsRuntime;
 
-        static WebAssemblyConsoleLogger()
-        {
-            var logLevelString = GetLogLevelString(LogLevel.Information);
-            _messagePadding = new string(' ', logLevelString.Length + _loglevelPadding.Length);
-            _newLineWithMessagePadding = Environment.NewLine + _messagePadding;
-        }
-
         public WebAssemblyConsoleLogger(IJSRuntime jsRuntime)
             : this(string.Empty, (WebAssemblyJSRuntime)jsRuntime) // Cast for DI
         {

src/DataProtection/DataProtection/src/KeyManagement/DefaultKeyResolver.cs

@@ -47,8 +47,8 @@ public DefaultKeyResolver(IOptions<KeyManagementOptions> keyManagementOptions)
 
         public DefaultKeyResolver(IOptions<KeyManagementOptions> keyManagementOptions, ILoggerFactory loggerFactory)
         {
-            _keyPropagationWindow = keyManagementOptions.Value.KeyPropagationWindow;
-            _maxServerToServerClockSkew = keyManagementOptions.Value.MaxServerClockSkew;
+            _keyPropagationWindow = KeyManagementOptions.KeyPropagationWindow;
+            _maxServerToServerClockSkew = KeyManagementOptions.MaxServerClockSkew;
             _logger = loggerFactory.CreateLogger<DefaultKeyResolver>();
         }
 

src/DataProtection/DataProtection/src/KeyManagement/KeyManagementOptions.cs

@@ -71,7 +71,7 @@ internal KeyManagementOptions(KeyManagementOptions other)
         /// <remarks>
         /// This value is currently fixed at 48 hours.
         /// </remarks>
-        internal TimeSpan KeyPropagationWindow
+        internal static TimeSpan KeyPropagationWindow
         {
             get
             {
@@ -89,7 +89,7 @@ internal TimeSpan KeyPropagationWindow
         /// <remarks>
         /// This value is currently fixed at 24 hours.
         /// </remarks>
-        internal TimeSpan KeyRingRefreshPeriod
+        internal static TimeSpan KeyRingRefreshPeriod
         {
             get
             {
@@ -109,7 +109,7 @@ internal TimeSpan KeyRingRefreshPeriod
         /// <remarks>
         /// This value is currently fixed at 5 minutes.
         /// </remarks>
-        internal TimeSpan MaxServerClockSkew
+        internal static TimeSpan MaxServerClockSkew
         {
             get
             {

src/DataProtection/DataProtection/src/KeyManagement/KeyRingProvider.cs

@@ -128,7 +128,7 @@ private CacheableKeyRing CreateCacheableKeyRingCoreStep2(DateTimeOffset now, Can
 
             _logger.UsingKeyAsDefaultKey(defaultKey.KeyId);
 
-            var nextAutoRefreshTime = now + GetRefreshPeriodWithJitter(_keyManagementOptions.KeyRingRefreshPeriod);
+            var nextAutoRefreshTime = now + GetRefreshPeriodWithJitter(KeyManagementOptions.KeyRingRefreshPeriod);
 
             // The cached keyring should expire at the earliest of (default key expiration, next auto-refresh time).
             // Since the refresh period and safety window are not user-settable, we can guarantee that there's at

src/DataProtection/DataProtection/src/TypeForwardingActivator.cs

@@ -61,7 +61,7 @@ internal object CreateInstance(Type expectedBaseType, string originalTypeName, o
             return base.CreateInstance(expectedBaseType, originalTypeName);
         }
 
-        protected string RemoveVersionFromAssemblyName(string forwardedTypeName)
+        protected static string RemoveVersionFromAssemblyName(string forwardedTypeName)
         {
             // Type, Assembly, Version={Version}, Culture={Culture}, PublicKeyToken={Token}
 

src/DataProtection/DataProtection/src/XmlEncryption/XmlKeyDecryptionOptions.cs

@@ -35,6 +35,6 @@ public void AddKeyDecryptionCertificate(X509Certificate2 certificate)
             certificates.Add(certificate);
         }
 
-        private string GetKey(X509Certificate2 cert) => cert.Thumbprint;
+        private static string GetKey(X509Certificate2 cert) => cert.Thumbprint;
     }
 }

src/Hosting/Hosting/src/GenericHost/GenericWebHostBuilder.cs

@@ -351,7 +351,7 @@ public IWebHostBuilder Configure(Action<WebHostBuilderContext, IApplicationBuild
             return this;
         }
 
-        private WebHostBuilderContext GetWebHostBuilderContext(HostBuilderContext context)
+        private static WebHostBuilderContext GetWebHostBuilderContext(HostBuilderContext context)
         {
             if (!context.Properties.TryGetValue(typeof(WebHostBuilderContext), out var contextVal))
             {

src/Hosting/Hosting/src/Internal/ApplicationLifetime.cs

@@ -101,7 +101,7 @@ public void NotifyStopped()
             }
         }
 
-        private void ExecuteHandlers(CancellationTokenSource cancel)
+        private static void ExecuteHandlers(CancellationTokenSource cancel)
         {
             // Noop if this is already cancelled
             if (cancel.IsCancellationRequested)

src/Hosting/Hosting/src/Internal/HostingApplication.cs

@@ -111,7 +111,7 @@ public void DisposeContext(Context context, Exception? exception)
                 _httpContextFactory!.Dispose(httpContext);
             }
 
-            _diagnostics.ContextDisposed(context);
+            HostingApplicationDiagnostics.ContextDisposed(context);
 
             // Reset the context as it may be pooled
             context.Reset();

src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs

@@ -176,7 +176,7 @@ public void RequestEnd(HttpContext httpContext, Exception? exception, HostingApp
         }
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public void ContextDisposed(HostingApplication.Context context)
+        public static void ContextDisposed(HostingApplication.Context context)
         {
             if (context.EventLogEnabled)
             {

src/Hosting/Hosting/src/Internal/WebHost.cs

@@ -356,7 +356,7 @@ public async ValueTask DisposeAsync()
             await DisposeServiceProviderAsync(_hostingServiceProvider).ConfigureAwait(false);
         }
 
-        private async ValueTask DisposeServiceProviderAsync(IServiceProvider? serviceProvider)
+        private static async ValueTask DisposeServiceProviderAsync(IServiceProvider? serviceProvider)
         {
             switch (serviceProvider)
             {

src/Hosting/Hosting/src/Internal/WebHostOptions.cs

@@ -69,7 +69,7 @@ public IEnumerable<string> GetFinalHostingStartupAssemblies()
             return HostingStartupAssemblies.Except(HostingStartupExcludeAssemblies, StringComparer.OrdinalIgnoreCase);
         }
 
-        private IReadOnlyList<string> Split(string value)
+        private static IReadOnlyList<string> Split(string value)
         {
             return value?.Split(';', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries)
                 ?? Array.Empty<string>();

src/Hosting/Hosting/src/WebHostBuilder.cs

@@ -338,7 +338,7 @@ private IServiceCollection BuildCommonServices(out AggregateException? hostingSt
             return services;
         }
 
-        private void AddApplicationServices(IServiceCollection services, IServiceProvider hostingServiceProvider)
+        private static void AddApplicationServices(IServiceCollection services, IServiceProvider hostingServiceProvider)
         {
             // We are forwarding services from hosting container so hosting container
             // can still manage their lifetime (disposal) shared instances with application services.
@@ -352,7 +352,7 @@ private void AddApplicationServices(IServiceCollection services, IServiceProvide
             services.Replace(ServiceDescriptor.Singleton(typeof(ActivitySource), activitySource!));
         }
 
-        private string ResolveContentRootPath(string contentRootPath, string basePath)
+        private static string ResolveContentRootPath(string contentRootPath, string basePath)
         {
             if (string.IsNullOrEmpty(contentRootPath))
             {

src/Http/Headers/src/ContentDispositionHeaderValue.cs

@@ -518,7 +518,7 @@ private StringSegment Sanitize(StringSegment input)
         }
 
         // Returns true if the value starts and ends with a quote
-        private bool IsQuoted(StringSegment value)
+        private static bool IsQuoted(StringSegment value)
         {
             Contract.Assert(value != null);
 
@@ -527,7 +527,7 @@ private bool IsQuoted(StringSegment value)
         }
 
         // tspecials are required to be in a quoted string.  Only non-ascii needs to be encoded.
-        private bool RequiresEncoding(StringSegment input)
+        private static bool RequiresEncoding(StringSegment input)
         {
             Contract.Assert(input != null);
 
@@ -607,7 +607,7 @@ private bool TryDecodeMime(StringSegment input, [NotNullWhen(true)] out string?
 
         // Encode a string using RFC 5987 encoding
         // encoding'lang'PercentEncodedSpecials
-        private string Encode5987(StringSegment input)
+        private static string Encode5987(StringSegment input)
         {
             var builder = new StringBuilder("UTF-8\'\'");
             for (int i = 0; i < input.Length; i++)
@@ -649,7 +649,7 @@ private static void HexEscape(StringBuilder builder, char c)
 
         // Attempt to decode using RFC 5987 encoding.
         // encoding'language'my%20string
-        private bool TryDecode5987(StringSegment input, [NotNullWhen(true)] out string? output)
+        private static bool TryDecode5987(StringSegment input, [NotNullWhen(true)] out string? output)
         {
             output = null;
 

src/Http/Http/src/Features/FormFeature.cs

@@ -305,26 +305,26 @@ private static Encoding FilterEncoding(Encoding? encoding)
             return encoding;
         }
 
-        private bool HasApplicationFormContentType([NotNullWhen(true)] MediaTypeHeaderValue? contentType)
+        private static bool HasApplicationFormContentType([NotNullWhen(true)] MediaTypeHeaderValue? contentType)
         {
             // Content-Type: application/x-www-form-urlencoded; charset=utf-8
             return contentType != null && contentType.MediaType.Equals("application/x-www-form-urlencoded", StringComparison.OrdinalIgnoreCase);
         }
 
-        private bool HasMultipartFormContentType([NotNullWhen(true)] MediaTypeHeaderValue? contentType)
+        private static bool HasMultipartFormContentType([NotNullWhen(true)] MediaTypeHeaderValue? contentType)
         {
             // Content-Type: multipart/form-data; boundary=----WebKitFormBoundarymx2fSWqWSd0OxQqq
             return contentType != null && contentType.MediaType.Equals("multipart/form-data", StringComparison.OrdinalIgnoreCase);
         }
 
-        private bool HasFormDataContentDisposition(ContentDispositionHeaderValue contentDisposition)
+        private static bool HasFormDataContentDisposition(ContentDispositionHeaderValue contentDisposition)
         {
             // Content-Disposition: form-data; name="key";
             return contentDisposition != null && contentDisposition.DispositionType.Equals("form-data")
                 && StringSegment.IsNullOrEmpty(contentDisposition.FileName) && StringSegment.IsNullOrEmpty(contentDisposition.FileNameStar);
         }
 
-        private bool HasFileContentDisposition(ContentDispositionHeaderValue contentDisposition)
+        private static bool HasFileContentDisposition(ContentDispositionHeaderValue contentDisposition)
         {
             // Content-Disposition: form-data; name="myfile1"; filename="Misc 002.jpg"
             return contentDisposition != null && contentDisposition.DispositionType.Equals("form-data")

src/Http/Routing/src/DefaultParameterPolicyFactory.cs

@@ -65,7 +65,7 @@ public override IParameterPolicy Create(RoutePatternParameterPart? parameter, st
             return parameterPolicy;
         }
 
-        private IParameterPolicy InitializeRouteConstraint(
+        private static IParameterPolicy InitializeRouteConstraint(
             bool optional,
             IRouteConstraint routeConstraint)
         {

src/Http/Routing/src/Matching/DfaMatcher.cs

@@ -222,7 +222,7 @@ public sealed override Task MatchAsync(HttpContext httpContext)
             return (states[destination].Candidates, states[destination].Policies);
         }
 
-        private void ProcessCaptures(
+        private static void ProcessCaptures(
             KeyValuePair<string, object?>[] slots,
             (string parameterName, int segmentIndex, int slotIndex)[] captures,
             string path,
@@ -245,7 +245,7 @@ private void ProcessCaptures(
             }
         }
 
-        private void ProcessCatchAll(
+        private static void ProcessCatchAll(
             KeyValuePair<string, object?>[] slots,
             in (string parameterName, int segmentIndex, int slotIndex) catchAll,
             string path,

src/Http/Routing/src/Matching/EndpointComparer.cs

@@ -51,7 +51,7 @@ public int Compare(Endpoint? x, Endpoint? y)
             return compare == 0 ? ComparePattern(x, y) : compare;
         }
 
-        private int ComparePattern(Endpoint x, Endpoint y)
+        private static int ComparePattern(Endpoint x, Endpoint y)
         {
             // A RouteEndpoint always comes before a non-RouteEndpoint, regardless of its RawText value
             var routeEndpointX = x as RouteEndpoint;

src/Http/Routing/src/Matching/HostMatcherPolicy.cs

@@ -49,7 +49,7 @@ bool IEndpointSelectorPolicy.AppliesToEndpoints(IReadOnlyList<Endpoint> endpoint
             return applies;
         }
 
-        private bool AppliesToEndpointsCore(IReadOnlyList<Endpoint> endpoints)
+        private static bool AppliesToEndpointsCore(IReadOnlyList<Endpoint> endpoints)
         {
             return endpoints.Any(e =>
             {
@@ -296,7 +296,7 @@ public PolicyJumpTable BuildJumpTable(int exitDestination, IReadOnlyList<PolicyJ
             return new HostPolicyJumpTable(exitDestination, ordered);
         }
 
-        private int GetScore(in EdgeKey key)
+        private static int GetScore(in EdgeKey key)
         {
             // Higher score == lower priority.
             if (key.MatchesHost && !key.HasHostWildcard && key.MatchesPort)