Skip to content

Commit 898347f

Browse files
committed
Add comments per review feedback
1 parent 8eb2e11 commit 898347f

File tree

4 files changed

+4
-0
lines changed

4 files changed

+4
-0
lines changed

.azure/pipelines/ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -684,6 +684,7 @@ stages:
684684
- script: ./eng/build.cmd -ci -nobl -all -pack -arch x64
685685
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)
686686
displayName: Build shared fx
687+
# -noBuildRepoTasks -noBuildNative -noBuild to avoid repeating work done in the previous step.
687688
- script: ./eng/build.cmd -ci -nobl -all -noBuildRepoTasks -noBuildNative -noBuild -test
688689
-projects eng\helix\helix.proj /p:IsHelixPRCheck=true /p:IsHelixJob=true
689690
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)

.azure/pipelines/helix-matrix.yml

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
- script: ./eng/build.cmd -ci -nobl -all -pack -arch x64
3434
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
3535
displayName: Build shared fx
36+
# -noBuildRepoTasks -noBuildNative -noBuild to avoid repeating work done in the previous step.
3637
- script: .\eng\build.cmd -ci -nobl -all -noBuildRepoTasks -noBuildNative -noBuild -test
3738
-projects eng\helix\helix.proj /p:IsHelixJob=true
3839
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log

.azure/pipelines/quarantined-pr.yml

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ jobs:
5757
- script: ./eng/build.cmd -ci -nobl -all -noBuildJava -pack -arch x64
5858
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
5959
displayName: Build shared fx
60+
# -noBuildRepoTasks -noBuildNative -noBuild to avoid repeating work done in the previous step.
6061
- script: ./eng/build.cmd -ci -nobl -all -noBuildRepoTasks -noBuildNative -noBuild -noBuildJava -test
6162
-projects eng\helix\helix.proj /p:IsHelixPRCheck=true /p:RunQuarantinedTests=true /p:IsHelixJob=true
6263
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log

.azure/pipelines/quarantined-tests.yml

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
- script: ./eng/build.cmd -ci -nobl -all -noBuildJava -pack -arch x64
2929
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log
3030
displayName: Build shared fx
31+
# -noBuildRepoTasks -noBuildNative -noBuild to avoid repeating work done in the previous step.
3132
- script: ./eng/build.cmd -ci -nobl -all -noBuildRepoTasks -noBuildNative -noBuild -noBuildJava -test
3233
-projects eng\helix\helix.proj /p:RunQuarantinedTests=true /p:IsHelixJob=true
3334
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log

0 commit comments

Comments
 (0)