Skip to content

Commit b375410

Browse files
Fix cleaning send queue on restart (#18511)
1 parent 9501874 commit b375410

File tree

8 files changed

+286
-1185
lines changed

8 files changed

+286
-1185
lines changed

src/SignalR/clients/ts/FunctionalTests/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@
1818
"es6-promise": "^4.2.4",
1919
"jasmine": "^3.2.0",
2020
"jasmine-core": "^3.2.1",
21-
"karma": "^3.0.0",
21+
"karma": "^4.4.1",
2222
"karma-chrome-launcher": "^2.2.0",
2323
"karma-edge-launcher": "^0.4.2",
24-
"karma-firefox-launcher": "^1.1.0",
24+
"karma-firefox-launcher": "^1.3.0",
2525
"karma-ie-launcher": "^1.0.0",
26-
"karma-jasmine": "^1.1.2",
26+
"karma-jasmine": "^3.1.0",
2727
"karma-junit-reporter": "^1.2.0",
2828
"karma-mocha-reporter": "^2.2.5",
2929
"karma-safari-launcher": "^1.0.0",
3030
"karma-sauce-launcher": "^1.2.0",
3131
"karma-sourcemap-loader": "^0.3.7",
3232
"karma-summary-reporter": "^1.6.0",
3333
"rxjs": "^6.3.3",
34-
"ts-node": "^4.1.0",
35-
"typescript": "^2.7.1",
34+
"ts-node": "^8.6.2",
35+
"typescript": "^3.7.5",
3636
"ws": " ^6.0.0"
3737
},
3838
"scripts": {

src/SignalR/clients/ts/FunctionalTests/scripts/karma.local.conf.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,17 @@ try {
4343
}
4444

4545
// We use the launchers themselves to figure out if the browser exists. It's a bit sneaky, but it works.
46-
tryAddBrowser("ChromeHeadlessNoSandbox", new ChromeHeadlessBrowser(() => { }, {}));
47-
tryAddBrowser("ChromiumHeadlessIgnoreCert", new ChromiumHeadlessBrowser(() => { }, {}));
48-
if (!tryAddBrowser("FirefoxHeadless", new FirefoxHeadlessBrowser(0, () => { }, {}))) {
49-
tryAddBrowser("FirefoxDeveloperHeadless", new FirefoxDeveloperHeadlessBrowser(0, () => { }, {}));
46+
tryAddBrowser("ChromeHeadlessNoSandbox", ChromeHeadlessBrowser.prototype);
47+
tryAddBrowser("ChromiumHeadlessIgnoreCert", ChromiumHeadlessBrowser.prototype);
48+
if (!tryAddBrowser("FirefoxHeadless", FirefoxHeadlessBrowser.prototype)) {
49+
tryAddBrowser("FirefoxDeveloperHeadless", FirefoxDeveloperHeadlessBrowser.prototype);
5050
}
5151

5252
// We need to receive an argument from the caller, but globals don't seem to work, so we use an environment variable.
5353
if (process.env.ASPNETCORE_SIGNALR_TEST_ALL_BROWSERS === "true") {
54-
tryAddBrowser("Edge", new EdgeBrowser(() => { }, { create() { } }));
55-
tryAddBrowser("IE", new IEBrowser(() => { }, { create() { } }, {}));
56-
tryAddBrowser("Safari", new SafariBrowser(() => { }, {}));
54+
tryAddBrowser("Edge", EdgeBrowser.prototype);
55+
tryAddBrowser("IE", IEBrowser.prototype);
56+
tryAddBrowser("Safari", SafariBrowser.prototype);
5757
}
5858

5959
module.exports = createKarmaConfig({

0 commit comments

Comments
 (0)