Skip to content

Commit c8a3c22

Browse files
dougbudougbu
authoredOct 14, 2021
Improve project reference consistency (#37338)
* Improve project reference consistency - use `Private` and `SkipGetTargetFrameworkProperties` w/ `ReferenceOutputAssemblies="false"` - correct meaningless `$(ReferenceOutputAssemblies)` settings; no such metadata - `Private="false"` avoids unnecessary file copies - `SkipGetTargetFrameworkProperties="true"` should reduce useless TFM negotiation - that said, it can't be used everywhere due to multi-targeting restrictions - do not use `PrivateAssets="All"` in `@(ProjectReference)` items or `@(Reference) items that become them - has no meaning in `@(ProjectReference)` items - add warnings about mixed-up application of `%(Private)` and `%(PrivateAssets)` nit: make references _look_ consistent too e.g. use consistent attribute order and wrap lines * Remove most `UndefineProperties` use - should not be necessary - but, keep using this metadata when referring to .npmproj projects * !fixup! Fix build issues found on CI - remove `SkipGetTargetFrameworkProperties="true"` from App.Ref reference to App.CodeFixes - need TFM negotiation when App.Ref builds on at least some platforms - firm up `net7.0` ➡️ `netstandard2.0` transition - fix typo in Rpm.TargetingPack.rpmproj - align Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj w/ Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj - use same Microsoft.Web.Xdt.Extensions reference approach nit: remove extra Microsoft.AspNetCore.App.Analyzers references; brought in by App.CodeFixes
·
v10.0.0-preview.4.25258.110v7.0.0-preview.1.22109.13
1 parent b39d5c5 commit c8a3c22

File tree

33 files changed

+248
-140
lines changed

33 files changed

+248
-140
lines changed
 

‎eng/targets/ResolveReferences.targets

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,25 @@
221221
Condition="'$(TargetFrameworkIdentifier)' != '.NETFramework' AND '%(Reference.Identity)' != '' AND ! Exists('%(Reference.Identity)') AND '$(DisablePackageReferenceRestrictions)' != 'true'"
222222
Code="MSB3245"
223223
Text="Could not resolve this reference. Could not locate the package or project for "%(Reference.Identity)". Did you update baselines and dependencies lists? See docs/ReferenceResolution.md for more details." />
224+
225+
<!--
226+
At this point, most if not all @(Reference) items have been converted to @(PackageReference) or
227+
@(ProjectReference) items. (Remaining .NET Framework @(Reference) items may exist but the SDK will hopefully
228+
resolve them.) Check whether these items use the easily-confused %(Private) or %(PrivateAssets) metadata.
229+
Because this metadata has different semantics, cannot convert one to the other.
230+
-->
231+
<Warning
232+
Condition=" @(PackageReference->HasMetadata('Private')->Count()) != 0 "
233+
Code="BUILD004"
234+
Text="%25(Private) metadata should not be applied to the %(Identity) package reference. Did you mean %25(PrivateAssets)?" />
235+
<Warning
236+
Condition=" @(ProjectReference->HasMetadata('PrivateAssets')->Count()) != 0 "
237+
Code="BUILD005"
238+
Text="%25(PrivateAssets) metadata should not be applied to the %(Identity) project reference. Did you mean %25(Private)?" />
239+
<Warning
240+
Condition=" @(Reference->HasMetadata('PrivateAssets')->Count()) != 0 "
241+
Code="BUILD006"
242+
Text="%25(PrivateAssets) metadata should not be applied to the %(Identity) assembly reference. Did you mean %25(Private)?" />
224243
</Target>
225244

226245
<PropertyGroup>

‎src/Components/Directory.Build.targets

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@
1515
<ItemGroup>
1616
<!-- Add a project dependency without reference output assemblies to enforce build order -->
1717
<!-- Applying workaround for https://github.com/microsoft/msbuild/issues/2661 and https://github.com/dotnet/sdk/issues/952 -->
18-
<ProjectReference
18+
<ProjectReference Include="$(RepoRoot)src\Components\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj"
1919
Condition="'$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' and '$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'"
20-
Include="$(RepoRoot)src\Components\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj"
21-
ReferenceOutputAssemblies="false"
20+
Private="false"
21+
ReferenceOutputAssembly="false"
2222
SkipGetTargetFrameworkProperties="true"
23-
UndefineProperties="TargetFramework"
24-
Private="false" />
23+
UndefineProperties="TargetFramework" />
2524
</ItemGroup>
2625

2726
<!-- blazor.webassembly.js should exist after Microsoft.AspNetCore.Components.Web.JS.npmproj builds. -->

‎src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,12 @@
3333

3434
<!-- Add a project dependency without reference output assemblies to enforce build order -->
3535
<!-- Applying workaround for https://github.com/microsoft/msbuild/issues/2661 and https://github.com/dotnet/sdk/issues/952 -->
36-
<ProjectReference Include="..\..\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj" ReferenceOutputAssemblies="false" SkipGetTargetFrameworkProperties="true" UndefineProperties="TargetFramework" Private="false" Condition="'$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'" />
36+
<ProjectReference Include="..\..\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj"
37+
Condition="'$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'"
38+
Private="false"
39+
ReferenceOutputAssembly="false"
40+
SkipGetTargetFrameworkProperties="true"
41+
UndefineProperties="TargetFramework" />
3742
</ItemGroup>
3843

3944
<PropertyGroup>

‎src/Components/Web.JS/Microsoft.AspNetCore.Components.Web.JS.npmproj

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@
2525
<ItemGroup>
2626
<ProjectReference
2727
Include="..\..\JSInterop\Microsoft.JSInterop.JS\src\Microsoft.JSInterop.JS.npmproj"
28-
ReferenceOutputAssemblies="false"
28+
Private="false"
29+
ReferenceOutputAssembly="false"
2930
SkipGetTargetFrameworkProperties="true"
30-
UndefineProperties="TargetFramework"
31-
Private="false" />
31+
UndefineProperties="TargetFramework" />
3232
<ProjectReference
3333
Include="..\..\SignalR\clients\ts\signalr\signalr.npmproj"
34-
ReferenceOutputAssemblies="false"
34+
Private="false"
35+
ReferenceOutputAssembly="false"
3536
SkipGetTargetFrameworkProperties="true"
36-
UndefineProperties="TargetFramework"
37-
Private="false" />
37+
UndefineProperties="TargetFramework" />
3838
<ProjectReference
3939
Include="..\..\SignalR\clients\ts\signalr-protocol-msgpack\signalr-protocol-msgpack.npmproj"
40-
ReferenceOutputAssemblies="false"
40+
Private="false"
41+
ReferenceOutputAssembly="false"
4142
SkipGetTargetFrameworkProperties="true"
42-
UndefineProperties="TargetFramework"
43-
Private="false" />
43+
UndefineProperties="TargetFramework" />
4444
</ItemGroup>
4545

4646
<!-- Workaround strange issues with something calling these targets. -->

‎src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,8 @@
2828
<!-- We include this here to ensure that the shared framework is built before we leverage it when running
2929
the dev server. -->
3030
<ItemGroup>
31-
<ProjectReference
32-
Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
33-
PrivateAssets="All"
31+
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
32+
Private="false"
3433
ReferenceOutputAssembly="false"
3534
SkipGetTargetFrameworkProperties="true" />
3635
</ItemGroup>

‎src/Components/WebAssembly/WebAssembly/src/Microsoft.AspNetCore.Components.WebAssembly.csproj

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@
1818
<Reference Include="Microsoft.Extensions.Logging" />
1919
<Reference Include="Microsoft.JSInterop.WebAssembly" />
2020

21-
<ProjectReference Include="..\..\..\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj" ReferenceOutputAssemblies="false" SkipGetTargetFrameworkProperties="true" UndefineProperties="TargetFramework" Private="false" Condition="'$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'" />
21+
<ProjectReference Include="..\..\..\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj"
22+
Condition="'$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'"
23+
Private="false"
24+
ReferenceOutputAssembly="false"
25+
SkipGetTargetFrameworkProperties="true"
26+
UndefineProperties="TargetFramework" />
2227
</ItemGroup>
2328

2429
<ItemGroup>

‎src/Components/WebView/WebView/src/Microsoft.AspNetCore.Components.WebView.csproj

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,12 @@
4444
<Reference Include="Microsoft.Extensions.FileProviders.Composite" />
4545
<Reference Include="Microsoft.Extensions.Logging" />
4646

47-
<ProjectReference
48-
Include="..\..\..\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj"
49-
ReferenceOutputAssemblies="false"
50-
SkipGetTargetFrameworkProperties="true"
51-
UndefineProperties="TargetFramework"
47+
<ProjectReference Include="..\..\..\Web.JS\Microsoft.AspNetCore.Components.Web.JS.npmproj"
48+
Condition="'$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'"
5249
Private="false"
53-
Condition="'$(BuildNodeJS)' != 'false' and '$(BuildingInsideVisualStudio)' != 'true'" />
50+
ReferenceOutputAssembly="false"
51+
SkipGetTargetFrameworkProperties="true"
52+
UndefineProperties="TargetFramework" />
5453
</ItemGroup>
5554

5655
<!-- This workaround is required when referencing FileProviders.Embedded as a project -->

‎src/DefaultBuilder/test/Microsoft.AspNetCore.FunctionalTests/Microsoft.AspNetCore.FunctionalTests.csproj

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,30 @@
1717
<ItemGroup>
1818
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
1919
<ProjectReference Include="$(RepoRoot)src\Servers\IIS\IntegrationTesting.IIS\src\Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj" />
20-
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\CreateDefaultBuilderApp\CreateDefaultBuilderApp.csproj" ReferenceOutputAssemblies="false" />
21-
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\CreateDefaultBuilderOfTApp\CreateDefaultBuilderOfTApp.csproj" ReferenceOutputAssemblies="false" />
22-
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\DependencyInjectionApp\DependencyInjectionApp.csproj" ReferenceOutputAssemblies="false" />
23-
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\StartRequestDelegateUrlApp\StartRequestDelegateUrlApp.csproj" ReferenceOutputAssemblies="false" />
24-
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\StartRouteBuilderUrlApp\StartRouteBuilderUrlApp.csproj" ReferenceOutputAssemblies="false" />
25-
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\StartWithIApplicationBuilderUrlApp\StartWithIApplicationBuilderUrlApp.csproj" ReferenceOutputAssemblies="false" />
20+
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\CreateDefaultBuilderApp\CreateDefaultBuilderApp.csproj"
21+
Private="false"
22+
ReferenceOutputAssembly="false"
23+
SkipGetTargetFrameworkProperties="true" />
24+
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\CreateDefaultBuilderOfTApp\CreateDefaultBuilderOfTApp.csproj"
25+
Private="false"
26+
ReferenceOutputAssembly="false"
27+
SkipGetTargetFrameworkProperties="true" />
28+
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\DependencyInjectionApp\DependencyInjectionApp.csproj"
29+
Private="false"
30+
ReferenceOutputAssembly="false"
31+
SkipGetTargetFrameworkProperties="true" />
32+
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\StartRequestDelegateUrlApp\StartRequestDelegateUrlApp.csproj"
33+
Private="false"
34+
ReferenceOutputAssembly="false"
35+
SkipGetTargetFrameworkProperties="true" />
36+
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\StartRouteBuilderUrlApp\StartRouteBuilderUrlApp.csproj"
37+
Private="false"
38+
ReferenceOutputAssembly="false"
39+
SkipGetTargetFrameworkProperties="true" />
40+
<ProjectReference Include="$(RepoRoot)src\DefaultBuilder\testassets\StartWithIApplicationBuilderUrlApp\StartWithIApplicationBuilderUrlApp.csproj"
41+
Private="false"
42+
ReferenceOutputAssembly="false"
43+
SkipGetTargetFrameworkProperties="true" />
2644

2745
<Reference Include="Microsoft.AspNetCore" />
2846
</ItemGroup>

‎src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020

2121
<ItemGroup>
2222
<Reference Include="Microsoft.Extensions.FileProviders.Abstractions" />
23-
<ProjectReference Include="..\..\Manifest.MSBuildTask\src\Microsoft.Extensions.FileProviders.Embedded.Manifest.Task.csproj" PrivateAssets="All" ReferenceOutputAssembly="false" />
23+
<ProjectReference Include="..\..\Manifest.MSBuildTask\src\Microsoft.Extensions.FileProviders.Embedded.Manifest.Task.csproj"
24+
Private="false"
25+
ReferenceOutputAssembly="false" />
2426
</ItemGroup>
2527

2628
<ItemGroup>

‎src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -63,20 +63,17 @@ This package is an internal implementation of the .NET Core SDK and is not meant
6363
<ItemGroup>
6464
<!-- Note: do not add _TransitiveExternalAspNetCoreAppReference to this list. This is intentionally not listed as a direct package reference. -->
6565
<Reference Include="@(AspNetCoreAppReference);@(AspNetCoreAppReferenceAndPackage);@(ExternalAspNetCoreAppReference)" />
66-
<ProjectReference Include="..\..\AspNetCoreAnalyzers\src\Analyzers\Microsoft.AspNetCore.App.Analyzers.csproj"
67-
ReferenceOutputAssembly="false"
68-
SkipGetTargetFrameworkProperties="true"
69-
UndefineProperties="TargetFramework;TargetFrameworks;RuntimeIdentifier;PublishDir" />
66+
67+
<!-- Also ensure an Microsoft.AspNetCore.App.Analyzers build. -->
7068
<ProjectReference Include="..\..\AspNetCoreAnalyzers\src\CodeFixes\Microsoft.AspNetCore.App.CodeFixes.csproj"
69+
Private="false"
70+
ReferenceOutputAssembly="false" />
71+
72+
<!-- Enforce build order. Targeting pack needs to bundle analyzers and information about the runtime. -->
73+
<ProjectReference Include="..\..\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
74+
Private="false"
7175
ReferenceOutputAssembly="false"
72-
SkipGetTargetFrameworkProperties="true"
73-
UndefineProperties="TargetFramework;TargetFrameworks;RuntimeIdentifier;PublishDir" />
74-
75-
<!-- Enforce build order. Targeting pack needs to bundle information about the runtime. -->
76-
<ProjectReference Include="..\..\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj">
77-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
78-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
79-
</ProjectReference>
76+
SkipGetTargetFrameworkProperties="true" />
8077
</ItemGroup>
8178

8279
<Import Project="Sdk.targets" Sdk="Microsoft.NET.Sdk" />

‎src/Framework/AspNetCoreAnalyzers/test/Microsoft.AspNetCore.App.Analyzers.Test.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
</ItemGroup>
1212

1313
<ItemGroup>
14-
<ProjectReference Include="..\src\Analyzers\Microsoft.AspNetCore.App.Analyzers.csproj" />
14+
<!-- Also bring in Microsoft.AspNetCore.App.Analyzers. -->
1515
<ProjectReference Include="..\src\CodeFixes\Microsoft.AspNetCore.App.CodeFixes.csproj" />
16+
1617
<ProjectReference Include="$(RepoRoot)src\Analyzers\Microsoft.AspNetCore.Analyzer.Testing\src\Microsoft.AspNetCore.Analyzer.Testing.csproj" />
1718
<Reference Include="Microsoft.AspNetCore" />
1819
<Reference Include="Microsoft.AspNetCore.Mvc" />

‎src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,16 @@
7171
</ItemGroup>
7272

7373
<ItemGroup>
74-
<ProjectReference Include="..\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj"
75-
Condition=" $(IsTargetingPackBuilding) ">
76-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
77-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
78-
</ProjectReference>
79-
<ProjectReference Include="..\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
80-
Condition=" !$(IsTargetingPackBuilding) ">
81-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
82-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
83-
</ProjectReference>
74+
<ProjectReference Include="$(RepoRoot)\src\Framework\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj"
75+
Condition=" $(IsTargetingPackBuilding) "
76+
Private="false"
77+
ReferenceOutputAssembly="false"
78+
SkipGetTargetFrameworkProperties="true" />
79+
<ProjectReference Include="$(RepoRoot)\src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
80+
Condition=" !$(IsTargetingPackBuilding) "
81+
Private="false"
82+
ReferenceOutputAssembly="false"
83+
SkipGetTargetFrameworkProperties="true" />
8484
</ItemGroup>
8585

8686
<Target Name="GenerateTestData" BeforeTargets="GetAssemblyAttributes" DependsOnTargets="InitializeSourceControlInformation">

‎src/Hosting/test/FunctionalTests/Microsoft.AspNetCore.Hosting.FunctionalTests.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,10 @@
1717

1818
<ItemGroup>
1919
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
20-
<ProjectReference Include="$(RepoRoot)src\Hosting\test\testassets\IStartupInjectionAssemblyName\IStartupInjectionAssemblyName.csproj" ReferenceOutputAssemblies="false" />
20+
<ProjectReference Include="$(RepoRoot)src\Hosting\test\testassets\IStartupInjectionAssemblyName\IStartupInjectionAssemblyName.csproj"
21+
Private="false"
22+
ReferenceOutputAssembly="false"
23+
SkipGetTargetFrameworkProperties="true" />
2124

2225
<Reference Include="Microsoft.AspNetCore.Hosting" />
2326
<Reference Include="Microsoft.Extensions.Logging.Console" />

‎src/Installers/Debian/Runtime/Debian.Runtime.debproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
</PropertyGroup>
2525

2626
<ItemGroup>
27-
<ProjectReference Include="..\..\..\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj">
28-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
29-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
30-
</ProjectReference>
27+
<ProjectReference Include="..\..\..\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
28+
Private="false"
29+
ReferenceOutputAssembly="false"
30+
SkipGetTargetFrameworkProperties="true" />
3131
</ItemGroup>
3232

3333
<Import Project="$(MSBuildToolsPath)\Microsoft.Common.targets" />

‎src/Installers/Debian/TargetingPack/Debian.TargetingPack.debproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
</PropertyGroup>
2929

3030
<ItemGroup>
31-
<ProjectReference Include="..\..\..\Framework\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj">
32-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
33-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
34-
</ProjectReference>
31+
<ProjectReference Include="..\..\..\Framework\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj"
32+
Private="false"
33+
ReferenceOutputAssembly="false"
34+
SkipGetTargetFrameworkProperties="true" />
3535
</ItemGroup>
3636

3737
<Import Project="$(MSBuildToolsPath)\Microsoft.Common.targets" />

‎src/Installers/Rpm/Rpm.Runtime.Common.targets

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@
2020
</PropertyGroup>
2121

2222
<ItemGroup>
23-
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj">
24-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
25-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
26-
</ProjectReference>
23+
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
24+
Private="false"
25+
ReferenceOutputAssembly="false"
26+
SkipGetTargetFrameworkProperties="true" />
2727

2828
<InstallerOwnedDirectory Include="$(RpmPackageInstallRoot)shared/Microsoft.AspNetCore.App" />
2929
<RpmDependency Include="dotnet-runtime-$(MicrosoftNETCoreAppRuntimeMajorMinorVersion)" Version="$(MicrosoftNETCoreAppRuntimeVersion.Split('-')[0])" />

‎src/Installers/Rpm/TargetingPack/Rpm.TargetingPack.rpmproj

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@
1717
</PropertyGroup>
1818

1919
<ItemGroup>
20-
<ProjectReference Include="..\..\..\Framework\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj">
21-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
22-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
23-
</ProjectReference>
20+
<ProjectReference Include="..\..\..\Framework\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj"
21+
Private="false"
22+
ReferenceOutputAssembly="false"
23+
SkipGetTargetFrameworkProperties="true" />
2424

2525
<InstallerOwnedDirectory Include="$(RpmPackageInstallRoot)packs/$(TargetingPackName)/" />
2626
<RpmDependency Include="dotnet-targeting-pack-$(MicrosoftNETCoreAppRefMajorMinorVersion)" Version="$(MicrosoftNETCoreAppRefVersion.Split('-')[0])" />
@@ -33,7 +33,7 @@
3333
<CblMarinerTargetFileName>$(TargetingPackInstallerBaseName)-$(TargetingPackVersion)-cm.1.rpm</CblMarinerTargetFileName>
3434
<TargetPath>$(InstallersOutputPath)$(TargetFileName)</TargetPath>
3535
<CblMarinerTargetPath>$(InstallersOutputPath)$(CblMarinerTargetFileName)</CblMarinerTargetPath>
36-
36+
3737
<PackageVersion>$(TargetingPackVersionPrefix)</PackageVersion>
3838

3939
<!-- Set package revision to '1' for RTM releases, but include the build number in pre-releases -->

‎src/Installers/Windows/WindowsHostingBundle/WindowsHostingBundle.wixproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,10 @@
5454
<Private>True</Private>
5555
<DoNotHarvest>true</DoNotHarvest>
5656
</ProjectReference>
57-
<ProjectReference Include="..\SharedFrameworkBundle\SharedFrameworkBundle.wixproj">
58-
<Private>True</Private>
59-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
60-
</ProjectReference>
57+
<ProjectReference Include="..\SharedFrameworkBundle\SharedFrameworkBundle.wixproj"
58+
Private="false"
59+
ReferenceOutputAssembly="false"
60+
SkipGetTargetFrameworkProperties="true" />
6161
</ItemGroup>
6262

6363
<Import Project="Product.targets" />

‎src/Mvc/Mvc.Testing/src/Microsoft.AspNetCore.Mvc.Testing.csproj

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@
1919
</ItemGroup>
2020

2121
<ItemGroup>
22-
<Reference
23-
Include="Microsoft.AspNetCore.Mvc.Testing.Tasks"
24-
ReferenceOutputAssembly="false"
25-
SkipGetTargetFrameworkProperties="true"
26-
UndefineProperties="TargetFramework;TargetFrameworks;RuntimeIdentifier;PublishDir" />
22+
<Reference Include="Microsoft.AspNetCore.Mvc.Testing.Tasks"
23+
Private="false"
24+
ReferenceOutputAssembly="false"
25+
SkipGetTargetFrameworkProperties="true" />
2726
</ItemGroup>
2827

2928
<ItemGroup>

‎src/ProjectTemplates/BlazorTemplates.Tests/BlazorTemplates.Tests.csproj

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,21 @@
4545
<Reference Include="Anglesharp" />
4646
<Reference Include="PlaywrightSharp" Condition="'$(TargetOsName)' != 'linux-musl'" />
4747
<Reference Include="PlaywrightSharp" ExcludeAssets="build" Condition="'$(TargetOsName)' == 'linux-musl'" />
48-
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj">
49-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
50-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
51-
</ProjectReference>
48+
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
49+
Private="false"
50+
ReferenceOutputAssembly="false"
51+
SkipGetTargetFrameworkProperties="true" />
52+
5253
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
5354
<ProjectReference Include="$(RepoRoot)src\Shared\BrowserTesting\src\Microsoft.AspNetCore.BrowserTesting.csproj" />
54-
<ProjectReference Include="../testassets/DotNetToolsInstaller/DotNetToolsInstaller.csproj" ReferenceOutputAssembly="false" />
55-
<ProjectReference Include="../Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj" ReferenceOutputAssembly="false" />
55+
<ProjectReference Include="../testassets/DotNetToolsInstaller/DotNetToolsInstaller.csproj"
56+
Private="false"
57+
ReferenceOutputAssembly="false"
58+
SkipGetTargetFrameworkProperties="true" />
59+
<ProjectReference Include="../Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj"
60+
Private="false"
61+
ReferenceOutputAssembly="false"
62+
SkipGetTargetFrameworkProperties="true" />
5663
</ItemGroup>
5764

5865
<!-- Shared testing infrastructure for running E2E template tests -->

‎src/ProjectTemplates/test/ProjectTemplates.Tests.csproj

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,33 @@
4646

4747
<ItemGroup>
4848
<Reference Include="AngleSharp" />
49-
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj">
50-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
51-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
52-
</ProjectReference>
49+
<ProjectReference Include="$(RepoRoot)src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
50+
Private="false"
51+
ReferenceOutputAssembly="false"
52+
SkipGetTargetFrameworkProperties="true" />
53+
5354
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
5455
<ProjectReference Include="$(RepoRoot)src\Shared\BrowserTesting\src\Microsoft.AspNetCore.BrowserTesting.csproj" />
55-
<ProjectReference Include="../testassets/DotNetToolsInstaller/DotNetToolsInstaller.csproj" ReferenceOutputAssembly="false" />
56-
<ProjectReference Include="../Web.Client.ItemTemplates/Microsoft.DotNet.Web.Client.ItemTemplates.csproj" ReferenceOutputAssembly="false" />
57-
<ProjectReference Include="../Web.ItemTemplates/Microsoft.DotNet.Web.ItemTemplates.csproj" ReferenceOutputAssembly="false" />
58-
<ProjectReference Include="../Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj" ReferenceOutputAssembly="false" />
59-
<ProjectReference Include="$(RepoRoot)src\submodules\spa-templates\src\Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj" ReferenceOutputAssembly="false" />
56+
<ProjectReference Include="../testassets/DotNetToolsInstaller/DotNetToolsInstaller.csproj"
57+
Private="false"
58+
ReferenceOutputAssembly="false"
59+
SkipGetTargetFrameworkProperties="true" />
60+
<ProjectReference Include="../Web.Client.ItemTemplates/Microsoft.DotNet.Web.Client.ItemTemplates.csproj"
61+
Private="false"
62+
ReferenceOutputAssembly="false"
63+
SkipGetTargetFrameworkProperties="true" />
64+
<ProjectReference Include="../Web.ItemTemplates/Microsoft.DotNet.Web.ItemTemplates.csproj"
65+
Private="false"
66+
ReferenceOutputAssembly="false"
67+
SkipGetTargetFrameworkProperties="true" />
68+
<ProjectReference Include="../Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj"
69+
Private="false"
70+
ReferenceOutputAssembly="false"
71+
SkipGetTargetFrameworkProperties="true" />
72+
<ProjectReference Include="$(RepoRoot)src\submodules\spa-templates\src\Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj"
73+
Private="false"
74+
ReferenceOutputAssembly="false"
75+
SkipGetTargetFrameworkProperties="true" />
6076
</ItemGroup>
6177

6278
<PropertyGroup>

‎src/Razor/tools/Microsoft.AspNetCore.Razor.Internal.Transport/Microsoft.AspNetCore.Razor.Internal.Transport.csproj

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,26 @@
1010

1111
<ItemGroup>
1212
<!-- Don't bother passing the following assemblies to the (ignored) build or copying the files into our bin. -->
13-
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" ReferenceOutputAssembly="false" />
14-
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X" ReferenceOutputAssembly="false" />
15-
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X" ReferenceOutputAssembly="false" />
16-
<Reference Include="Microsoft.AspNetCore.Razor.Language" ReferenceOutputAssembly="false" />
17-
<Reference Include="Microsoft.CodeAnalysis.Razor" ReferenceOutputAssembly="false" />
13+
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions"
14+
Private="false"
15+
ReferenceOutputAssembly="false"
16+
SkipGetTargetFrameworkProperties="true" />
17+
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X"
18+
Private="false"
19+
ReferenceOutputAssembly="false"
20+
SkipGetTargetFrameworkProperties="true" />
21+
<Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X"
22+
Private="false"
23+
ReferenceOutputAssembly="false"
24+
SkipGetTargetFrameworkProperties="true" />
25+
<Reference Include="Microsoft.AspNetCore.Razor.Language"
26+
Private="false"
27+
ReferenceOutputAssembly="false"
28+
SkipGetTargetFrameworkProperties="true" />
29+
<Reference Include="Microsoft.CodeAnalysis.Razor"
30+
Private="false"
31+
ReferenceOutputAssembly="false"
32+
SkipGetTargetFrameworkProperties="true" />
1833

1934
<Content Include="$(ArtifactsDir)bin\Microsoft.AspNetCore.Mvc.Razor.Extensions\$(Configuration)\netstandard2.0\Microsoft.AspNetCore.Mvc.Razor.Extensions.pdb" PackagePath="pdb" />
2035
<Content Include="$(ArtifactsDir)bin\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X\$(Configuration)\netstandard2.0\Microsoft.AspNetCore.Mvc.Razor.Extensions.Version1_X.pdb" PackagePath="pdb" />

‎src/Servers/IIS/IIS/perf/Microbenchmarks/IIS.Microbenchmarks.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,10 @@
2727
<ItemGroup>
2828
<ProjectReference Include="..\..\test\IISExpress.FunctionalTests\IISExpress.FunctionalTests.csproj" />
2929
<ProjectReference Include="..\..\test\IIS.Tests\IIS.Tests.csproj" />
30-
<ProjectReference Include="..\..\test\testassets\InProcessWebSite\InProcessWebSite.csproj">
31-
<ReferenceOutputAssembly>False</ReferenceOutputAssembly>
32-
</ProjectReference>
30+
<ProjectReference Include="..\..\test\testassets\InProcessWebSite\InProcessWebSite.csproj"
31+
Private="false"
32+
ReferenceOutputAssembly="false"
33+
SkipGetTargetFrameworkProperties="true" />
3334
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
3435
</ItemGroup>
3536

‎src/Servers/IIS/IIS/test/IIS.FunctionalTests/IIS.FunctionalTests.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@
1818

1919
<ItemGroup>
2020
<ProjectReference Include="..\testassets\IIS.Common.TestLib\IIS.Common.TestLib.csproj" />
21-
<ProjectReference Include="..\testassets\InProcessWebSite\InProcessWebSite.csproj">
22-
<ReferenceOutputAssembly>False</ReferenceOutputAssembly>
23-
</ProjectReference>
21+
<ProjectReference Include="..\testassets\InProcessWebSite\InProcessWebSite.csproj"
22+
Private="false"
23+
ReferenceOutputAssembly="false"
24+
SkipGetTargetFrameworkProperties="true" />
2425
</ItemGroup>
2526

2627
<ItemGroup>

‎src/Servers/IIS/IIS/test/IIS.NewHandler.FunctionalTests/IIS.NewHandler.FunctionalTests.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@
2828

2929
<ItemGroup>
3030
<ProjectReference Include="..\testassets\IIS.Common.TestLib\IIS.Common.TestLib.csproj" />
31-
<ProjectReference Include="..\testassets\InProcessWebSite\InProcessWebSite.csproj">
32-
<ReferenceOutputAssembly>False</ReferenceOutputAssembly>
33-
</ProjectReference>
31+
<ProjectReference Include="..\testassets\InProcessWebSite\InProcessWebSite.csproj"
32+
Private="false"
33+
ReferenceOutputAssembly="false"
34+
SkipGetTargetFrameworkProperties="true" />
3435
</ItemGroup>
3536

3637
<ItemGroup>

‎src/Servers/IIS/IIS/test/IIS.NewShim.FunctionalTests/IIS.NewShim.FunctionalTests.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@
1515
<ProjectReference Include="..\testassets\IIS.Common.TestLib\IIS.Common.TestLib.csproj" />
1616
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
1717

18-
<ProjectReference Include="..\testassets\InProcessNewShimWebSite\InProcessNewShimWebSite.csproj">
19-
<ReferenceOutputAssembly>False</ReferenceOutputAssembly>
20-
</ProjectReference>
18+
<ProjectReference Include="..\testassets\InProcessNewShimWebSite\InProcessNewShimWebSite.csproj"
19+
Private="false"
20+
ReferenceOutputAssembly="false"
21+
SkipGetTargetFrameworkProperties="true" />
2122
</ItemGroup>
2223

2324
<ItemGroup>

‎src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/IISExpress.FunctionalTests.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,10 @@
1818
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
1919
<ProjectReference Include="$(RepoRoot)src\Servers\IIS\IntegrationTesting.IIS\src\Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj" />
2020

21-
<ProjectReference Include="..\testassets\InProcessWebSite\InProcessWebSite.csproj">
22-
<ReferenceOutputAssembly>False</ReferenceOutputAssembly>
23-
</ProjectReference>
21+
<ProjectReference Include="..\testassets\InProcessWebSite\InProcessWebSite.csproj"
22+
Private="false"
23+
ReferenceOutputAssembly="false"
24+
SkipGetTargetFrameworkProperties="true" />
2425
</ItemGroup>
2526

2627
<ItemGroup>

‎src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@
5555
</Target>
5656

5757
<ItemGroup>
58-
<ProjectReference Include="$(RepoRoot)src\Servers\IIS\IIS\test\testassets\TestTasks\TestTasks.csproj" ReferenceOutputAssembly="false" />
58+
<ProjectReference Include="$(RepoRoot)src\Servers\IIS\IIS\test\testassets\TestTasks\TestTasks.csproj"
59+
Private="false"
60+
ReferenceOutputAssembly="false"
61+
SkipGetTargetFrameworkProperties="true" />
5962
<ProjectReference Include="$(RepoRoot)src\Hosting\Server.IntegrationTesting\src\Microsoft.AspNetCore.Server.IntegrationTesting.csproj" />
6063

6164
<Reference Include="Microsoft.NETCore.Windows.ApiSets" />

‎src/Servers/test/FunctionalTests/ServerComparison.FunctionalTests.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616

1717
<ItemGroup>
1818
<ProjectReference Include="$(RepoRoot)src\Servers\IIS\IntegrationTesting.IIS\src\Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj" />
19-
<ProjectReference Include="$(RepoRoot)src\Servers\testassets\ServerComparison.TestSites\ServerComparison.TestSites.csproj" ReferenceOutputAssemblies="false" />
19+
<ProjectReference Include="$(RepoRoot)src\Servers\testassets\ServerComparison.TestSites\ServerComparison.TestSites.csproj"
20+
Private="false"
21+
ReferenceOutputAssembly="false"
22+
SkipGetTargetFrameworkProperties="true" />
23+
2024
<Reference Include="Microsoft.Extensions.Logging" />
2125
<Reference Include="Microsoft.Net.Http.Headers" />
2226
<Reference Include="Serilog.Extensions.Logging" />

‎src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,16 @@
5353
<ItemGroup>
5454
<Content Include="applicationHost.xdt" />
5555
<Content Include="scmApplicationHost.xdt" />
56-
<Content Include="$(OutputPath)\Microsoft.Web.Xdt.Extensions.dll" PackagePath="content" />
56+
<Content Include="$(ArtifactsBinDir)Microsoft.Web.Xdt.Extensions\$(Configuration)\$(DefaultNetFxTargetFramework)\Microsoft.Web.Xdt.Extensions.dll"
57+
Condition="EXISTS('$(ArtifactsBinDir)Microsoft.Web.Xdt.Extensions\$(Configuration)\$(DefaultNetFxTargetFramework)\Microsoft.Web.Xdt.Extensions.dll')"
58+
PackagePath="content" />
5759
</ItemGroup>
5860

5961
<ItemGroup>
60-
<Reference Include="Microsoft.Web.Xdt.Extensions" PrivateAssets="All" />
62+
<Reference Include="Microsoft.Web.Xdt.Extensions"
63+
Private="false"
64+
ReferenceOutputAssembly="false"
65+
SkipGetTargetFrameworkProperties="true" />
6166
</ItemGroup>
6267

6368
<!--

‎src/SiteExtensions/LoggingBranch/LB.csproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,15 @@
2525
<HostingStartupRuntimeStoreTargets Include="$(DefaultNetCoreTargetFramework)" Runtime="$(TargetRuntimeIdentifier)" />
2626

2727
<ProjectReference Include="..\..\Framework\App.Ref\src\Microsoft.AspNetCore.App.Ref.csproj"
28-
Condition=" $(IsTargetingPackBuilding) ">
29-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
30-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
31-
</ProjectReference>
28+
Condition=" $(IsTargetingPackBuilding) "
29+
Private="false"
30+
ReferenceOutputAssembly="false"
31+
SkipGetTargetFrameworkProperties="true" />
3232
<ProjectReference Include="..\..\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
33-
Condition=" !$(IsTargetingPackBuilding) ">
34-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
35-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
36-
</ProjectReference>
33+
Condition=" !$(IsTargetingPackBuilding) "
34+
Private="false"
35+
ReferenceOutputAssembly="false"
36+
SkipGetTargetFrameworkProperties="true" />
3737
</ItemGroup>
3838

3939
<!-- Cannot assume this project and Microsoft.AspNetCore.AzureAppServices.HostingStartup have the same package version. -->

‎src/SiteExtensions/Runtime/Microsoft.AspNetCore.Runtime.SiteExtension.pkgproj

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,16 @@
2828
</ItemGroup>
2929

3030
<ItemGroup>
31-
<ProjectReference Include="..\Microsoft.Web.Xdt.Extensions\src\Microsoft.Web.Xdt.Extensions.csproj" PrivateAssets="All" ReferenceOutputAssembly="False"/>
31+
<ProjectReference Include="..\Microsoft.Web.Xdt.Extensions\src\Microsoft.Web.Xdt.Extensions.csproj"
32+
Private="false"
33+
ReferenceOutputAssembly="false"
34+
SkipGetTargetFrameworkProperties="true" />
3235

3336
<!-- Make sure redist folder is built and ready -->
34-
<ProjectReference Include="..\..\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj">
35-
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>
36-
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
37-
</ProjectReference>
37+
<ProjectReference Include="..\..\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj"
38+
Private="false"
39+
ReferenceOutputAssembly="false"
40+
SkipGetTargetFrameworkProperties="true" />
3841

3942
<NativeProjectReference Include="$(RepoRoot)src\Servers\IIS\AspNetCoreModuleV2\AspNetCore\AspNetCore.vcxproj" Platform="$(TargetArchitecture)" />
4043
<NativeProjectReference Include="$(RepoRoot)src\Servers\IIS\AspNetCoreModuleV2\OutOfProcessRequestHandler\OutOfProcessRequestHandler.vcxproj" HandlerPath="2.0.0" Platform="$(TargetArchitecture)" />

‎src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,16 @@
1919
because publish output matches what was built.
2020
-->
2121
<Reference Include="dotnet-getdocument"
22-
Targets="Publish"
23-
ReferenceOutputAssembly="false"
24-
SkipGetTargetFrameworkProperties="true"
25-
UndefineProperties="TargetFramework;TargetFrameworks;RuntimeIdentifier;PublishDir" />
26-
<Reference Include="GetDocument.Insider" ReferenceOutputAssembly="false">
27-
<Targets Condition=" '$(TargetFramework)' == 'netcoreapp2.1' ">Publish</Targets>
22+
Condition=" '$(TargetFramework)' == 'netcoreapp2.1' "
23+
Targets="Publish"
24+
Private="false"
25+
ReferenceOutputAssembly="false"
26+
SkipGetTargetFrameworkProperties="true" />
27+
<Reference Include="GetDocument.Insider"
28+
Private="false"
29+
ReferenceOutputAssembly="false"
30+
SkipGetTargetFrameworkProperties="true">
31+
<Targets Condition=" '$(TargetFramework)' == 'netcoreapp2.1' ">Publish</Targets>
2832
</Reference>
2933
</ItemGroup>
3034

0 commit comments

Comments
 (0)
Please sign in to comment.