PR feedback

Author: JamesNK

src/Http/Http/src/BindingAddress.cs

@@ -11,7 +11,7 @@ namespace Microsoft.AspNetCore.Http;
 public class BindingAddress
 {
     private const string UnixPipeHostPrefix = "unix:/";
-    private const string NamedPipeHostPrefix = "pipe:";
+    private const string NamedPipeHostPrefix = "pipe:/";
 
     private BindingAddress(string host, string pathBase, int port, string scheme)
     {
@@ -61,7 +61,7 @@ public BindingAddress()
     /// <summary>
     /// Gets a value that determines if this instance represents a named pipe.
     /// <para>
-    /// Returns <see langword="true"/> if <see cref="Host"/> starts with <c>pipe:</c> prefix.
+    /// Returns <see langword="true"/> if <see cref="Host"/> starts with <c>pipe:/</c> prefix.
     /// </para>
     /// </summary>
     public bool IsNamedPipe => Host.StartsWith(NamedPipeHostPrefix, StringComparison.Ordinal);
@@ -83,9 +83,9 @@ public string UnixPipePath
     }
 
     /// <summary>
-    /// Gets the named pipe path if this instance represents a named pipe.
+    /// Gets the named pipe name if this instance represents a named pipe.
     /// </summary>
-    public string NamedPipePath
+    public string NamedPipeName
     {
         get
         {
@@ -94,7 +94,7 @@ public string NamedPipePath
                 throw new InvalidOperationException("Binding address is not a named pipe.");
             }
 
-            return GetNamedPipePath(Host);
+            return GetNamedPipeName(Host);
         }
     }
 
@@ -109,7 +109,7 @@ private static string GetUnixPipePath(string host)
         return host.Substring(unixPipeHostPrefixLength);
     }
 
-    private static string GetNamedPipePath(string host) => host.Substring(NamedPipeHostPrefix.Length);
+    private static string GetNamedPipeName(string host) => host.Substring(NamedPipeHostPrefix.Length);
 
     /// <inheritdoc />
     public override string ToString()
@@ -248,11 +248,6 @@ public static BindingAddress Parse(string address)
             throw new FormatException($"Invalid url, unix socket path must be absolute: '{address}'");
         }
 
-        if (isNamedPipe && GetNamedPipePath(host).Contains('\\'))
-        {
-            throw new FormatException($"Invalid url, pipe name must not contain backslashes: '{address}'");
-        }
-
         string pathBase;
         if (address[address.Length - 1] == '/')
         {

src/Http/Http/src/PublicAPI.Unshipped.txt

@@ -1,5 +1,5 @@
 #nullable enable
 *REMOVED*Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature! priorFeature) -> void
 Microsoft.AspNetCore.Http.BindingAddress.IsNamedPipe.get -> bool
-Microsoft.AspNetCore.Http.BindingAddress.NamedPipePath.get -> string!
+Microsoft.AspNetCore.Http.BindingAddress.NamedPipeName.get -> string!
 Microsoft.AspNetCore.Http.StreamResponseBodyFeature.StreamResponseBodyFeature(System.IO.Stream! stream, Microsoft.AspNetCore.Http.Features.IHttpResponseBodyFeature? priorFeature) -> void

src/Servers/Kestrel/Core/src/Internal/AddressBinder.cs

@@ -122,7 +122,7 @@ internal static ListenOptions ParseAddress(string address, out bool https)
         }
         else if (parsedAddress.IsNamedPipe)
         {
-            options = new ListenOptions(new NamedPipeEndPoint(parsedAddress.NamedPipePath));
+            options = new ListenOptions(new NamedPipeEndPoint(parsedAddress.NamedPipeName));
         }
         else if (string.Equals(parsedAddress.Host, "localhost", StringComparison.OrdinalIgnoreCase))
         {

src/Servers/Kestrel/Core/test/AddressBinderTests.cs

@@ -78,29 +78,40 @@ public void ParseAddressLocalhost()
         Assert.False(https);
     }
 
+    [Fact]
+    public void ParseAddress_HasPipeNoSlash()
+    {
+        var listenOptions = AddressBinder.ParseAddress("http://pipe:8080", out var https);
+        Assert.IsType<IPEndPoint>(listenOptions.EndPoint);
+        Assert.Equal(8080, listenOptions.IPEndPoint.Port);
+        Assert.False(https);
+    }
+
     [Fact]
     public void ParseAddressNamedPipe()
     {
-        var listenOptions = AddressBinder.ParseAddress("http://pipe:HelloWorld", out var https);
+        var listenOptions = AddressBinder.ParseAddress("http://pipe:/HelloWorld", out var https);
         Assert.IsType<NamedPipeEndPoint>(listenOptions.EndPoint);
         Assert.Equal("HelloWorld", listenOptions.PipeName);
         Assert.False(https);
     }
 
     [Fact]
-    public void ParseAddressNamedPipe_ForwardSlashes()
+    public void ParseAddressNamedPipe_BackSlashes()
     {
-        var listenOptions = AddressBinder.ParseAddress("http://pipe:/tmp/kestrel-test.sock", out var https);
+        var listenOptions = AddressBinder.ParseAddress(@"http://pipe:/LOCAL\HelloWorld", out var https);
         Assert.IsType<NamedPipeEndPoint>(listenOptions.EndPoint);
-        Assert.Equal("/tmp/kestrel-test.sock", listenOptions.PipeName);
+        Assert.Equal(@"LOCAL\HelloWorld", listenOptions.PipeName);
         Assert.False(https);
     }
 
     [Fact]
-    public void ParseAddressNamedPipe_ErrorFromBackslash()
+    public void ParseAddressNamedPipe_ForwardSlashes()
     {
-        var ex = Assert.Throws<FormatException>(() => AddressBinder.ParseAddress(@"http://pipe:this\is\invalid", out var https));
-        Assert.Equal(@"Invalid url, pipe name must not contain backslashes: 'http://pipe:this\is\invalid'", ex.Message);
+        var listenOptions = AddressBinder.ParseAddress("http://pipe://tmp/kestrel-test.sock", out var https);
+        Assert.IsType<NamedPipeEndPoint>(listenOptions.EndPoint);
+        Assert.Equal("/tmp/kestrel-test.sock", listenOptions.PipeName);
+        Assert.False(https);
     }
 
     [ConditionalFact]