Skip to content

Commit e7e725d

Browse files
committed
Mark experimental
1 parent e51e9d2 commit e7e725d

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/ShimOptions.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "Environment.h"
99

1010
#define CS_ASPNETCORE_HANDLER_VERSION L"handlerVersion"
11-
#define CS_ASPNETCORE_SHADOW_COPY L"enableShadowCopy"
11+
#define CS_ASPNETCORE_SHADOW_COPY L"experimentalEnableShadowCopy"
1212
#define CS_ASPNETCORE_SHADOW_COPY_DIRECTORY L"shadowCopyDirectory"
1313
#define CS_ASPNETCORE_CLEAN_SHADOW_DIRECTORY_CONTENT L"cleanShadowCopyDirectory"
1414

@@ -41,14 +41,14 @@ ShimOptions::ShimOptions(const ConfigurationSource &configurationSource) :
4141
m_strHandlerVersion = find_element(handlerSettings, CS_ASPNETCORE_HANDLER_VERSION).value_or(std::wstring());
4242
}
4343

44-
auto enableShadowCopyElement = find_element(handlerSettings, CS_ASPNETCORE_SHADOW_COPY).value_or(std::wstring());
45-
m_fEnableShadowCopying = equals_ignore_case(L"true", enableShadowCopyElement);
44+
auto experimentalEnableShadowCopyElement = find_element(handlerSettings, CS_ASPNETCORE_SHADOW_COPY).value_or(std::wstring());
45+
m_fexperimentalEnableShadowCopying = equals_ignore_case(L"true", experimentalEnableShadowCopyElement);
4646

4747
auto cleanShadowCopyDirectory = find_element(handlerSettings, CS_ASPNETCORE_CLEAN_SHADOW_DIRECTORY_CONTENT).value_or(std::wstring());
4848
m_fCleanShadowCopyDirectory = equals_ignore_case(L"true", cleanShadowCopyDirectory);
4949

5050
m_strShadowCopyingDirectory = find_element(handlerSettings, CS_ASPNETCORE_SHADOW_COPY_DIRECTORY)
51-
.value_or(m_fEnableShadowCopying ? L"ShadowCopyDirectory" : std::wstring());
51+
.value_or(m_fexperimentalEnableShadowCopying ? L"ShadowCopyDirectory" : std::wstring());
5252

5353
m_strProcessPath = section->GetRequiredString(CS_ASPNETCORE_PROCESS_EXE_PATH);
5454
m_strArguments = section->GetString(CS_ASPNETCORE_PROCESS_ARGUMENTS).value_or(CS_ASPNETCORE_PROCESS_ARGUMENTS_DEFAULT);

src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/ShimOptions.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class ShimOptions: NonCopyable
6868
bool
6969
QueryShadowCopyEnabled() const noexcept
7070
{
71-
return m_fEnableShadowCopying;
71+
return m_fexperimentalEnableShadowCopying;
7272
}
7373

7474
bool
@@ -94,7 +94,7 @@ class ShimOptions: NonCopyable
9494
bool m_fStdoutLogEnabled;
9595
bool m_fDisableStartupPage;
9696
bool m_fShowDetailedErrors;
97-
bool m_fEnableShadowCopying;
97+
bool m_fexperimentalEnableShadowCopying;
9898
bool m_fCleanShadowCopyDirectory;
9999
std::wstring m_strShadowCopyingDirectory;
100100
};

src/Servers/IIS/IIS/test/IIS.FunctionalTests/ShadowCopyTests.cs

+5-5
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public async Task ShadowCopyDoesNotLockFiles()
2323
{
2424
using var directory = TempDirectory.Create();
2525
var deploymentParameters = Fixture.GetBaseDeploymentParameters();
26-
deploymentParameters.HandlerSettings["enableShadowCopy"] = "true";
26+
deploymentParameters.HandlerSettings["experimentalEnableShadowCopy"] = "true";
2727
deploymentParameters.HandlerSettings["shadowCopyDirectory"] = directory.DirectoryPath;
2828

2929
var deploymentResult = await DeployAsync(deploymentParameters);
@@ -50,7 +50,7 @@ public async Task ShadowCopyRelativeInSameDirectoryWorks()
5050
{
5151
var directoryName = Path.GetRandomFileName();
5252
var deploymentParameters = Fixture.GetBaseDeploymentParameters();
53-
deploymentParameters.HandlerSettings["enableShadowCopy"] = "true";
53+
deploymentParameters.HandlerSettings["experimentalEnableShadowCopy"] = "true";
5454
deploymentParameters.HandlerSettings["shadowCopyDirectory"] = directoryName;
5555

5656
var deploymentResult = await DeployAsync(deploymentParameters);
@@ -81,7 +81,7 @@ public async Task ShadowCopyRelativeOutsideDirectoryWorks()
8181
{
8282
using var directory = TempDirectory.Create();
8383
var deploymentParameters = Fixture.GetBaseDeploymentParameters();
84-
deploymentParameters.HandlerSettings["enableShadowCopy"] = "true";
84+
deploymentParameters.HandlerSettings["experimentalEnableShadowCopy"] = "true";
8585
deploymentParameters.HandlerSettings["shadowCopyDirectory"] = $"..\\{directory.DirectoryInfo.Name}";
8686
deploymentParameters.ApplicationPath = directory.DirectoryPath;
8787

@@ -115,7 +115,7 @@ public async Task ShadowCopySingleFileChangedWorks()
115115
{
116116
using var directory = TempDirectory.Create();
117117
var deploymentParameters = Fixture.GetBaseDeploymentParameters();
118-
deploymentParameters.HandlerSettings["enableShadowCopy"] = "true";
118+
deploymentParameters.HandlerSettings["experimentalEnableShadowCopy"] = "true";
119119
deploymentParameters.HandlerSettings["shadowCopyDirectory"] = directory.DirectoryPath;
120120

121121
var deploymentResult = await DeployAsync(deploymentParameters);
@@ -151,7 +151,7 @@ public async Task ShadowCopyE2EWorksWithFolderPresent()
151151
{
152152
using var directory = TempDirectory.Create();
153153
var deploymentParameters = Fixture.GetBaseDeploymentParameters();
154-
deploymentParameters.HandlerSettings["enableShadowCopy"] = "true";
154+
deploymentParameters.HandlerSettings["experimentalEnableShadowCopy"] = "true";
155155
deploymentParameters.HandlerSettings["shadowCopyDirectory"] = directory.DirectoryPath;
156156
var deploymentResult = await DeployAsync(deploymentParameters);
157157

0 commit comments

Comments
 (0)