Skip to content

Commit f7711a4

Browse files
authored
Fixes #37443
1 parent 197a3d1 commit f7711a4

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

.azure/pipelines/ci.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,6 @@ stages:
647647
cancelTimeoutInMinutes: 30
648648
buildArgs: -all -pack -test -binaryLog /p:SkipHelixReadyTests=true /p:SkipIISNewHandlerTests=true /p:SkipIISTests=true
649649
/p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false
650-
/p:SkipComponentsE2ETests=true
651650
$(_InternalRuntimeDownloadArgs)
652651
beforeBuild:
653652
- powershell: "& ./src/Servers/IIS/tools/UpdateIISExpressCertificate.ps1; & ./src/Servers/IIS/tools/update_schema.ps1"
@@ -669,7 +668,7 @@ stages:
669668
agentOs: macOS
670669
timeoutInMinutes: 240
671670
isAzDOTestingJob: true
672-
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipComponentsE2ETests=true /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
671+
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
673672
beforeBuild:
674673
- bash: "./eng/scripts/install-nginx-mac.sh"
675674
displayName: Installing Nginx
@@ -690,7 +689,7 @@ stages:
690689
agentOs: Linux
691690
isAzDOTestingJob: true
692691
useHostedUbuntu: false
693-
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipComponentsE2ETests=true /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
692+
buildArgs: --all --test --binaryLog "/p:RunTemplateTests=false /p:SkipHelixReadyTests=true" $(_InternalRuntimeDownloadArgs)
694693
beforeBuild:
695694
- bash: "./eng/scripts/install-nginx-linux.sh"
696695
displayName: Installing Nginx
@@ -722,7 +721,7 @@ stages:
722721
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)
723722
displayName: Restore interop projects
724723
- script: ./eng/build.cmd -ci -nobl -noBuildRepoTasks -noRestore -test -all -noBuildNative -projects eng\helix\helix.proj
725-
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true /p:SkipComponentsE2ETests=true
724+
/p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildInteropProjects=true /p:RunTemplateTests=true
726725
/p:CrossgenOutput=false /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log $(_InternalRuntimeDownloadArgs)
727726
displayName: Run build.cmd helix target
728727
env:

.azure/pipelines/components-e2e-tests.yml

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ pr:
2121
variables:
2222
- name: DOTNET_SKIP_FIRST_TIME_EXPERIENCE
2323
value: true
24+
- name: EXECUTE_COMPONENTS_E2E_TESTS
25+
value: true
2426
- name: _TeamName
2527
value: AspNetCore
2628

src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
<SkipTests Condition="'$(SeleniumE2ETestsSupported)' != 'true'">true</SkipTests>
1515
<SkipTests Condition="'$(SeleniumE2ETestsSupported)' == 'true'">false</SkipTests>
1616

17-
<!-- Until we resolve reliability issues, we're disabling these E2E tests in the main CI job -->
18-
<SkipTests Condition="'$(SkipComponentsE2ETests)' == 'true'">true</SkipTests>
17+
<!-- Skip the Components E2E tests in CI unless explicitly configured otherwise via EXECUTE_COMPONENTS_E2E_TESTS -->
18+
<SkipTests Condition="'$(CI)' == 'true' and '$(EXECUTE_COMPONENTS_E2E_TESTS)' != 'true'">true</SkipTests>
1919

2020
<!-- Tests do not work on Helix or when bin/ directory is not in project directory due to undeclared dependency on test content. -->
2121
<BaseOutputPath />

0 commit comments

Comments
 (0)