Skip to content

Add Razor colorization grammar to VS' LSP client #17801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NTaylorMullen opened this issue Dec 12, 2019 · 0 comments
Closed

Add Razor colorization grammar to VS' LSP client #17801

NTaylorMullen opened this issue Dec 12, 2019 · 0 comments
Assignees
@NTaylorMullen
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
Razor LSP Preview 2

Comments

@NTaylorMullen
Copy link

We have a TextMate grammar for VSCode we should also use it for VS. The bulk of this work will be in dependency flows to determine how we consume our own TextMate grammar in multiple places in different formats.
@NTaylorMullen NTaylorMullen added enhancement This issue represents an ask for new feature or an enhancement to an existing one cost: S area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Dec 12, 2019
@NTaylorMullen NTaylorMullen added this to the Razor.Tooling milestone Dec 12, 2019
@NTaylorMullen NTaylorMullen self-assigned this Feb 3, 2020
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Feb 4, 2020
Add Razor colorization grammar to Visual Studio.
9fc9375 
- The new grammar will apply to our LSP editor Razor files.
- The grammar doesn't look to colorize the embedded languages correctly. Have reached out to the VS editor team to investigate the issue further.
- Couldn't add tests because this was more of an end-to-end scenario.
- Added a new pkdef to our extension to allow us to hand-edit pkdef's (ours are usually auto-generated) for features that do not have a code-first model (TextMate).
- Expanded the VSIX extension to build the grammar project on run to ensure we always get the latest grammar.
- Does not include "proper" colorization of Razor constructs, that's tracked at dotnet/aspnetcore#18769

dotnet/aspnetcore#17801
@NTaylorMullen NTaylorMullen mentioned this issue Feb 4, 2020
Merged
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Feb 9, 2020
Add Razor colorization grammar to Visual Studio.
330f6e0 
- The new grammar will apply to our LSP editor Razor files.
- The grammar doesn't look to colorize the embedded languages correctly. Have reached out to the VS editor team to investigate the issue further.
- Couldn't add tests because this was more of an end-to-end scenario.
- Added a new pkdef to our extension to allow us to hand-edit pkdef's (ours are usually auto-generated) for features that do not have a code-first model (TextMate).
- Expanded the VSIX extension to build the grammar project on run to ensure we always get the latest grammar.
- Does not include "proper" colorization of Razor constructs, that's tracked at dotnet/aspnetcore#18769

dotnet/aspnetcore#17801
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Feb 12, 2020
Include embedded language grammars in Razor VSIX extension.
e5bf0c4 
- VS TextMate grammars can only reference other grammars that are included in the scope of the extension. Therefore we need to reship the C# and HTML grammars; however, the HTML grammar also depends on the JavaScript and CSS grammars so we need to ship those as well.

dotnet/aspnetcore#17801
@NTaylorMullen NTaylorMullen mentioned this issue Feb 12, 2020
Merged
NTaylorMullen pushed a commit to dotnet/razor that referenced this issue Feb 23, 2020
Include embedded language grammars in Razor VSIX extension.
d1da04b 
- VS TextMate grammars can only reference other grammars that are included in the scope of the extension. Therefore we need to reship the C# and HTML grammars; however, the HTML grammar also depends on the JavaScript and CSS grammars so we need to ship those as well.

dotnet/aspnetcore#17801
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2020
@NTaylorMullen NTaylorMullen added the Done This issue has been fixed label Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NTaylorMullen NTaylorMullen

Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
Razor LSP Preview 2
Development

No branches or pull requests
1 participant
@NTaylorMullen