Skip to content

Enable CSharp Semantic tokens in VSCode #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ryanbrandenburg opened this issue Sep 30, 2020 · 6 comments
Closed

Enable CSharp Semantic tokens in VSCode #4323

ryanbrandenburg opened this issue Sep 30, 2020 · 6 comments
Labels
enhancement Small improvement request vscode
Milestone

Comments

@ryanbrandenburg
Copy link
Contributor

Right now CSharp semantic tokens are not enabled in VSCode because there's no way for use to call through to the CSharp LanguageServer. Other endpoints doing similar things use the vscode.execute<Blank>Provider commands, but no such command exists for Semantic Tokens because it's still a "draft" part of the LSP spec.

@ryanbrandenburg
Copy link
Contributor Author

VSCode added the API's we need, now available on insiders. microsoft/vscode@f101028

@allisonchou allisonchou transferred this issue from dotnet/aspnetcore Oct 1, 2021
@allisonchou allisonchou added this to the 17.1 Candidates milestone Oct 1, 2021
@allisonchou allisonchou added help wanted Good issue for community contributions vscode enhancement Small improvement request and removed help wanted Good issue for community contributions labels Oct 1, 2021
@allisonchou allisonchou modified the milestones: 17.1 Candidates, Backlog Oct 7, 2021
@winstliu
Copy link
Contributor

@NTaylorMullen and Ryan, seeing that VS Code has added the APIs, I'm interested to know how much work you expect wiring up semantic highlighting in VS Code to be, and if it's something you can reasonably see an outside contribution for?
This has caught my eye but want to make sure I won't be stepping on your toes/going in over my head if I were to proceed :).

@ryanbrandenburg
Copy link
Contributor Author

We're still trying to solidify our current C# semantic token strategy so we aren't fully ready to accept a contribution yet but love that you're digging into the guts of Razor!

@winstliu
Copy link
Contributor

Understandable, thanks for letting me know!

@XorZy
Copy link

XorZy commented Sep 2, 2023

Any updates?

@davidwengier
Copy link
Member

This was fixed in dotnet/vscode-csharp#6489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small improvement request vscode
Projects
None yet
Development

No branches or pull requests

5 participants