Skip to content

Improve TLS mismatch error messages/experience #27472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrennanConroy opened this issue Nov 2, 2020 · 7 comments
Closed

Improve TLS mismatch error messages/experience #27472

BrennanConroy opened this issue Nov 2, 2020 · 7 comments
Labels
affected-medium This issue impacts approximately half of our customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool

Comments

@BrennanConroy
Copy link
Member

BrennanConroy commented Nov 2, 2020

  • Grpc hits this a lot
  • HTTP -> HTTPS
  • HTTPS -> HTTP
  • H2C -> HTTP(S)
@ghost
Copy link

ghost commented Nov 2, 2020

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@jkotalik jkotalik added affected-few This issue impacts only small number of customers enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool labels Nov 13, 2020 — with ASP.NET Core Issue Ranking
@Tratcher
Copy link
Member

Tratcher commented Dec 7, 2020

Nginx has a special status code for that:
497 HTTP Request Sent to HTTPS Port
http://nginx.org/en/docs/http/ngx_http_ssl_module.html

@halter73 halter73 added the affected-medium This issue impacts approximately half of our customers label Dec 7, 2020 — with ASP.NET Core Issue Ranking
@halter73 halter73 removed the affected-few This issue impacts only small number of customers label Dec 7, 2020
@Tratcher
Copy link
Member

Tratcher commented Dec 7, 2020

Note H2C -> HTTPS endpoint would trigger the same checks and message as HTTP -> HTTPS because of the connection preface unless we special cased the HTTP/2 prefface PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n.

@Tratcher
Copy link
Member

@JamesNK this looks like a duplicate of another issue you were working on?

@JamesNK
Copy link
Member

JamesNK commented Sep 13, 2022

I improved the mismatch between HTTP/1.1 and HTTP/2. I haven't done anything for TLS.

@Tratcher
Copy link
Member

What was the issue number?

@JamesNK
Copy link
Member

JamesNK commented Sep 13, 2022

#14884

Yes, this can be closed as a dupe.

@JamesNK JamesNK closed this as completed Sep 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-medium This issue impacts approximately half of our customers area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one severity-nice-to-have This label is used by an internal tool
Projects
None yet
Development

No branches or pull requests

7 participants