Skip to content

HTTP/3: Support request body rate timeout #29655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JamesNK opened this issue Jan 27, 2021 · 2 comments
Closed

HTTP/3: Support request body rate timeout #29655

JamesNK opened this issue Jan 27, 2021 · 2 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Jan 27, 2021

  • Respect configuration
  • Add unit tests
  • Ensure it can be disabled with feature
@ghost
Copy link

ghost commented Jan 27, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We will evaluate the request when we are planning the work for the next milestone. To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@halter73
Copy link
Member

halter73 commented Jan 27, 2021

Edit: Since this is a bit much for what started as a limited issue I've opened #29702 with all the items below.

I think we should have equivalents to most of Http2TimeoutTests for HTTP/3.

More timeouts to add and/or verify:

If any the above bullet points aren't implemented yet, they probably deserve their own issue. The same goes for the size and count based limits in KestrelServerLimits.

  • MaxRequestLineSize
  • MaxRequestHeadersTotalSize
  • MaxRequestHeaderCount
  • MaxRequestBodySize
  • MaxConcurrentConnections

@JamesNK JamesNK closed this as completed Apr 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3
Projects
None yet
Development

No branches or pull requests

4 participants