Skip to content

Bring back Random.Shared API once new SDK is picked up #31782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HaoK opened this issue Apr 13, 2021 · 7 comments · Fixed by #32221
Closed

Bring back Random.Shared API once new SDK is picked up #31782

HaoK opened this issue Apr 13, 2021 · 7 comments · Fixed by #32221
Assignees
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed feature-templates ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! task
Milestone

Comments

@HaoK
Copy link
Member

HaoK commented Apr 13, 2021

Noticed this while looking at why the blazor template tests are 100% failing now in the quarantined runs:

Related to this PR: https://github.com/dotnet/aspnetcore/pull/31453/files

https://dev.azure.com/dnceng/public/_test/analytics?definitionId=869&contextType=build

C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\Controllers\WeatherForecastController.cs(35,39): error CS0117: 'Random' does not contain a definition for 'Shared' [C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\AspNet.klo4c0qemnm.Server.csproj]
C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\Controllers\WeatherForecastController.cs(36,44): error CS0117: 'Random' does not contain a definition for 'Shared' [C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\AspNet.klo4c0qemnm.Server.csproj]
@HaoK HaoK added test-failure area-blazor Includes: Blazor, Razor Components labels Apr 13, 2021
@javiercn
Copy link
Member

@HaoK good catch.

I ran into this last week too, I thought it was because we were missing an updated SDK on the repo. I expect these to go away once we update the SDK in our repo

@davidfowl
Copy link
Member

When will that happen?

@javiercn
Copy link
Member

@davidfowl My understanding is before we ship preview4, otherwise we need to back this change out on Friday.

@davidfowl
Copy link
Member

Are the tests being skipped? Do we know when the update is coming? In general we shouldn't merge these until the dependency PR flows in.

@javiercn
Copy link
Member

@davidfowl agree.

This was originally a community contribution. We rely on CTI tests for the SPA templates and the Blazor tests are quarantined at the moment while we work on improving their reliability

@javiercn
Copy link
Member

@davidfowl here is a PR to revert the commit #31795

@captainsafia captainsafia changed the title Random.Shared missing build errors in quarantined template tests Bring back Random.Shared API once new SDK is picked up Apr 14, 2021
@ghost
Copy link

ghost commented Apr 15, 2021

Thanks for contacting us.
We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. Because it's not immediately obvious that this is a bug in our framework, we would like to keep this around to collect more feedback, which can later help us determine the impact of it. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost ghost closed this as completed in #32221 Apr 28, 2021
@HaoK HaoK added Done This issue has been fixed ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! labels Apr 28, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components Done This issue has been fixed feature-templates ✔️ Resolution: Fixed The bug or enhancement requested in this issue has been checked-in! task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants