Skip to content

Remove dotnet new --uninstall workaround from the template #31807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pranavkm opened this issue Apr 14, 2021 · 3 comments
Closed

Remove dotnet new --uninstall workaround from the template #31807

pranavkm opened this issue Apr 14, 2021 · 3 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Apr 14, 2021

SDK issue: dotnet/templating#3041

Commit to undo: 360f705 (a small part of #31748)

@pranavkm pranavkm added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 14, 2021
@dougbu
Copy link
Contributor

dougbu commented Apr 19, 2021

To clarify: It's likely not possible to revert 360f705 in the normal way because that commit was squashed into @cede6c4fbb3a along w/ the rest of #31748. But, we should undo that part of the PR when dotnet/templating#3041 is fixed.

@pranavkm will we need to react in other ways once dotnet/templating#3041 is fixed❔

@BrennanConroy
Copy link
Member

Was this resolved as part of 90137b0?

If so, I'll close this when that change gets to main.

@dougbu
Copy link
Contributor

dougbu commented Apr 25, 2021

Was this resolved as part of 90137b0

Yes and @halter73 cherry-picked that from #32054 but the merge from preview4 got into 'main' first. I'll close #32054, with thanks to @DavidKarlas.

If so, I'll close this when that change gets to main.

It has 😀

@dougbu dougbu closed this as completed Apr 25, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

No branches or pull requests

3 participants