Skip to content

Request ws web socket library upgrade to avoid any potential DDoS attacks #32220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mharper010 opened this issue Apr 27, 2021 · 2 comments · Fixed by #32577
Closed

Request ws web socket library upgrade to avoid any potential DDoS attacks #32220

mharper010 opened this issue Apr 27, 2021 · 2 comments · Fixed by #32577
Labels
area-signalr Includes: SignalR clients and servers
Milestone

Comments

@mharper010
Copy link

Is your feature request related to a problem? Please describe.

Our static code analysis (Veracode) detects a potential DDoS attack with the ws web socket library v6.2.1 utilized by @microsoft/signalr. A malicious user is able to cause the process to crash by using the permessage-deflate extension.

Class: lib/permessage-deflate.js
Method: PerMessageDeflate#_decompress()

Details: https://sca.analysiscenter.veracode.com/vulnerability-database/security/sca/vulnerability/sid-29608/summary

Describe the solution you'd like

The ws v7.4.4 (or higher) corrects this issue. I do not see anything (even in the preview) that suggests that Microsoft is upgrading to ws v7.4.4 or higher. Any potential upgrade planned?

@pranavkm pranavkm added the area-signalr Includes: SignalR clients and servers label Apr 27, 2021
@BrennanConroy
Copy link
Member

We currently reference 7.4.3 in main, looks like 7.4.4 just came out. We have no problem updating in main here. But we are unlikely to change major versions in other releases.

As a workaround, you can manually reference a newer version of "ws" in your project.json assuming there are no breaking changes that would affect the signalr library.

@BrennanConroy BrennanConroy added this to the Next sprint planning milestone Apr 28, 2021
@ghost
Copy link

ghost commented Apr 28, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants