Skip to content

FileLoggerProcessorTests.RollsTextFiles #34284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tratcher opened this issue Jul 12, 2021 · 5 comments · Fixed by #38814
Closed

FileLoggerProcessorTests.RollsTextFiles #34284

Tratcher opened this issue Jul 12, 2021 · 5 comments · Fixed by #38814
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure
Milestone

Comments

@Tratcher
Copy link
Member

Tratcher commented Jul 12, 2021

Failing Test(s)

Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.RollsTextFiles

Error Message

   Assert.Equal() Failure
          ↓ (pos 0)
Expected: Message two\n
Actual:   
          ↑ (pos 0)
  Stack Trace:
     at Microsoft.AspNetCore.HttpLogging.FileLoggerProcessorTests.RollsTextFiles() in /_/src/Middleware/HttpLogging/test/FileLoggerProcessorTests.cs:line 117

Assert.Equal("Message two" + Environment.NewLine, File.ReadAllText(fileName2));

Build

https://dev.azure.com/dnceng/public/_build/results?buildId=1231336&view=ms.vss-test-web.build-test-results-tab&runId=36670362&resultId=110218&paneView=debug
(Alpine.312.Amd64.Open)Ubuntu.1804.Amd64.Open

@ghost
Copy link

ghost commented Jul 12, 2021

Thanks for contacting us.

We're moving this issue to the Next sprint planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@wtgodbe
Copy link
Member

wtgodbe commented Jul 14, 2021

Interesting, the file exists but was empty. Not one I ever saw during development - I can take a look after feature work is done

@HaoK
Copy link
Member

HaoK commented Dec 3, 2021

Doesn't look like this has happened recently, 30 day clean run, should we just reenable this so we can see if/when it fails again?

@HaoK
Copy link
Member

HaoK commented Dec 3, 2021

image

@wtgodbe
Copy link
Member

wtgodbe commented Dec 3, 2021

Yeah, should be fine to unquarantine - we had a community PR to improve these tests a while back

@HaoK HaoK self-assigned this Dec 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 3, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants