Skip to content

Adopt consistent approach for defining InternalsVisibleTo in the repo #41244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
captainsafia opened this issue Apr 18, 2022 · 2 comments · Fixed by #45748
Closed

Adopt consistent approach for defining InternalsVisibleTo in the repo #41244

captainsafia opened this issue Apr 18, 2022 · 2 comments · Fixed by #45748
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework help wanted Up for grabs. We would accept a PR to help resolve this issue task
Milestone

Comments

@captainsafia
Copy link
Member

This is a follow-up to some PR feedback I received in #41238 (comment) (and other PRs).

We use two different strategies for defining IVT in the repo at the moment:

  • Property in the build
  • Assembly attribute in source

For consistency, we might want to consider adopting one standard throughout the repo and using that everywhere.

@captainsafia captainsafia added task area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework labels Apr 18, 2022
@Tratcher
Copy link
Member

Declaring it in the csproj file is simpler and cleaner. We used the assembly attribute before because the csproj option wasn't available.

@mkArtakMSFT mkArtakMSFT added this to the Backlog milestone Dec 7, 2022
@ghost
Copy link

ghost commented Dec 7, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@Tratcher Tratcher added the help wanted Up for grabs. We would accept a PR to help resolve this issue label Dec 7, 2022
@Tratcher Tratcher changed the title Adopt consistent approach for defining IVT in the repo Adopt consistent approach for defining InternalsVisibleTo in the repo Dec 7, 2022
@Tratcher Tratcher modified the milestones: Backlog, 8.0-preview1 Dec 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework help wanted Up for grabs. We would accept a PR to help resolve this issue task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@Tratcher @captainsafia @mkArtakMSFT and others