Skip to content

Add EventSource logging to RateLimitingMiddleware #41266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wtgodbe opened this issue Apr 19, 2022 · 4 comments
Open

Add EventSource logging to RateLimitingMiddleware #41266

wtgodbe opened this issue Apr 19, 2022 · 4 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Comments

@wtgodbe
Copy link
Member

wtgodbe commented Apr 19, 2022

Follow-up to #41008, part of #37384. See https://github.com/dotnet/aspnetcore/blob/main/docs/EventSourceAndCounters.md. Should give info about what fired a given acceptance/rejection, and perhaps do counters here too. Related to #44140

@davidfowl
Copy link
Member

What are we adding? Can we list the events and counters here? I wonder if we should switch to metrics in .NET 7?

cc @noahfalk

@adityamandaleeka
Copy link
Member

@wtgodbe Do we have a set of things we want to add for this? Will it happen in preview6?

@wtgodbe wtgodbe modified the milestones: 7.0-preview5, 7.0-preview7 Jun 9, 2022
@wtgodbe
Copy link
Member Author

wtgodbe commented Jun 9, 2022

Not yet - I'm planning to do it in the endpoint PR, unless that would put that PR at risk of missing preview6. In that case I'd do it in a separate PR for preview7

@wtgodbe wtgodbe modified the milestones: 7.0-preview7, 7.0-rc1 Jul 11, 2022
@wtgodbe wtgodbe modified the milestones: 7.0-rc1, 7.0-rc2 Aug 9, 2022
@ghost
Copy link

ghost commented Sep 9, 2022

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@wtgodbe wtgodbe removed their assignment Nov 28, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

No branches or pull requests

5 participants
@davidfowl @adityamandaleeka @amcasey @wtgodbe and others