Skip to content

Benchmark validation doesn't appear to be working on non-Windows OS #46495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
JamesNK opened this issue Feb 7, 2023 · 2 comments
Open
1 task done

Benchmark validation doesn't appear to be working on non-Windows OS #46495

JamesNK opened this issue Feb 7, 2023 · 2 comments
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework bug This issue describes a behavior which is not expected - a bug.

Comments

@JamesNK
Copy link
Member

JamesNK commented Feb 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Benchmarks written with benchmarkdotnet are validated on build:

<Target Name="ValidateBenchmarks" BeforeTargets="Test" Condition="'$(IsMicrobenchmarksProject)' == 'true' AND '$(SkipMicrobenchmarksValidation)' != 'true'">
<Message Text="%0ARunning benchmark validation for:%0A$(MSBuildProjectName)%0A"
Importance="High" />
<MSBuild Projects="$(MSBuildProjectFullPath)" Targets="GetTargetPath">
<Output TaskParameter="TargetOutputs" PropertyName="ExecPath" />
</MSBuild>
<Exec Command="dotnet $(ExecPath) -f * --validate-fast" IgnoreStandardErrorWarningFormat="true" StandardOutputImportance="low" />
</Target>

It appears that failures are only correctly reported on Windows. This behavior was noticed when I added a benchmark that is only valid for Windows, but tests all passed.

For example, I added an exception to a benchmark's setup here - #46491 - and only Windows tests failed:

image

I can see in the logs that they are being detected and run on other OS, but no error reported:

image

Expected Behavior

Validation reports problems and the build fails on Linux and macOS.

Steps To Reproduce

#46491

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@JamesNK JamesNK added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 7, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Feb 7, 2023

cc @BrennanConroy

@mkArtakMSFT mkArtakMSFT added investigate bug This issue describes a behavior which is not expected - a bug. and removed investigate labels Feb 7, 2023
@mkArtakMSFT mkArtakMSFT added this to the .NET 8 Planning milestone Feb 7, 2023
@ghost
Copy link

ghost commented Feb 7, 2023

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework bug This issue describes a behavior which is not expected - a bug.
Projects
None yet
Development

No branches or pull requests

4 participants
@JamesNK @wtgodbe @mkArtakMSFT and others