Benchmark validation doesn't appear to be working on non-Windows OS #46495
Labels
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
bug
This issue describes a behavior which is not expected - a bug.
Milestone
Is there an existing issue for this?
Describe the bug
Benchmarks written with benchmarkdotnet are validated on build:
aspnetcore/eng/targets/CSharp.Common.targets
Lines 133 to 142 in f0af112
It appears that failures are only correctly reported on Windows. This behavior was noticed when I added a benchmark that is only valid for Windows, but tests all passed.
For example, I added an exception to a benchmark's setup here - #46491 - and only Windows tests failed:
I can see in the logs that they are being detected and run on other OS, but no error reported:
Expected Behavior
Validation reports problems and the build fails on Linux and macOS.
Steps To Reproduce
#46491
Exceptions (if any)
No response
.NET Version
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: