-
Notifications
You must be signed in to change notification settings - Fork 10.3k
QR Codes should be supported in templates #5405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This requires additional APIs in the platform (.NET Core) or external libraries. I don't wish to include the JS library in the templates just for the QR code. Similarly I don't want to include a 3rd-party server-side drawing library just to enable it either (e.g.
|
cc @blowdart |
System.Drawing is not suitable, as it's a straight port of the "do not use in a web app code" |
Yeah, but people do anyway. Always have, always will. There isn't any plan for a System.* replacement AFAIK, so if we don't use it, we need to make something custom (not out of the question given it's just a QR code) or look at |
ping @muratg who was looking at this too |
But we shouldn't. Anyway it's not cross platform. |
It is? I couldn't remember if they limited that one to Windows or not. Many packages in the "Windows compat pack" actually have *nix implementations included as well. |
I think so, either way, we don't want to encourage the use of something that may leak memory and handles. |
@blowdart so serious 😉 Well then, given |
We are, so we stick with the current situation IMO |
Moving this to 2.2.0. |
@blowdart, moving this out to 3.0 as I don't think this is a priority for 2.2 |
Closing this as it seems we won't be able to do this in the near future. |
@mkArtakMSFT can we schedule this for 3.1? |
Enabling QR Code generation for authenticator apps
That should be supported in the templates like SMS 2FA used to be.
requested by customer in Enabling QR Code generation for authenticator apps comments
The text was updated successfully, but these errors were encountered: