From e1e839a9cd2d73a978b53ea0a9844de68ffdfdc3 Mon Sep 17 00:00:00 2001 From: Steve Sanderson Date: Wed, 14 Oct 2020 13:46:22 +0100 Subject: [PATCH 1/2] XML docs for Middleware/Localization and Localization.Routing --- .../Microsoft.AspNetCore.Localization.Routing.csproj | 2 +- .../Localization/src/ApplicationBuilderExtensions.cs | 12 ++++++------ .../src/Microsoft.AspNetCore.Localization.csproj | 2 +- ...RequestLocalizationServiceCollectionExtensions.cs | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Middleware/Localization.Routing/src/Microsoft.AspNetCore.Localization.Routing.csproj b/src/Middleware/Localization.Routing/src/Microsoft.AspNetCore.Localization.Routing.csproj index 3fbf8734b6f0..56bd8e7a83b6 100644 --- a/src/Middleware/Localization.Routing/src/Microsoft.AspNetCore.Localization.Routing.csproj +++ b/src/Middleware/Localization.Routing/src/Microsoft.AspNetCore.Localization.Routing.csproj @@ -5,7 +5,7 @@ Provides a request culture provider which gets culture and ui-culture from request's route data. $(DefaultNetCoreTargetFramework) true - $(NoWarn);CS1591 + $(NoWarn.Replace('1591', '')) true aspnetcore;localization false diff --git a/src/Middleware/Localization/src/ApplicationBuilderExtensions.cs b/src/Middleware/Localization/src/ApplicationBuilderExtensions.cs index 9f2a0dac5930..819c5d36d33f 100644 --- a/src/Middleware/Localization/src/ApplicationBuilderExtensions.cs +++ b/src/Middleware/Localization/src/ApplicationBuilderExtensions.cs @@ -1,5 +1,5 @@ -// Copyright (c) .NET Foundation. All rights reserved. -// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. +// Copyright (c) .NET Foundation. All rights reserved. +// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using Microsoft.AspNetCore.Localization; @@ -43,7 +43,7 @@ public static IApplicationBuilder UseRequestLocalization( { throw new ArgumentNullException(nameof(app)); } - + if (options == null) { throw new ArgumentNullException(nameof(options)); @@ -54,10 +54,10 @@ public static IApplicationBuilder UseRequestLocalization( /// /// Adds the to automatically set culture information for - /// requests based on information provided by the client. + /// requests based on information provided by the client. /// /// The . - /// + /// A callback that configures the . /// /// This will going to instantiate a new that doesn't come from the services. /// @@ -84,7 +84,7 @@ public static IApplicationBuilder UseRequestLocalization( /// /// Adds the to automatically set culture information for - /// requests based on information provided by the client. + /// requests based on information provided by the client. /// /// The . /// The culture names to be added by the application, which is represents both supported cultures and UI cultures. diff --git a/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj b/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj index 20a32d0507b8..be913c0c66be 100644 --- a/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj +++ b/src/Middleware/Localization/src/Microsoft.AspNetCore.Localization.csproj @@ -5,7 +5,7 @@ ASP.NET Core middleware for automatically applying culture information to HTTP requests. Culture information can be specified in the HTTP header, query string, cookie, or custom source. $(DefaultNetCoreTargetFramework) true - $(NoWarn);CS1591 + $(NoWarn.Replace('1591', '')) true aspnetcore;localization false diff --git a/src/Middleware/Localization/src/RequestLocalizationServiceCollectionExtensions.cs b/src/Middleware/Localization/src/RequestLocalizationServiceCollectionExtensions.cs index d261ab7b0713..9e0cf69953af 100644 --- a/src/Middleware/Localization/src/RequestLocalizationServiceCollectionExtensions.cs +++ b/src/Middleware/Localization/src/RequestLocalizationServiceCollectionExtensions.cs @@ -16,7 +16,7 @@ public static class RequestLocalizationServiceCollectionExtensions /// /// The for adding services. /// A delegate to configure the . - /// + /// The . public static IServiceCollection AddRequestLocalization(this IServiceCollection services, Action configureOptions) { if (services == null) @@ -36,7 +36,7 @@ public static IServiceCollection AddRequestLocalization(this IServiceCollection /// /// The for adding services. /// A delegate to configure the . - /// + /// The . public static IServiceCollection AddRequestLocalization(this IServiceCollection services, Action configureOptions) where TService : class { if (services == null) From df41f857f3f9dcf09fcc94c179bd0c714f42484a Mon Sep 17 00:00:00 2001 From: Steve Sanderson Date: Wed, 14 Oct 2020 13:55:16 +0100 Subject: [PATCH 2/2] XML docs for Middleware/ResponseCompression --- .../src/BrotliCompressionProvider.cs | 2 +- .../ResponseCompression/src/GzipCompressionProvider.cs | 2 +- .../src/IResponseCompressionProvider.cs | 10 +++++----- .../Microsoft.AspNetCore.ResponseCompression.csproj | 1 + .../src/ResponseCompressionMiddleware.cs | 8 ++++---- .../src/ResponseCompressionProvider.cs | 2 +- .../src/ResponseCompressionServicesExtensions.cs | 4 ++-- 7 files changed, 15 insertions(+), 14 deletions(-) diff --git a/src/Middleware/ResponseCompression/src/BrotliCompressionProvider.cs b/src/Middleware/ResponseCompression/src/BrotliCompressionProvider.cs index 6cc0a88d5d7d..55f2939b8097 100644 --- a/src/Middleware/ResponseCompression/src/BrotliCompressionProvider.cs +++ b/src/Middleware/ResponseCompression/src/BrotliCompressionProvider.cs @@ -16,7 +16,7 @@ public class BrotliCompressionProvider : ICompressionProvider /// /// Creates a new instance of with options. /// - /// + /// The options for this instance. public BrotliCompressionProvider(IOptions options) { if (options == null) diff --git a/src/Middleware/ResponseCompression/src/GzipCompressionProvider.cs b/src/Middleware/ResponseCompression/src/GzipCompressionProvider.cs index 0a001e0d53f1..9f96e5491c61 100644 --- a/src/Middleware/ResponseCompression/src/GzipCompressionProvider.cs +++ b/src/Middleware/ResponseCompression/src/GzipCompressionProvider.cs @@ -16,7 +16,7 @@ public class GzipCompressionProvider : ICompressionProvider /// /// Creates a new instance of GzipCompressionProvider with options. /// - /// + /// The options for this instance. public GzipCompressionProvider(IOptions options) { if (options == null) diff --git a/src/Middleware/ResponseCompression/src/IResponseCompressionProvider.cs b/src/Middleware/ResponseCompression/src/IResponseCompressionProvider.cs index c206acbb5776..c3edc46b1299 100644 --- a/src/Middleware/ResponseCompression/src/IResponseCompressionProvider.cs +++ b/src/Middleware/ResponseCompression/src/IResponseCompressionProvider.cs @@ -13,22 +13,22 @@ public interface IResponseCompressionProvider /// /// Examines the request and selects an acceptable compression provider, if any. /// - /// + /// The . /// A compression provider or null if compression should not be used. ICompressionProvider GetCompressionProvider(HttpContext context); /// /// Examines the response on first write to see if compression should be used. /// - /// - /// + /// The . + /// if the response should be compressed, otherwise . bool ShouldCompressResponse(HttpContext context); /// /// Examines the request to see if compression should be used for response. /// - /// - /// + /// The . + /// if the request accepts compression, otherwise . bool CheckRequestAcceptsCompression(HttpContext context); } } diff --git a/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj b/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj index d63d281422aa..44af1104da6c 100644 --- a/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj +++ b/src/Middleware/ResponseCompression/src/Microsoft.AspNetCore.ResponseCompression.csproj @@ -4,6 +4,7 @@ ASP.NET Core middleware for HTTP Response compression. $(DefaultNetCoreTargetFramework) true + $(NoWarn.Replace('1591', '')) true aspnetcore false diff --git a/src/Middleware/ResponseCompression/src/ResponseCompressionMiddleware.cs b/src/Middleware/ResponseCompression/src/ResponseCompressionMiddleware.cs index 16a16d233ba1..0d0715db213a 100644 --- a/src/Middleware/ResponseCompression/src/ResponseCompressionMiddleware.cs +++ b/src/Middleware/ResponseCompression/src/ResponseCompressionMiddleware.cs @@ -21,8 +21,8 @@ public class ResponseCompressionMiddleware /// /// Initialize the Response Compression middleware. /// - /// - /// + /// The delegate representing the remaining middleware in the request pipeline. + /// The . public ResponseCompressionMiddleware(RequestDelegate next, IResponseCompressionProvider provider) { if (next == null) @@ -41,8 +41,8 @@ public ResponseCompressionMiddleware(RequestDelegate next, IResponseCompressionP /// /// Invoke the middleware. /// - /// - /// + /// The . + /// A task that represents the execution of this middleware. public async Task Invoke(HttpContext context) { if (!_provider.CheckRequestAcceptsCompression(context)) diff --git a/src/Middleware/ResponseCompression/src/ResponseCompressionProvider.cs b/src/Middleware/ResponseCompression/src/ResponseCompressionProvider.cs index 8592f2526012..dbffed6357ac 100644 --- a/src/Middleware/ResponseCompression/src/ResponseCompressionProvider.cs +++ b/src/Middleware/ResponseCompression/src/ResponseCompressionProvider.cs @@ -28,7 +28,7 @@ public class ResponseCompressionProvider : IResponseCompressionProvider /// If no compression providers are specified then GZip is used by default. /// /// Services to use when instantiating compression providers. - /// + /// The options for this instance. public ResponseCompressionProvider(IServiceProvider services, IOptions options) { if (services == null) diff --git a/src/Middleware/ResponseCompression/src/ResponseCompressionServicesExtensions.cs b/src/Middleware/ResponseCompression/src/ResponseCompressionServicesExtensions.cs index 8d0b1ed2b30e..f089cea6a855 100644 --- a/src/Middleware/ResponseCompression/src/ResponseCompressionServicesExtensions.cs +++ b/src/Middleware/ResponseCompression/src/ResponseCompressionServicesExtensions.cs @@ -17,7 +17,7 @@ public static class ResponseCompressionServicesExtensions /// Add response compression services. /// /// The for adding services. - /// + /// The . public static IServiceCollection AddResponseCompression(this IServiceCollection services) { if (services == null) @@ -34,7 +34,7 @@ public static IServiceCollection AddResponseCompression(this IServiceCollection /// /// The for adding services. /// A delegate to configure the . - /// + /// The . public static IServiceCollection AddResponseCompression(this IServiceCollection services, Action configureOptions) { if (services == null)