Skip to content

Blazor querystring APIs (follow-up) #35198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2021
Merged

Blazor querystring APIs (follow-up) #35198

merged 2 commits into from
Aug 10, 2021

Conversation

MackinnonBuck
Copy link
Member

Blazor querystring APIs (follow-up)
This PR addresses the API review feedback for the new Blazor querystring generation APIs.

PR Description

  • Removed all overloads of UriWithQueryParameter accepting IEnumerable<T> values.
  • Renamed remaining overloads of UriWithQueryParameter to GetUriWithQueryParameter
  • Renamed both overloads of UriWithQueryParameters to GetUriWithQueryParameters

Addresses feedback in #34115

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner August 9, 2021 20:39
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 9, 2021
@MackinnonBuck MackinnonBuck requested a review from pranavkm August 9, 2021 20:39
@MackinnonBuck MackinnonBuck merged commit 66a8818 into main Aug 10, 2021
@MackinnonBuck MackinnonBuck deleted the t-mbuck/query-string-apis-follow-up branch August 10, 2021 16:00
@ghost ghost added this to the 6.0-rc1 milestone Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@MackinnonBuck @pranavkm