From f87a315d2992df716cd4a79672a3666668011ce6 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Wed, 18 Aug 2021 18:41:37 -0700 Subject: [PATCH 1/3] Skip consistently failing Components.E2ETests.ServerExecutionTests --- .../E2ETest/ServerExecutionTests/ServerTransportsTest.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs index 03d73f2bdc1a..9084f4dce9fb 100644 --- a/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs +++ b/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs @@ -25,7 +25,7 @@ public ServerTransportsTest( { } - [Fact] + [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] public void DefaultTransportsWorksWithWebSockets() { Navigate("/defaultTransport/Transports"); @@ -43,7 +43,7 @@ public void DefaultTransportsWorksWithWebSockets() "Blazor server-side application started."); } - [Fact] + [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] public void ErrorIfClientAttemptsLongPollingWithServerOnWebSockets() { Navigate("/defaultTransport/Transports"); @@ -64,7 +64,7 @@ public void ErrorIfClientAttemptsLongPollingWithServerOnWebSockets() Browser.Equal("block", () => errorUiElem.GetCssValue("display")); } - [Fact] + [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] public void ErrorIfWebSocketsConnectionIsRejected() { Navigate("/defaultTransport/Transports"); @@ -88,7 +88,7 @@ public void ErrorIfWebSocketsConnectionIsRejected() Browser.Equal("block", () => errorUiElem.GetCssValue("display")); } - [Fact] + [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] public void ErrorIfClientAttemptsWebSocketsWithServerOnLongPolling() { Navigate("/longPolling/Transports"); From da5d0d8c7eb943612e7fd07e662c061cf443061d Mon Sep 17 00:00:00 2001 From: Brennan Date: Thu, 19 Aug 2021 09:33:36 -0700 Subject: [PATCH 2/3] quarantine --- .../ServerExecutionTests/ServerTransportsTest.cs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs index 9084f4dce9fb..a7639928e6dd 100644 --- a/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs +++ b/src/Components/test/E2ETest/ServerExecutionTests/ServerTransportsTest.cs @@ -8,6 +8,7 @@ using Microsoft.AspNetCore.Components.E2ETest.Infrastructure; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.E2ETesting; +using Microsoft.AspNetCore.Testing; using OpenQA.Selenium; using TestServer; using Xunit; @@ -25,7 +26,8 @@ public ServerTransportsTest( { } - [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] + [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35481")] public void DefaultTransportsWorksWithWebSockets() { Navigate("/defaultTransport/Transports"); @@ -43,7 +45,8 @@ public void DefaultTransportsWorksWithWebSockets() "Blazor server-side application started."); } - [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] + [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35481")] public void ErrorIfClientAttemptsLongPollingWithServerOnWebSockets() { Navigate("/defaultTransport/Transports"); @@ -64,7 +67,8 @@ public void ErrorIfClientAttemptsLongPollingWithServerOnWebSockets() Browser.Equal("block", () => errorUiElem.GetCssValue("display")); } - [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] + [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35481")] public void ErrorIfWebSocketsConnectionIsRejected() { Navigate("/defaultTransport/Transports"); @@ -88,7 +92,8 @@ public void ErrorIfWebSocketsConnectionIsRejected() Browser.Equal("block", () => errorUiElem.GetCssValue("display")); } - [Fact(Skip = "https://github.com/dotnet/aspnetcore/issues/35481")] + [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35481")] public void ErrorIfClientAttemptsWebSocketsWithServerOnLongPolling() { Navigate("/longPolling/Transports"); From 0d3b376bc4dbfc1956ebc178ff1eca3192418f43 Mon Sep 17 00:00:00 2001 From: Steve Sanderson Date: Thu, 19 Aug 2021 23:29:52 +0100 Subject: [PATCH 3/3] Revert incorrect "run quarantined tests" flag --- .azure/pipelines/components-e2e-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.azure/pipelines/components-e2e-tests.yml b/.azure/pipelines/components-e2e-tests.yml index ed817d303921..322649488141 100644 --- a/.azure/pipelines/components-e2e-tests.yml +++ b/.azure/pipelines/components-e2e-tests.yml @@ -42,7 +42,6 @@ stages: cancelTimeoutInMinutes: 30 buildArgs: -all -test /p:SkipHelixReadyTests=true /p:SkipIISNewHandlerTests=true /p:SkipIISTests=true /p:SkipIISExpressTests=true /p:SkipIISNewShimTests=true /p:RunTemplateTests=false - /p:RunQuarantinedTests=true beforeBuild: - powershell: "& ./src/Servers/IIS/tools/UpdateIISExpressCertificate.ps1; & ./src/Servers/IIS/tools/update_schema.ps1" displayName: Setup IISExpress test certificates and schema