From 377305cb0282fc4df87ebe2a3f33d951f2995888 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Tue, 22 Aug 2023 12:22:59 -0700 Subject: [PATCH 1/2] Remove reflection from KestrelServer constructor --- src/Servers/Kestrel/Core/src/KestrelServer.cs | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/Servers/Kestrel/Core/src/KestrelServer.cs b/src/Servers/Kestrel/Core/src/KestrelServer.cs index 3e863d3a3c04..8ba7cd7cbb8d 100644 --- a/src/Servers/Kestrel/Core/src/KestrelServer.cs +++ b/src/Servers/Kestrel/Core/src/KestrelServer.cs @@ -34,7 +34,7 @@ public KestrelServer(IOptions options, IConnectionListener options, new[] { transportFactory ?? throw new ArgumentNullException(nameof(transportFactory)) }, Array.Empty(), - new SimpleHttpsConfigurationService(loggerFactory), + new SimpleHttpsConfigurationService(), loggerFactory, new KestrelMetrics(new DummyMeterFactory())); } @@ -77,13 +77,6 @@ public void Dispose() { } private sealed class SimpleHttpsConfigurationService : IHttpsConfigurationService { - private readonly ILogger _httpsLogger; - - public SimpleHttpsConfigurationService(ILoggerFactory loggerFactory) - { - _httpsLogger = loggerFactory.CreateLogger(); - } - public bool IsInitialized => true; public void Initialize(IHostEnvironment hostEnvironment, ILogger serverLogger, ILogger httpsLogger) @@ -93,7 +86,7 @@ public void Initialize(IHostEnvironment hostEnvironment, ILogger public void PopulateMultiplexedTransportFeatures(FeatureCollection features, ListenOptions listenOptions) { - HttpsConfigurationService.PopulateMultiplexedTransportFeaturesWorker(features, listenOptions, _httpsLogger); + throw new NotImplementedException(); // Not actually required by this impl } public ListenOptions UseHttpsWithDefaults(ListenOptions listenOptions) From 7d46e3a515aa7a5d8ce649fa296edd004ab5140c Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Tue, 22 Aug 2023 14:36:46 -0700 Subject: [PATCH 2/2] Update src/Servers/Kestrel/Core/src/KestrelServer.cs Co-authored-by: Andrew Casey --- src/Servers/Kestrel/Core/src/KestrelServer.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Servers/Kestrel/Core/src/KestrelServer.cs b/src/Servers/Kestrel/Core/src/KestrelServer.cs index 8ba7cd7cbb8d..75cec0130767 100644 --- a/src/Servers/Kestrel/Core/src/KestrelServer.cs +++ b/src/Servers/Kestrel/Core/src/KestrelServer.cs @@ -86,7 +86,7 @@ public void Initialize(IHostEnvironment hostEnvironment, ILogger public void PopulateMultiplexedTransportFeatures(FeatureCollection features, ListenOptions listenOptions) { - throw new NotImplementedException(); // Not actually required by this impl + throw new NotImplementedException(); // Not actually required by this impl, which never provides an IMultiplexedConnectionListenerFactory } public ListenOptions UseHttpsWithDefaults(ListenOptions listenOptions)