From 4e1b36edafec0b9c074f8539dbabd112c9b73911 Mon Sep 17 00:00:00 2001 From: Chad Tolkien Date: Thu, 8 Aug 2024 12:23:41 +1000 Subject: [PATCH 1/2] Updates the xml comments for the "AddRedirect" method to indicate what status code it returns. --- src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs b/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs index 7a0841b1dd32..a97314f097d3 100644 --- a/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs +++ b/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs @@ -50,7 +50,7 @@ public static RewriteOptions AddRewrite(this RewriteOptions options, [StringSynt } /// - /// Redirect the request if the regex matches the HttpContext's PathString + /// Redirect the request if the regex matches the HttpContext's PathString, with returning a 302 - Found status code. /// /// The . /// The regex string to compare with. @@ -76,7 +76,7 @@ public static RewriteOptions AddRedirect(this RewriteOptions options, [StringSyn } /// - /// Redirect a request to https if the incoming request is http, with returning a 301 + /// Redirect a request to https if the incoming request is http, with returning a 301 - Moved Permanently status code. /// status code for permanently redirected. /// /// The . From 3fe3e44cd4059499f7ff08ef1455d93259c96f34 Mon Sep 17 00:00:00 2001 From: Chad Tolkien Date: Mon, 26 Aug 2024 10:13:05 +1000 Subject: [PATCH 2/2] * Restore the comment for permanent redirect * Align 302 coments to match. --- src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs b/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs index a97314f097d3..e018c287f872 100644 --- a/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs +++ b/src/Middleware/Rewrite/src/RewriteOptionsExtensions.cs @@ -50,7 +50,8 @@ public static RewriteOptions AddRewrite(this RewriteOptions options, [StringSynt } /// - /// Redirect the request if the regex matches the HttpContext's PathString, with returning a 302 - Found status code. + /// Redirect the request if the regex matches the HttpContext's PathString, with returning a 302 + /// status code for found. /// /// The . /// The regex string to compare with. @@ -76,7 +77,7 @@ public static RewriteOptions AddRedirect(this RewriteOptions options, [StringSyn } /// - /// Redirect a request to https if the incoming request is http, with returning a 301 - Moved Permanently status code. + /// Redirect a request to https if the incoming request is http, with returning a 301 /// status code for permanently redirected. /// /// The .