[Blazor] Make _serializerCache static readonly to avoid creating dictionaries per instance #62661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change optimizes the
PersistentStateValueProvider
class by making the_serializerCache
field static instead of instance-level.Problem
Previously, every instance of
PersistentStateValueProvider
would create its ownConcurrentDictionary
for caching serializers, even though the serializers are typically registered as singletons in the DI container and don't vary between instances.Solution
Changed
_serializerCache
fromprivate readonly
toprivate static readonly
. This allows all instances to share the same cache, reducing memory allocation and improving performance when multiplePersistentStateValueProvider
instances are created.Impact
ConcurrentDictionary
is already thread-safe, making the static sharing safeTesting
Fixes #62659.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.